Merge remote-tracking branch 'origin/master' into dev-docker-build-from-src

Author: marc-casavant

.github/contributing.md

@@ -71,10 +71,10 @@ problem that doesn't require additional code, or may have ideas as to how your p
 in a way that will better fit with the long-term vision for the server.
 
 Once you've got the go ahead, please read through the
-[coding standards document](https://wiki.freeradius.org/contributing/coding-standards).
+[coding standards](https://www.freeradius.org/documentation/freeradius-server/4.0.0/developers/coding-methods.html) document.
 
 If you're creating a new module you may wish to read the
-[module creation guide](https://wiki.freeradius.org/contributing/Modules3).
+[module creation guide](https://www.freeradius.org/documentation/freeradius-server/4.0.0/developers/module_interface.html).
 
 You may also wish to utilise the [doxygen site](https://doc.freeradius.org) to review code documentation.
 
@@ -84,7 +84,7 @@ commit to the master branch of the freeradius-server repository.
 
 Finally, this file was written to be displayed automatically on the GitHub issue tracker, so
 Git/GitHub knowledge is assumed.  If you're wondering what a pull-request is, this document may be of
-some use <https://wiki.freeradius.org/contributing/GitHub>.
+some use <https://www.freeradius.org/documentation/freeradius-server/4.0.0/developers/github.html>
 
 
 ## Continuous Integration Tests (CIT)

.github/workflows/ci-macos.yml

@@ -9,7 +9,7 @@ on:
   pull_request:
 
 env:
-  ASAN_OPTIONS: symbolize=1 detect_leaks=1 detect_stack_use_after_return=1
+  ASAN_OPTIONS: symbolize=1 detect_leaks=0 detect_stack_use_after_return=1
   LSAN_OPTIONS: fast_unwind_on_malloc=0:malloc_context_size=50
   UBSAN_OPTIONS: print_stacktrace=1
   M_PERTURB: "0x42"

.gitignore

@@ -52,6 +52,9 @@ icon.png
 # OS specific cruft
 .DS_Store
 
+# Claude Code
+CLAUDE.md
+
 # Archives
 freeradius-server-*tar*
 

AGENTS.md

@@ -0,0 +1,52 @@
+# Policy on AI Agents
+
+> [!IMPORTANT]
+> This project does **not** accept pull requests that are fully or
+> predominantly AI-generated. AI tools may be utilized solely to
+> assist individual development.
+>
+> If we receive an AI PR that _clearly has had zero testing_, then we
+> will **ban the person who submitted the PR**.
+>
+> Submitting a garbage PR isn't just AI slop, it's abuse.
+
+AI assistance is fine.  But when someone submits a PR, we assume that
+they understand the submission, and that they accept full
+responsibility for it.
+
+---
+
+## Recommendations for Using AI
+
+AI can be useful in some situations.  However, our experience has been
+that when people ask AI questions about FreeRADIUS, the answers are
+pretty bad.  The advice is either unclear, or is simply wrong.  This
+means that AI should be used to point you in a direction, but you
+should read the documentation to get the _truthful_ answers:
+
+> READ THE DOCS!
+>
+> https://www.freeradius.org/documentation/freeradius-server/
+
+AI can help in the following use cases:
+
+- Code completion in an editor,
+- Asking about the structure of the code,
+- Learning about specific techniques used in the project,
+- Finding documents, links, and parts of the code that are worth your time
+- Reviewing human-written code and providing suggestions on things you hadn't thought of,
+- Creating rough outlines for documentation,
+
+Anything AI generated _must_ be reviewed, edited, and approved by a person.
+
+## Disclosure
+
+**All AI contributions must be disclosed.**
+
+If you use AI in an editor for API suggestions, searching the code,
+etc., that doesn't need to be disclosed.  You are the person writing
+the code, not the AI.
+
+If you use AI to _generate_ code, it **must** be disclosed.  The code
+that AI generates is pretty much always wrong.  We need to know if the
+PR is AI slop, or if it has been reviewed and understood by a person.

CREDITS

@@ -20,20 +20,8 @@ mibdir		= @mibdir@
 logdir		= @logdir@
 includedir	= @includedir@
 
-#
-#  In some systems, we don't want to over-write ANY configuration.
-#  So we do:
-#
-#	$./configure
-#	$ make
-#	$ make -Draddbdir=/tmp/garbage install
-#
-#  and all of the configuration files go into /tmp/garbage
-#
-ifeq "${raddbdir}" ""
-raddbdir	= @raddbdir@
-endif
-modconfdir	= @modconfdir@
+confdir		= @confdir@
+modconfdir	= ${confdir}/mods-config
 radacctdir	= @radacctdir@
 top_builddir	= @abs_top_builddir@
 top_build_prefix=@abs_top_builddir@/
@@ -131,7 +119,7 @@ LIBS		= $(OPENSSL_LIBS) $(TALLOC_LIBS) $(KQUEUE_LIBS) @LIBS@
 LDFLAGS		= $(OPENSSL_LDFLAGS) $(TALLOC_LDFLAGS) $(KQUEUE_LDFLAGS) @LDFLAGS@
 
 LOGDIR		= ${logdir}
-RADDBDIR	= ${raddbdir}
+CONFDIR		= ${confdir}
 RUNDIR		= ${localstatedir}/run/radiusd
 SBINDIR		= ${sbindir}
 RADIR		= ${radacctdir}

Make.inc.in

@@ -241,7 +241,7 @@ install.man: $(subst man/,$(R)$(mandir)/,$(MANFILES))
 
 $(R)$(mandir)/%: man/%
 	@echo INSTALL $(notdir $<)
-	@sed -e "s,/etc/raddb,$(raddbdir),g" \
+	@sed -e "s,/etc/raddb,$(confdir),g" \
 		-e "s,/usr/local/share,$(datarootdir),g" \
 		$< > $<.subst
 	@$(INSTALL) -m 644 $<.subst $@
@@ -260,10 +260,10 @@ ifneq ($(RADMIN),)
   ifneq ($(RGROUP),)
 .PHONY: install-chown
 install-chown:
-	chown -R $(RADMIN)   $(R)$(raddbdir)
-	chgrp -R $(RGROUP)   $(R)$(raddbdir)
-	chmod u=rwx,g=rx,o=  `find $(R)$(raddbdir) -type d -print`
-	chmod u=rw,g=r,o=    `find $(R)$(raddbdir) -type f -print`
+	chown -R $(RADMIN)   $(R)$(confdir)
+	chgrp -R $(RGROUP)   $(R)$(confdir)
+	chmod u=rwx,g=rx,o=  `find $(R)$(confdir) -type d -print`
+	chmod u=rw,g=r,o=    `find $(R)$(confdir) -type f -print`
 	chown -R $(RADMIN)   $(R)$(logdir)
 	chgrp -R $(RGROUP)   $(R)$(logdir)
 	find $(R)$(logdir) -type d -exec chmod u=rwx,g=rwx,o= {} \;

Makefile

@@ -23,7 +23,7 @@ of people, in sites ranging from 10 to 10 million+ users.
 Please see the [documentation](doc/) directory, which has full
 documentation for version 4.
 
-Please also see <https://freeradius.org> and <https://wiki.freeradius.org>
+Please also see <https://freeradius.org> and <https://www.freeradius.org/documentation/freeradius-server/4.0.0/>
 for additional documentation.
 
 ## Installation
@@ -70,12 +70,8 @@ which includes WARNINGs about common issues, and suggestions for how
 they may be fixed.
 
 The debug output is explained in detail in the
-[radiusd-X](https://wiki.freeradius.org/radiusd-X) page on the
-[wiki](https://wiki.freeradius.org).
-
-Many questions are answered on the Wiki:
-
-<https://wiki.freeradius.org>
+[radiusd-X](https://www.freeradius.org/documentation/freeradius-server/4.0.0/debugging/radiusd_X.html)
+page.
 
 Read the configuration files.  Many parts of the server are
 documented only with extensive comments in the configuration files.
@@ -84,17 +80,21 @@ Search the mailing lists. For example, using Google, searching
 "site:lists.freeradius.org <search term>" will return results from
 the FreeRADIUS mailing lists.
 
-<https://freeradius.org/support/>
+[Additional
+help](https://www.freeradius.org/documentation/freeradius-server/4.0.0/gethelp.html)
+is available via the mailing lists, including commercial support.
+
+When posting to the mailing list, we recommend posting the output of
+`radiusd -X`.  That information shows what the server is doing when it
+receives packets, and how it processes those packets.
 
-Instructions for what to post on the mailing list are [on the
-wiki](https://wiki.freeradius.org/list-help).  Please note that we DO
-recommend posting the output of `radiusd -X`.  That information shows
-what the server is doing when it receives packets, and how it
-processes those packets.
+Do NOT post the configuration files to the mailing list.  They're not
+useful.  Instead, post the output of `radiusd -X`.  We really cannot
+emphasize that enough.
 
-We do NOT recommend posting the configuration files to the mailing
-list.  They don't help.  Instead, post the output of `radiusd -X`.  We
-really cannot emphasize that enough.
+DO post a clear description of what the problem is.  Empty questions
+will not make you friends.  e.g. "I changed things and now it doesn't
+work.  What do I do to fix it?"
 
 ## Feedback, Defects, and Community Support
 
@@ -114,8 +114,8 @@ mailing lists first to determine whether it really is a defect or
 missing feature.
 
 Instructions for gathering data for defect reports can be found in
-[here](doc/antora/modules/developers/pages/bugs.adoc) or on the
-[wiki](https://wiki.freeradius.org/project/bug-reports).
+[here](doc/antora/modules/developers/pages/bugs.adoc) and online at
+<https://www.freeradius.org/documentation/freeradius-server/4.0.0/developers/bugs.html>
 
 Under no circumstances should the issue tracker be used for support
 requests, those questions belong on the user's mailing list.  If you

README.md

@@ -678,10 +678,9 @@ ACLOCAL
 RUSERS
 SNMPWALK
 SNMPGET
-modconfdir
 mibdir
 dictdir
-raddbdir
+confdir
 radacctdir
 logdir
 openssl_version_check_config
@@ -6219,7 +6218,7 @@ fi
 { printf "%s\n" "$as_me:${as_lineno-$LINENO}: result: $radacctdir" >&5
 printf "%s\n" "$radacctdir" >&6; }
 
-raddbdir='${sysconfdir}/raddb'
+confdir='${sysconfdir}/raddb'
 { printf "%s\n" "$as_me:${as_lineno-$LINENO}: checking raddbdir" >&5
 printf %s "checking raddbdir... " >&6; }
 
@@ -6233,7 +6232,7 @@ then :
   yes)
     ;;
   [\\/$]* | ?:[\\/]* )
-    raddbdir="$withval"
+    confdir="$withval"
     ;;
   *)
     as_fn_error $? "expected an absolute directory name for --with-raddbdir: $withval" "$LINENO" 5
@@ -6243,8 +6242,8 @@ then :
 fi
 
 
-{ printf "%s\n" "$as_me:${as_lineno-$LINENO}: result: $raddbdir" >&5
-printf "%s\n" "$raddbdir" >&6; }
+{ printf "%s\n" "$as_me:${as_lineno-$LINENO}: result: $confdir" >&5
+printf "%s\n" "$confdir" >&6; }
 
 dictdir='${datarootdir}/freeradius/dictionary'
 { printf "%s\n" "$as_me:${as_lineno-$LINENO}: checking dictdir" >&5
@@ -6300,8 +6299,6 @@ fi
 { printf "%s\n" "$as_me:${as_lineno-$LINENO}: result: $mibdir" >&5
 printf "%s\n" "$mibdir" >&6; }
 
-modconfdir='${raddbdir}/mods-config'
-
 
 
 
@@ -16219,8 +16216,6 @@ fi
 
 ac_config_commands="$ac_config_commands stamp-h"
 
-ac_config_commands="$ac_config_commands build-radpaths-h"
-
 ac_config_commands="$ac_config_commands main-chmod"
 
 ac_config_commands="$ac_config_commands scripts-chmod"
@@ -16229,7 +16224,7 @@ ac_config_commands="$ac_config_commands scripts-chmod"
 
 
 
-ac_config_files="$ac_config_files ./Make.inc ./src/include/build-radpaths-h ./src/bin/checkrad ./src/bin/radtest ./scripts/rc.radiusd ./scripts/cron/radiusd.cron.daily ./scripts/cron/radiusd.cron.monthly ./scripts/util/cryptpasswd ./raddb/radrelay.conf ./raddb/radiusd.conf"
+ac_config_files="$ac_config_files ./Make.inc ./src/bin/checkrad ./src/bin/radtest ./scripts/rc.radiusd ./scripts/cron/radiusd.cron.daily ./scripts/cron/radiusd.cron.monthly ./scripts/util/cryptpasswd ./raddb/radrelay.conf ./raddb/radiusd.conf"
 
 cat >confcache <<\_ACEOF
 # This file is a shell script that caches the results of configure
@@ -16932,11 +16927,9 @@ do
   case $ac_config_target in
     "src/include/autoconf.h") CONFIG_HEADERS="$CONFIG_HEADERS src/include/autoconf.h" ;;
     "stamp-h") CONFIG_COMMANDS="$CONFIG_COMMANDS stamp-h" ;;
-    "build-radpaths-h") CONFIG_COMMANDS="$CONFIG_COMMANDS build-radpaths-h" ;;
     "main-chmod") CONFIG_COMMANDS="$CONFIG_COMMANDS main-chmod" ;;
     "scripts-chmod") CONFIG_COMMANDS="$CONFIG_COMMANDS scripts-chmod" ;;
     "./Make.inc") CONFIG_FILES="$CONFIG_FILES ./Make.inc" ;;
-    "./src/include/build-radpaths-h") CONFIG_FILES="$CONFIG_FILES ./src/include/build-radpaths-h" ;;
     "./src/bin/checkrad") CONFIG_FILES="$CONFIG_FILES ./src/bin/checkrad" ;;
     "./src/bin/radtest") CONFIG_FILES="$CONFIG_FILES ./src/bin/radtest" ;;
     "./scripts/rc.radiusd") CONFIG_FILES="$CONFIG_FILES ./scripts/rc.radiusd" ;;
@@ -17496,7 +17489,6 @@ printf "%s\n" "$as_me: executing $ac_file commands" >&6;}
 
   case $ac_file$ac_mode in
     "stamp-h":C) echo timestamp > src/include/stamp-h ;;
-    "build-radpaths-h":C) (cd ./src/include && /bin/sh ./build-radpaths-h) ;;
     "main-chmod":C) (cd ./src/bin && chmod +x checkrad radtest) ;;
     "scripts-chmod":C) (cd ./scripts && chmod +x rc.radiusd cron/radiusd.cron.daily cron/radiusd.cron.monthly util/cryptpasswd) ;;
 

configure

@@ -740,7 +740,7 @@ AC_MSG_RESULT($radacctdir)
 dnl #
 dnl #  extra argument: --with-raddbdir
 dnl #
-raddbdir='${sysconfdir}/raddb'
+confdir='${sysconfdir}/raddb'
 AC_MSG_CHECKING(raddbdir)
 AC_ARG_WITH(raddbdir,
 [  --with-raddbdir=DIR     directory for config files [SYSCONFDIR/raddb] ],
@@ -751,15 +751,15 @@ AC_ARG_WITH(raddbdir,
   yes)
     ;;
   [[\\/$]]* | ?:[[\\/]]* )
-    raddbdir="$withval"
+    confdir="$withval"
     ;;
   *)
     AC_MSG_ERROR([expected an absolute directory name for --with-raddbdir: $withval])
     ;;
   esac ]
 )
-AC_SUBST(raddbdir)
-AC_MSG_RESULT($raddbdir)
+AC_SUBST(confdir)
+AC_MSG_RESULT($confdir)
 
 dnl #
 dnl #  extra argument: --with-dictdir
@@ -809,9 +809,6 @@ AC_ARG_WITH(mibdir,
 AC_SUBST(mibdir)
 AC_MSG_RESULT($mibdir)
 
-modconfdir='${raddbdir}/mods-config'
-AC_SUBST(modconfdir)
-
 dnl #############################################################
 dnl #
 dnl #  0e. Library/include paths
@@ -2625,7 +2622,6 @@ dnl #  And finally, output the results.
 dnl #
 dnl #############################################################
 AC_CONFIG_COMMANDS([stamp-h], [echo timestamp > src/include/stamp-h])
-AC_CONFIG_COMMANDS([build-radpaths-h], [(cd ./src/include && /bin/sh ./build-radpaths-h)])
 AC_CONFIG_COMMANDS([main-chmod], [(cd ./src/bin && chmod +x checkrad radtest)])
 AC_CONFIG_COMMANDS([scripts-chmod], [(cd ./scripts && chmod +x rc.radiusd cron/radiusd.cron.daily cron/radiusd.cron.monthly util/cryptpasswd)])
 
@@ -2637,7 +2633,6 @@ AC_SUBST(INSTALLSTRIP)
 
 AC_CONFIG_FILES([\
   ./Make.inc \
-  ./src/include/build-radpaths-h \
   ./src/bin/checkrad \
   ./src/bin/radtest \
   ./scripts/rc.radiusd \