[CONJS-343] batch hangs when having an empty parameters values #343

Author: rusher

lib/connection.js

@@ -193,6 +193,11 @@ class Connection extends EventEmitter {
       return this.handleMissingValuesError(cmdParam, reject);
     }
 
+    // no parameters
+    if ((Array.isArray(cmdParam.values) && cmdParam.values.length === 0)) {
+      resolve();
+    }
+
     // Execute the batch operation
     this.prepare(
       cmdParam,

test/integration/batch.test.js

@@ -1571,6 +1571,17 @@ describe.sequential(
         }
       });
 
+      test('batch with empty array values #343', async ({ skip }) => {
+        if (!shareConn.info.isMariaDB() && !shareConn.info.hasMinVersion(5, 6, 0)) return skip();
+
+        const conn = await createConnection({ bulk: true });
+        await conn.query('CREATE TEMPORARY TABLE empty_array_value(id int not null primary key auto_increment, id2 int)');
+        await conn.batch('INSERT INTO `empty_array_value`(id2) values (?)', []);
+        const res = await conn.query('select * from `empty_array_value`');
+        assert.deepEqual(res, []);
+        await conn.end();
+      });
+
       test('batch with erroneous parameter', async ({ skip }) => {
         if (!shareConn.info.isMariaDB() && !shareConn.info.hasMinVersion(5, 6, 0)) return skip();
 
@@ -1750,6 +1761,19 @@ describe.sequential(
           }
         });
 
+        test('batch with empty array values #343', async ({ skip }) => {
+          if (!shareConn.info.isMariaDB() && !shareConn.info.hasMinVersion(5, 6, 0)) return skip();
+
+          const conn = await createConnection({ bulk: false });
+          await conn.query(
+            'CREATE TEMPORARY TABLE empty_array_value(id int not null primary key auto_increment, id2 int)'
+          );
+          await conn.batch('INSERT INTO `empty_array_value`(id2) values (?)', []);
+          const res = await conn.query('select * from `empty_array_value`');
+          assert.deepEqual(res, []);
+          await conn.end();
+        });
+
         test('rewrite split for maxAllowedPacket', async ({ skip }) => {
           const t = makeid(100);
           const conn = await createConnection({ bulk: false, maxAllowedPacket: 150 });

test/integration/file.test.js

@@ -18,7 +18,7 @@ describe('sql file import', () => {
     maxAllowedSize = Number(row[0].t);
   });
   afterAll(async () => {
-    await shareConn.end();
+    if (shareConn) await shareConn.end();
     shareConn = null;
   });