Skip to content
This repository was archived by the owner on Apr 16, 2026. It is now read-only.

Add gutter filler#1493

Closed
redmunds wants to merge 1 commit intocodemirror:masterfrom
adobe:randy/gutter-scrollbar-filler
Closed

Add gutter filler#1493
redmunds wants to merge 1 commit intocodemirror:masterfrom
adobe:randy/gutter-scrollbar-filler

Conversation

@redmunds
Copy link
Copy Markdown
Contributor

@redmunds redmunds commented May 3, 2013

This is for issue #1485.

I added a new parameter to updateScrollbars(), but it seems like just passing cm to that function is a littler cleaner, so let me know if I should change it.

I didn't make it an option because I don't know why anyone would not want it this way. Let me know if you still want it as an option.

marijnh added a commit that referenced this pull request May 4, 2013
@marijnh
Copy link
Copy Markdown
Member

marijnh commented May 4, 2013

Thanks. Merged. Indeed, if we're going to pass three fields from cm to updateScrollbars, we might as well pass the whole editor.

I also prefer the look of the editor without this, so I made it an option that defaults to off. See attached patch. Set coverGutterNextToScrollbar to true to turn it back on.

@marijnh marijnh closed this May 4, 2013
@redmunds redmunds deleted the randy/gutter-scrollbar-filler branch November 5, 2013 20:16
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants