This repository was archived by the owner on Apr 16, 2026. It is now read-only.
[vim] Make vim dialog work correctly#1509
Closed
njx wants to merge 1 commit intocodemirror:masterfrom
adobe:vim-dialog-fix
Closed
[vim] Make vim dialog work correctly#1509njx wants to merge 1 commit intocodemirror:masterfrom adobe:vim-dialog-fix
njx wants to merge 1 commit intocodemirror:masterfrom
adobe:vim-dialog-fix
Conversation
Contributor
|
You are right, my bad. Thanks for the fix. |
Member
|
Thank you. Merged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, running a vim command like
:wdoesn't work--it throws an exception when closing the dialog because it tries to callcallback, which doesn't exist. If I'm understanding the code correctly, it should callonCloseinstead.(It looks like this code has been in there for a long time, so I'm not sure why this hasn't caused a problem before--maybe no one is using the default implementation of
openDialog().)