Merge pull request galaxyproject#20755 from jmchilton/client_unit_test_output_2

More client unit test clean up.

Author: mvdbeek

client/src/components/DatasetInformation/DatasetError.test.ts

@@ -2,7 +2,7 @@ import { getFakeRegisteredUser } from "@tests/test-data";
 import { mount } from "@vue/test-utils";
 import flushPromises from "flush-promises";
 import { createPinia } from "pinia";
-import { getLocalVue } from "tests/jest/helpers";
+import { expectConfigurationRequest, getLocalVue } from "tests/jest/helpers";
 
 import { HttpResponse, useServerMock } from "@/api/client/__mocks__";
 import type { components } from "@/api/schema";
@@ -38,6 +38,7 @@ async function montDatasetError(has_duplicate_inputs = true, has_empty_inputs =
     };
 
     server.use(
+        expectConfigurationRequest(http, {}),
         http.get("/api/datasets/{dataset_id}", ({ response }) => {
             // We need to use untyped here because this endpoint is not
             // described in the OpenAPI spec due to its complexity for now.

client/src/components/DatasetInformation/DatasetInformation.test.ts

@@ -1,3 +1,4 @@
+import { createTestingPinia } from "@pinia/testing";
 import { getLocalVue } from "@tests/jest/helpers";
 import { mount, type Wrapper } from "@vue/test-utils";
 import axios from "axios";
@@ -53,11 +54,14 @@ describe("DatasetInformation/DatasetInformation", () => {
         axiosMock = new MockAdapter(axios);
         axiosMock.onGet(new RegExp(`api/configuration/decode/*`)).reply(200, { decoded_id: 123 });
 
+        const pinia = createTestingPinia();
+
         wrapper = mount(DatasetInformation as object, {
             propsData: {
                 dataset: datasetResponse,
             },
             localVue,
+            pinia,
         });
 
         datasetInfoTable = wrapper.find("#dataset-details");

client/src/components/Form/Elements/FormData/FormData.vue

@@ -60,7 +60,7 @@ const props = withDefaults(
         tag?: string;
         userDefinedTitle?: string;
         workflowRun?: boolean;
-        extendedCollectionType: ExtendedCollectionType;
+        extendedCollectionType?: ExtendedCollectionType;
     }>(),
     {
         loading: false,

client/src/components/Form/Elements/FormSelect.test.js

@@ -1,3 +1,5 @@
+import "@/composables/__mocks__/filter";
+
 import { createTestingPinia } from "@pinia/testing";
 import { mount } from "@vue/test-utils";
 import { getLocalVue } from "tests/jest/helpers";

client/src/components/Panels/ToolPanel.vue

@@ -92,7 +92,10 @@ async function initializePanel() {
         await toolStore.fetchTools();
         await toolStore.initializePanel();
     } catch (error) {
-        console.error(`ToolPanel::initializePanel - ${error}`);
+        if (process.env.NODE_ENV != "test") {
+            console.error(`ToolPanel::initializePanel - ${error}`);
+        }
+
         errorMessage.value = errorMessageAsString(error);
     } finally {
         panelsFetched.value = true;

client/src/components/Tool/ToolForm.vue

@@ -306,7 +306,7 @@ export default {
             this.currentVersion = newVersion || this.currentVersion;
             this.disabled = true;
             this.loading = true;
-            console.debug("ToolForm - Requesting tool.", this.id);
+
             return getToolFormData(this.id, this.currentVersion, this.job_id, this.history_id)
                 .then((data) => {
                     this.currentVersion = data.version;

client/src/utils/simple-error.ts

@@ -19,6 +19,8 @@ export function errorMessageAsString(e: any, defaultMessage = "Request failed.")
 }
 
 export function rethrowSimple(e: any): never {
-    console.debug(e);
+    if (process.env.NODE_ENV != "test") {
+        console.debug(e);
+    }
     throw Error(errorMessageAsString(e));
 }