be more lenient with doi detection

the specs aren't very strict and especially the resolver does not have to be doi.org at all

https://www.doi.org/resources/DOICoreSpecificationv1.pdf

Author: martenson

lib/galaxy/util/__init__.py

@@ -2029,8 +2029,5 @@ def to_content_disposition(target: str) -> str:
 def validate_doi(doi: str) -> bool:
     if len(doi) > DOI_MAX_LENGTH:
         return False
-    prefix = "https://doi.org/|doi.org/|doi:"
-    doi_prefix = r"10\.\d+"
-    doi_suffix = r"\S+"
-    doi_re = re.compile(f"^{prefix}{doi_prefix}/{doi_suffix}$")
-    return bool(doi_re.match(doi))
+    doi_re = re.compile(r"(10\.(\d)+\/(.+))")
+    return bool(doi_re.search(doi))

test/unit/util/test_utils.py

@@ -149,6 +149,13 @@ class Stuff(str, Enum):
     "doi:10.1234567890/42",  # longer prefix
     "doi:10.1234/42ab:%&*$//crazy-suffix/%/&/",
     "doi:10.1234/aa",
+    "http://doi.org/10.1234/42",
+    "stillvalid:10.1234/42",
+    "dx.doi.org:10.1234/42",
+    "https://dx.doi.org:10.1234/42",
+    "doi:10.1234/42/a b",
+    "httpss://dx.doi.org:10.1234/42",
+    "doi:10.1234/ 42",
 ]
 
 
@@ -158,14 +165,11 @@ def test_validate_doi_pass(input):
 
 
 DOI_INVALID_VALUES = [
-    "http://doi.org/10.1234/42",
-    "invalid:10.1234/42",
     "doi:11.1234/42",
     "doi:101234/42",
     "doi:10. 1234/42",
     "doi:10.abc/42",
-    "doi:10.1234/ 42",
-    "doi:10.1234/42/a b",
+    "10.1234 /42/a b",
 ]