Skip to content

Commit fda437a

Browse files
ClearlyClaireGargron
authored andcommitted
Fix sanitizing lists contents (#11354)
* Add test * Fix code for sanitizing nested lists stripping all tags
1 parent 730c405 commit fda437a

2 files changed

Lines changed: 6 additions & 0 deletions

File tree

app/lib/sanitize_config.rb

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -25,6 +25,8 @@ module Config
2525
case env[:node_name]
2626
when 'li'
2727
env[:node].traverse do |node|
28+
next unless %w(p ul ol li).include?(node.name)
29+
2830
node.add_next_sibling('<br>') if node.next_sibling
2931
node.replace(node.children) unless node.text?
3032
end

spec/lib/sanitize_config_spec.rb

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -22,5 +22,9 @@
2222
it 'converts ul inside ul' do
2323
expect(Sanitize.fragment('<ul><li>Foo</li><li><ul><li>Bar</li><li>Baz</li></ul></li></ul>', subject)).to eq '<p>Foo<br>Bar<br>Baz</p>'
2424
end
25+
26+
it 'keep links in lists' do
27+
expect(Sanitize.fragment('<p>Check out:</p><ul><li><a href="https://joinmastodon.org" rel="nofollow noopener" target="_blank">joinmastodon.org</a></li><li>Bar</li></ul>', subject)).to eq '<p>Check out:</p><p><a href="https://joinmastodon.org" rel="nofollow noopener" target="_blank">joinmastodon.org</a><br>Bar</p>'
28+
end
2529
end
2630
end

0 commit comments

Comments
 (0)