do not double count acquired visits

Author: sgiehl

plugins/BotTracking/RecordBuilders/AIAssistantReports.php

@@ -183,8 +183,8 @@ private function populateTableForActionType(array $tables, int $actionType, LogA
             ];
 
             // we add all records to both tables, so we in the end have the total count of pages & documents in the main table
-            $tables[Archiver::AI_ASSISTANTS_PAGES_RECORD]->sumRowWithLabel($label, $metrics);
-            $tables[Archiver::AI_ASSISTANTS_DOCUMENTS_RECORD]->sumRowWithLabel($label, $metrics);
+            $tables[Archiver::AI_ASSISTANTS_PAGES_RECORD]->sumRowWithLabel($label, $metrics, [Metrics::COLUMN_ACQUIRED_VISITS => 'max']);
+            $tables[Archiver::AI_ASSISTANTS_DOCUMENTS_RECORD]->sumRowWithLabel($label, $metrics, [Metrics::COLUMN_ACQUIRED_VISITS => 'max']);
         }
 
         $table = $tables[Archiver::AI_ASSISTANTS_PAGES_RECORD];

plugins/BotTracking/tests/Fixtures/BotTraffic.php

@@ -75,6 +75,7 @@ private function trackBotRequests(): void
                 ['MistralAI-User/2.0', $pages[2], 200, 32485, false],
                 ['Claude-User/3.0', $downloads[2], 200, 123456, true],
                 ['ChatGPT-User/1.0', $pages[1], 500, 25896, false],
+                ['ChatGPT-User/1.0', $downloads[1], 200, 33658, true],
                 ['Perplexity-User/1.0', $pages[2], 200, 36985, false],
                 ['MistralAI-User/2.0', $pages[3], 200, 85236, false],
                 ['Claude-User/3.0', $downloads[3], 200, 12456, true],

plugins/BotTracking/tests/System/expected/test__documents__BotTracking.getAIAssistantRequests_day.xml

@@ -2,10 +2,16 @@
 <result>
 	<row>
 		<label>ChatGPT-User</label>
-		<requests>1</requests>
-		<document_requests>0</document_requests>
+		<requests>2</requests>
+		<document_requests>1</document_requests>
 		<page_requests>1</page_requests>
 		<visits_acquired>1</visits_acquired>
+		<subtable>
+			<row>
+				<label>example.com/resources/guide.pdf</label>
+				<requests>1</requests>
+			</row>
+		</subtable>
 	</row>
 	<row>
 		<label>Perplexity-User</label>

plugins/BotTracking/tests/System/expected/test__documents__BotTracking.getAIAssistantRequests_week.xml

@@ -48,10 +48,16 @@
 	</row>
 	<row>
 		<label>ChatGPT-User</label>
-		<requests>4</requests>
-		<document_requests>0</document_requests>
+		<requests>5</requests>
+		<document_requests>1</document_requests>
 		<page_requests>4</page_requests>
 		<visits_acquired>1</visits_acquired>
+		<subtable>
+			<row>
+				<label>example.com/resources/guide.pdf</label>
+				<requests>1</requests>
+			</row>
+		</subtable>
 	</row>
 	<row>
 		<label>Gemini-Deep-Research</label>

plugins/BotTracking/tests/System/expected/test__pages__BotTracking.getAIAssistantRequests_day.xml

@@ -2,8 +2,8 @@
 <result>
 	<row>
 		<label>ChatGPT-User</label>
-		<requests>1</requests>
-		<document_requests>0</document_requests>
+		<requests>2</requests>
+		<document_requests>1</document_requests>
 		<page_requests>1</page_requests>
 		<visits_acquired>1</visits_acquired>
 		<subtable>

plugins/BotTracking/tests/System/expected/test__pages__BotTracking.getAIAssistantRequests_week.xml

@@ -32,8 +32,8 @@
 	</row>
 	<row>
 		<label>ChatGPT-User</label>
-		<requests>4</requests>
-		<document_requests>0</document_requests>
+		<requests>5</requests>
+		<document_requests>1</document_requests>
 		<page_requests>4</page_requests>
 		<visits_acquired>1</visits_acquired>
 		<subtable>