Dark mode no data page is bright white (#24415)

chippison · web-flow · commit 056b37e298b2 · 2026-04-23T17:13:32.000+12:00
* replaced hard coded colors to use theme specific ones

* updating screenshots
diff --git a/plugins/BotTracking/stylesheets/BotTracking.less b/plugins/BotTracking/stylesheets/BotTracking.less
@@ -12,10 +12,10 @@
 }
 
 #bot-tracking-site-without-data {
-  background: @color-white;
+  background: @theme-color-background-base;
 
   .top_controls {
-    background: @color-white;
+    background: @theme-color-background-base;
 
     .quick-access {
       display: none;
diff --git a/plugins/BotTracking/tests/UI/expected-screenshots/BotTrackingSiteWithoutData_siteWithoutData.png b/plugins/BotTracking/tests/UI/expected-screenshots/BotTrackingSiteWithoutData_siteWithoutData.png
@@ -1,3 +1,3 @@
 version https://git-lfs.github.com/spec/v1
-oid sha256:e77c3177e4c768b268fa1b26136a118dbde6ec1ce9b40ca85aebc7d3a2e107b2
-size 104664
+oid sha256:af8f674d77056cbb4e91c020bb4a6488bdced880f1d94039cc2c4694fb675081
+size 107044
diff --git a/plugins/SitesManager/images/mtm.png b/plugins/SitesManager/images/mtm.png
diff --git a/plugins/SitesManager/stylesheets/SitesManager.less b/plugins/SitesManager/stylesheets/SitesManager.less
@@ -134,10 +134,10 @@ td.editable-site-field:hover {
 }
 
 #site-without-data {
-    background: @color-white;
+    background: @theme-color-background-base;
 
     .top_controls {
-        background: @color-white;
+        background: @theme-color-background-base;
 
         .quick-access {
             display: none;
@@ -174,7 +174,7 @@ td.editable-site-field:hover {
         float: right;
 
         > a, > span > a {
-            color: @color-silver-dark;
+            color: @theme-color-text-light;
             font-size: 14px;
             font-weight: 500;
             line-height: 24px;
diff --git a/plugins/TagManager b/plugins/TagManager
@@ -1 +1 @@
-Subproject commit 2875c8a1bae338ba03d65f84dcea04aedbe4f4f1
+Subproject commit 79b08a24756ccec2a6a39c48ef25f1d59dd0839a
diff --git a/tests/UI/expected-screenshots/EmptySite_detected_gtm.png b/tests/UI/expected-screenshots/EmptySite_detected_gtm.png
@@ -1,3 +1,3 @@
 version https://git-lfs.github.com/spec/v1
-oid sha256:dd11af52b717cf1c159b1c6de1cb7f394c3ead163bcdcb62cca870e5bea64b6e
-size 29757
+oid sha256:fa072de6c85476f17ac67d506d6eef0194dcfc63ded235e1bb7d5864acb550ba
+size 30427
diff --git a/tests/UI/expected-screenshots/EmptySite_detected_osano.png b/tests/UI/expected-screenshots/EmptySite_detected_osano.png
@@ -1,3 +1,3 @@
 version https://git-lfs.github.com/spec/v1
-oid sha256:455b64a511259c341cbf8c5870bb43fa602d4537fed4e4432d85e89dd89caa4d
-size 128590
+oid sha256:401a2d7f5da36f9083e43bfed660406de1e077461b5bfae49b87f8d8055fc4e9
+size 130380
diff --git a/tests/UI/expected-screenshots/EmptySite_detected_wordpress.png b/tests/UI/expected-screenshots/EmptySite_detected_wordpress.png
@@ -1,3 +1,3 @@
 version https://git-lfs.github.com/spec/v1
-oid sha256:8556c44aa8cb7c8b55177a05c06b467f78864ce1df57029f54dfc09e1c304c17
-size 101241
+oid sha256:8c26513d812986f8f3084c7bae210beccaee18b248b297ac46413a0a8ad79708
+size 104491
diff --git a/tests/UI/expected-screenshots/EmptySite_emptySiteDashboard.png b/tests/UI/expected-screenshots/EmptySite_emptySiteDashboard.png
@@ -1,3 +1,3 @@
 version https://git-lfs.github.com/spec/v1
-oid sha256:4d4365d87fc3963404c094c4504d305f5e000b6ccf624afe30e427eae40b698f
-size 97512
+oid sha256:2de9af5735f5198b0a7e5f42c403ddef653d679dc88d7635d7deb1f2bf0e1e22
+size 101095
diff --git a/tests/UI/expected-screenshots/EmptySite_gtm.png b/tests/UI/expected-screenshots/EmptySite_gtm.png
@@ -1,3 +1,3 @@
 version https://git-lfs.github.com/spec/v1
-oid sha256:b42fbeb7473a7dc9af053890760e722abde5ee64822b266f3e25eb7d8e9157b8
-size 167040
+oid sha256:81dae5fee944710e026a049085a8a248dc38fad4943e4033437e55a063fd080e
+size 170396
diff --git a/tests/UI/expected-screenshots/EmptySite_integrations.png b/tests/UI/expected-screenshots/EmptySite_integrations.png
@@ -1,3 +1,3 @@
 version https://git-lfs.github.com/spec/v1
-oid sha256:61f0c060fbe689aa8ef94b6d9c24fa426fc3ac40ee4a29137048270640824183
-size 92203
+oid sha256:36c8d35c44f562ac6482d607e82d11cf575a58961ef389e3cc7d4b68a2f11bf7
+size 93517
diff --git a/tests/UI/expected-screenshots/EmptySite_other.png b/tests/UI/expected-screenshots/EmptySite_other.png
@@ -1,3 +1,3 @@
 version https://git-lfs.github.com/spec/v1
-oid sha256:87ef3f3b652916b161a8b1cc8e3640a84c067a3470c7347033661f44bfd99efa
-size 195737
+oid sha256:ec4e519270072749729c74e0b7db322598b9ea3c940a5aab02ec25ba24360ae3
+size 199108
diff --git a/tests/UI/expected-screenshots/EmptySite_showAdvancedTrackingOptions.png b/tests/UI/expected-screenshots/EmptySite_showAdvancedTrackingOptions.png
@@ -1,3 +1,3 @@
 version https://git-lfs.github.com/spec/v1
-oid sha256:9e06be71787b5d7504575b94ec6ba166a4137a2c43288aaa6abb78fca3e8f5c1
-size 317272
+oid sha256:5bc68587c71a85f0833cbb514b9f04261db5e7853561d86ee1f915ef2235b4b7
+size 319735
diff --git a/tests/UI/expected-screenshots/EmptySite_spa_pwa.png b/tests/UI/expected-screenshots/EmptySite_spa_pwa.png
@@ -1,3 +1,3 @@
 version https://git-lfs.github.com/spec/v1
-oid sha256:533b147fc1246d379fc90e5bfdf96f9293543f126944ac0a25ea457c25205a51
-size 256176
+oid sha256:21e0dc4dfd6865e115085f1a67168fd1baeb4e1b52a69d87ea89529cf77d0bda
+size 261561
diff --git a/tests/UI/expected-screenshots/EmptySite_trackingCode.png b/tests/UI/expected-screenshots/EmptySite_trackingCode.png
@@ -1,3 +1,3 @@
 version https://git-lfs.github.com/spec/v1
-oid sha256:f66e067cfe2b8d0581cc9dfb1c8677c264ef0a823d2c5b46fa7b0e904846cac7
-size 109171
+oid sha256:8644a39604cd579cc73097be8d0627c7fb3e16a320b1f9c84de7f0c547055ef0
+size 111191
diff --git a/tests/UI/expected-screenshots/EmptySite_vuejs.png b/tests/UI/expected-screenshots/EmptySite_vuejs.png
@@ -1,3 +1,3 @@
 version https://git-lfs.github.com/spec/v1
-oid sha256:bff9c5fd49afc95d18ea6add37c5522ecdf4c6ff8540aeca74ea80163ca1a272
-size 167068
+oid sha256:e2ed1547ffb555f19baf94cc6c50ea496748de7e9d7cb4cdb1cbc267f5d761f9
+size 169263
diff --git a/tests/UI/expected-screenshots/EmptySite_wordpress.png b/tests/UI/expected-screenshots/EmptySite_wordpress.png
@@ -1,3 +1,3 @@
 version https://git-lfs.github.com/spec/v1
-oid sha256:4f37c670dba90ddc8035b2497d2c314f14bea62cdcdb95ca79080b5a8b25a889
-size 203174
+oid sha256:a72fce613e3673a51ffe7179c380c1abdfe7079cb384de5363624fb223b885ec
+size 208082
