Send response code 400 when requesting a non existing method (#22334)

* fixed 200 OK BUG

* regex for error message matching

* throwing an instace of HttpCodeException

* Update core/Http/BadRequestException.php

Co-authored-by: Michal Kleiner <mk@011.nz>

* Update core/API/Proxy.php

Co-authored-by: Michal Kleiner <mk@011.nz>

* Apply suggestions from code review

---------

Co-authored-by: Michal Kleiner <mk@011.nz>
Co-authored-by: Stefan Giehl <stefan@matomo.org>

Author: 3 people

core/API/Proxy.php

@@ -10,6 +10,7 @@
 namespace Piwik\API;
 
 use Exception;
+use Piwik\Http\BadRequestException;
 use Piwik\Common;
 use Piwik\Container\StaticContainer;
 use Piwik\Context;
@@ -615,7 +616,7 @@ private function loadMethodMetadata($class, $method)
     private function checkMethodExists($className, $methodName)
     {
         if (!$this->isMethodAvailable($className, $methodName)) {
-            throw new Exception(Piwik::translate('General_ExceptionMethodNotFound', array($methodName, $className)));
+            throw new BadRequestException(Piwik::translate('General_ExceptionMethodNotFound', [$methodName, $className]));
         }
     }
 

core/Http/BadRequestException.php

@@ -13,6 +13,6 @@ class BadRequestException extends \Exception implements HttpCodeException
 {
     public function __construct($message, $code = 400)
     {
-        parent::__construct($message);
+        parent::__construct($message, $code);
     }
 }