Skip to content

Commit a49428c

Browse files
committed
Redesign real-time segment notice after team feedback
1 parent c83b5a1 commit a49428c

3 files changed

Lines changed: 12 additions & 9 deletions

File tree

plugins/SegmentEditor/Controller.php

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -167,6 +167,8 @@ private function getTranslations(): array
167167
'SegmentEditor_SparklineTooltipWeeks',
168168
'SegmentEditor_SparklineTooltipMonths',
169169
'SegmentEditor_SparklineTooltipYears',
170+
'SegmentEditor_ManageSegmentsRealtimeNotice',
171+
'SegmentEditor_ManageSegmentsRealtimeNoDataTooltip',
170172
'General_Segment',
171173
'General_SegmentDocumentation',
172174
'General_ColumnEvolutionVisits',

plugins/SegmentEditor/lang/en.json

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,8 @@
44
"AddANDorORCondition": "Add %s condition",
55
"AddNewSegment": "Create new segment",
66
"ManageSegments": "Manage Segments",
7-
"ManageSegmentsRealtimeNotice": "Some segments are processed in real time and their data is not displayed here, as this page only lists pre-processed segments.",
7+
"ManageSegmentsRealtimeNotice": "Some segments in the table are processed in real time, so their data will not be displayed.",
8+
"ManageSegmentsRealtimeNoDataTooltip": "This segment is processed in real time, so no data will be displayed.",
89
"SegmentPageTitle": "Segments overview",
910
"SegmentPageDescription": "View and manage your segments while monitoring their impact on traffic and behaviour. This table shows visits, actions, and trends over time, with quick links to view, edit, or delete each segment.",
1011
"SeeDashboardForThisSegment": "View dashboard for this segment.",

plugins/SegmentEditor/templates/manageSegments.twig

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1,13 +1,13 @@
1+
{% if hasRealtimeSegments %}
2+
<div class="alert alert-info">
3+
{{ 'SegmentEditor_ManageSegmentsRealtimeNotice'|translate }}
4+
</div>
5+
{% endif %}
16
<div class="card" data-page="manage-segments">
27
<div class="card-content">
38
<h2 class="card-title">{{ 'SegmentEditor_SegmentPageTitle'|translate }}</h2>
49
<div>
510
<p class="card-introduction">{{ 'SegmentEditor_SegmentPageDescription'|translate }}</p>
6-
{% if hasRealtimeSegments %}
7-
<div class="alert alert-info">
8-
{{ 'SegmentEditor_ManageSegmentsRealtimeNotice'|translate }}
9-
</div>
10-
{% endif %}
1111
<form name="manageSegmentSearchFilter">
1212
<div class="form-group row matomo-form-field" style="">
1313
<div class="col s12 input-field m6">
@@ -55,21 +55,21 @@
5555
<td title="{{ segment.name }}">{{ segment.name|rawSafeDecoded }}</td>
5656
<td class="entityTable_Numeric">
5757
{% if segment.isRealtime %}
58-
~
58+
<span title="{{ 'SegmentEditor_ManageSegmentsRealtimeNoDataTooltip'|translate }}">-</span>
5959
{% else %}
6060
{{ segmentData[loop.index0].nb_visits }}
6161
{% endif %}
6262
</td>
6363
<td class="entityTable_Numeric">
6464
{% if segment.isRealtime %}
65-
~
65+
<span title="{{ 'SegmentEditor_ManageSegmentsRealtimeNoDataTooltip'|translate }}">-</span>
6666
{% else %}
6767
{{ segmentData[loop.index0].nb_actions }}
6868
{% endif %}
6969
</td>
7070
<td class="entityTable_Numeric">
7171
{% if segment.isRealtime %}
72-
~
72+
<span title="{{ 'SegmentEditor_ManageSegmentsRealtimeNoDataTooltip'|translate }}">-</span>
7373
{% else %}
7474
<span title="{{ 'General_ColumnEvolutionVisitsDocumentation'|translate }}" class="sparklineEvolution sparklineEvolution-{{ segmentData[loop.index0].evolution_visits_direction }}">
7575
<img src="{{ segmentData[loop.index0].evolution_visits_icon }}" alt="" class="sparklineEvolution_icon" />

0 commit comments

Comments
 (0)