Skip to content

Commit ac27f6d

Browse files
committed
Use generic table tooltip instead of custom ones
1 parent 523528e commit ac27f6d

4 files changed

Lines changed: 14 additions & 15 deletions

File tree

lang/en.json

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -75,6 +75,7 @@
7575
"ColumnEntrances": "Entrances",
7676
"ColumnEntrancesDocumentation": "Number of visits that started on this page.",
7777
"ColumnEvolutionVisits": "Evolution Visits",
78+
"ColumnEvolutionVisitsDocumentation": "The percentage change of visits compared to the previous period. A positive value indicates growth, while a negative value signals a decrease.",
7879
"ColumnExitRate": "Exit rate",
7980
"ColumnExitRateDocumentation": "The percentage of visits that left the website after viewing this page.",
8081
"ColumnExits": "Exits",
@@ -100,6 +101,8 @@
100101
"ColumnPercentageVisits": "%% Visits",
101102
"ColumnPercentageVisitsDocumentation": "The percentage of total visits.",
102103
"ColumnRevenue": "Revenue",
104+
"ColumnSegment": "Segment",
105+
"ColumnSegmentDocumentation": "A segment is a set of criteria used to select only a part of the entire set of visits.",
103106
"ColumnSumTimeOnSite": "Total Time on Website",
104107
"ColumnSumVisitLength": "Total time spent by visitors (in seconds)",
105108
"ColumnTotalPageviews": "Total Pageviews",

plugins/SegmentEditor/Controller.php

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -144,21 +144,21 @@ private function getTranslations(): array
144144
$translationKeys = array(
145145
'SegmentEditor_AddNewSegment',
146146
'SegmentEditor_ManageSegments',
147-
'SegmentEditor_MetricDocumentationSegment',
148-
'SegmentEditor_MetricDocumentationVisits',
149-
'SegmentEditor_MetricDocumentationActions',
150147
'SegmentEditor_SegmentPageTitle',
151148
'SegmentEditor_SegmentPageDescription',
152149
'SegmentEditor_SeeDashboardForThisSegment',
153150
'SegmentEditor_SparklineTooltipDays',
154151
'SegmentEditor_SparklineTooltipWeeks',
155152
'SegmentEditor_SparklineTooltipMonths',
156153
'SegmentEditor_SparklineTooltipYears',
157-
'SegmentEditor_SparklineEvolutionTooltip',
158-
'General_Name',
154+
'General_Segment',
155+
'General_SegmentDocumentation',
159156
'General_ColumnEvolutionVisits',
157+
'General_ColumnEvolutionVisitsDocumentation',
160158
'General_ColumnNbVisits',
159+
'General_ColumnNbVisitsDocumentation',
161160
'General_ColumnNbActions',
161+
'General_ColumnNbActionsDocumentation',
162162
'General_Search',
163163
'General_SearchNoResults',
164164
);

plugins/SegmentEditor/lang/en.json

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -34,10 +34,6 @@
3434
"SparklineTooltipWeeks": "Evolution of Visits for segment \"%s\" over the last 30 weeks",
3535
"SparklineTooltipMonths": "Evolution of Visits for segment \"%s\" over the last 30 months",
3636
"SparklineTooltipYears": "Evolution of Visits for segment \"%s\" over the last 30 years",
37-
"SparklineEvolutionTooltip": "The percentage change of visits compared to the previous period for this segment. A positive value indicates growth, while a negative value signals a decrease.",
38-
"MetricDocumentationSegment": "The list of tracked segments. Each row represents a separate segment with its corresponding analytics data.",
39-
"MetricDocumentationVisits": "The total number of visits recorded for each segment. A visit starts when a user accesses the site and ends after a period of inactivity or when the session expires.",
40-
"MetricDocumentationActions": "The number of actions performed for each segment. Actions can be page views, internal site searches, downloads or outlinks.",
4137
"ThisSegmentIsVisibleTo": "This segment is visible to:",
4238
"VisibleToAllUsers": "all users",
4339
"VisibleToMe": "me",

plugins/SegmentEditor/templates/manageSegments.twig

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -15,16 +15,16 @@
1515
<thead>
1616
<tr class="index">
1717
<th></th>
18-
<th title="{{ 'SegmentEditor_MetricDocumentationSegment'|translate }}">
19-
{{ 'General_Name'|translate }}
18+
<th title="{{ 'General_ColumnSegmentDocumentation'|translate }}">
19+
{{ 'General_ColumnSegment'|translate }}
2020
</th>
21-
<th class="entityTable_Numeric" title="{{ 'SegmentEditor_MetricDocumentationVisits'|translate }}">
21+
<th class="entityTable_Numeric" title="{{ 'General_ColumnNbVisitsDocumentation'|translate }}">
2222
{{ 'General_ColumnNbVisits'|translate }}
2323
</th>
24-
<th class="entityTable_Numeric" title="{{ 'SegmentEditor_MetricDocumentationActions'|translate }}">
24+
<th class="entityTable_Numeric" title="{{ 'General_ColumnNbActionsDocumentation'|translate }}">
2525
{{ 'General_ColumnNbActions'|translate }}
2626
</th>
27-
<th class="entityTable_Numeric" colspan="2" title="{{ 'SegmentEditor_SparklineEvolutionTooltip'|translate(period) }}">
27+
<th class="entityTable_Numeric" colspan="2" title="{{ 'General_ColumnEvolutionVisitsDocumentation'|translate }}">
2828
{{ 'General_ColumnEvolutionVisits'|translate }}
2929
</th>
3030
<th></th>
@@ -50,7 +50,7 @@
5050
<td class="entityTable_Numeric">{{ segmentData[loop.index0].nb_visits }}</td>
5151
<td class="entityTable_Numeric">{{ segmentData[loop.index0].nb_actions }}</td>
5252
<td class="entityTable_Numeric">
53-
<span title="{{ 'SegmentEditor_SparklineEvolutionTooltip'|translate(period) }}" class="sparklineEvolution sparklineEvolution-{{ segmentData[loop.index0].evolution_visits_direction }}">
53+
<span title="{{ 'General_ColumnEvolutionVisitsDocumentation'|translate }}" class="sparklineEvolution sparklineEvolution-{{ segmentData[loop.index0].evolution_visits_direction }}">
5454
<img src="{{ segmentData[loop.index0].evolution_visits_icon }}" alt="" class="sparklineEvolution_icon" />
5555
{{ segmentData[loop.index0].evolution_visits }}
5656
</span>

0 commit comments

Comments
 (0)