Skip to content

Commit f3c815b

Browse files
authored
Redesign of top control selectors - feedbacks (#24426)
* Better WidgetizedDashboard wrapping * Improve period selector - arrows focus style * Remove top controls from overlay view * Fix period selector padding * Improve period selector styles without :has() selector
1 parent c7c843c commit f3c815b

151 files changed

Lines changed: 364 additions & 335 deletions

File tree

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.
Lines changed: 2 additions & 2 deletions
Lines changed: 2 additions & 2 deletions
Lines changed: 2 additions & 2 deletions
Lines changed: 2 additions & 2 deletions
Lines changed: 2 additions & 2 deletions
Lines changed: 2 additions & 2 deletions
Lines changed: 2 additions & 2 deletions

ā€Žplugins/CoreHome/stylesheets/selector.lessā€Ž

Lines changed: 46 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
@_selector-button_padding: 8px 16px;
2+
@_selector-button_inner-half-gap: 8px;
23
@_selector-button_color-background: @theme-color-background-contrast;
34
@_selector-button_color-background-hover: @theme-color-background-contrast;
45
@_selector-button_border: 1px solid @theme-color-border;
@@ -43,18 +44,10 @@
4344
color: @theme-color-text;
4445
font-variant: tabular-nums;
4546

46-
&:has(.icon-chevron-down) {
47-
flex-direction: row-reverse;
48-
}
49-
5047
&:focus {
5148
outline: none;
5249
}
5350

54-
&:focus-visible {
55-
outline: 2px solid @theme-color-focus-ring;
56-
}
57-
5851
&.activityIndicator {
5952
background: url(plugins/Morpheus/images/loading-blue.gif) no-repeat 9px 9px;
6053

@@ -85,9 +78,9 @@
8578

8679
&.expanded,
8780
&.editing,
88-
&:hover,
89-
&:focus,
90-
&:focus-within {
81+
&:hover:not(.periodSelector-withPrevNext),
82+
&:focus:not(.periodSelector-withPrevNext),
83+
&:focus-within:not(.periodSelector-withPrevNext) {
9184
border: @_selector-button_border-active;
9285

9386
span.title,
@@ -101,22 +94,62 @@
10194
/* Period selector specific: left & right arrows */
10295

10396
.move-period {
97+
position: relative;
10498
padding: @_selector-button_padding;
10599
background-color: @_selector-button_color-background;
100+
101+
&::before {
102+
content: '';
103+
position: absolute;
104+
inset: -1px;
105+
border: 1px solid transparent;
106+
107+
pointer-events: none;
108+
}
109+
110+
&:hover::before,
111+
&:focus-visible::before {
112+
border-color: @theme-color-focus-ring;
113+
}
106114
}
107115

108116
.move-period-prev {
109-
padding-right: 0;
117+
padding-right: @_selector-button_inner-half-gap;
110118
border-radius: @_selector-button_border-radius 0 0 @_selector-button_border-radius;
119+
120+
&::before {
121+
border-radius: @_selector-button_border-radius 0 0 @_selector-button_border-radius;
122+
}
111123
}
112124

113125
.move-period-next {
114-
padding-left: 0;
126+
padding-left: @_selector-button_inner-half-gap;
115127
border-radius: 0 @_selector-button_border-radius @_selector-button_border-radius 0;
128+
129+
&::before {
130+
border-radius: 0 @_selector-button_border-radius @_selector-button_border-radius 0;
131+
}
116132
}
117133

118134
&.periodSelector-withPrevNext .title {
119135
border-radius: 0;
136+
padding-left: @_selector-button_inner-half-gap;
137+
padding-right: @_selector-button_inner-half-gap;
138+
139+
&::before {
140+
content: '';
141+
position: absolute;
142+
inset: -1px;
143+
border: 1px solid transparent;
144+
border-radius: @_selector-button_border-radius;
145+
146+
pointer-events: none;
147+
}
148+
149+
&:hover::before,
150+
&:focus-visible::before {
151+
border-color: @theme-color-focus-ring;
152+
}
120153
}
121154
}
122155

ā€Žplugins/CoreHome/vue/dist/CoreHome.umd.jsā€Ž

Lines changed: 30 additions & 30 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

ā€Žplugins/CoreHome/vue/dist/CoreHome.umd.min.jsā€Ž

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
Ā (0)
⚔