adding option to not resize the viewport for screenshotSelector so that we can set some viewport height if we want to

Author: chippison

tests/UI/specs/Menus_spec.js

@@ -106,7 +106,7 @@ describe("Menus", function () {
     });
 
     it('should load the admin left menu correctly on mobile', async function() {
-        await page.webpage.setViewport({ width: 815, height: 700 });
+        await page.webpage.setViewport({ width: 815, height: 1650 });
         await page.goto("?module=CoreAdminHome&action=home");
         await page.waitForNetworkIdle();
         await page.click('[data-target="mobile-left-menu"]');
@@ -119,7 +119,7 @@ describe("Menus", function () {
         await page.click('ul#mobile-left-menu > li:nth-child(6) a');
         await page.waitForTimeout(500);
 
-        expect(await page.screenshotSelector('#mobile-left-menu')).to.matchImage('mobile_left_admin');
+        expect(await page.screenshotSelector('#mobile-left-menu', false)).to.matchImage('mobile_left_admin');
     });
 
     it('should load the admin top menu correctly on mobile', async function() {
@@ -135,7 +135,7 @@ describe("Menus", function () {
     });
 
     it('should load the left reporting menu correctly on mobile', async function() {
-        await page.webpage.setViewport({ width: 768, height: 500 });
+        await page.webpage.setViewport({ width: 768, height: 1000 });
         await page.goto("?" + generalParams + "&module=CoreHome&action=index#?category=General_Visitors&subcategory=General_Overview");
         await page.waitForNetworkIdle();
         await page.evaluate(function(){
@@ -145,6 +145,6 @@ describe("Menus", function () {
         await (await page.jQuery('#mobile-left-menu>li>ul:contains(Goals)')).click();
         await page.waitForTimeout(500);
 
-        expect(await page.screenshotSelector('#mobile-left-menu')).to.matchImage('mobile_left');
+        expect(await page.screenshotSelector('#mobile-left-menu', false)).to.matchImage('mobile_left');
     });
 });

tests/lib/screenshot-testing/support/page-renderer.js

@@ -197,10 +197,12 @@ PageRenderer.prototype.resizeViewportToFullPage = async function () {
     await this.webpage.setViewport(JSON.parse(dims));
 };
 
-PageRenderer.prototype.screenshotSelector = async function (selector) {
+PageRenderer.prototype.screenshotSelector = async function (selector, resizeViewportToFullPage = true) {
     await this.waitForFunction(() => !! window.$, { timeout: 60000 });
 
-    await this.resizeViewportToFullPage();
+    if (resizeViewportToFullPage) {
+        await this.resizeViewportToFullPage();
+    }
 
     const result = await this.webpage.evaluate(function (selector) {
         window.jQuery('html').addClass('uiTest');