introduce new exception class

Author: sgiehl

core/AssetManager/UIAssetFetcher/PluginUmdAssetFetcher.php

@@ -14,7 +14,7 @@
 use Piwik\Config;
 use Piwik\Container\StaticContainer;
 use Piwik\Development;
-use Piwik\Http\BadRequestException;
+use Piwik\Exception\ThingNotFoundException;
 use Piwik\Plugin\Manager;
 
 class PluginUmdAssetFetcher extends UIAssetFetcher
@@ -203,7 +203,7 @@ protected function retrieveFileLocations()
             }
 
             if (!$foundChunk) {
-                throw new BadRequestException("Could not find chunk {$this->requestedChunk}", 404);
+                throw new ThingNotFoundException('Could not find chunk {$this->requestedChunk}');
             }
 
             foreach ($foundChunk->getFiles() as $file) {

core/Exception/ThingNotFoundException.php

@@ -0,0 +1,20 @@
+<?php
+
+/**
+ * Matomo - free/libre analytics platform
+ *
+ * @link    https://matomo.org
+ * @license https://www.gnu.org/licenses/gpl-3.0.html GPL v3 or later
+ */
+
+namespace Piwik\Exception;
+
+use Piwik\Http\HttpCodeException;
+
+class ThingNotFoundException extends \Piwik\Exception\Exception implements HttpCodeException
+{
+    public function __construct($message, $previous = null)
+    {
+        parent::__construct($message, 400, $previous);
+    }
+}

core/Http/ControllerResolver.php

@@ -10,7 +10,7 @@
 namespace Piwik\Http;
 
 use DI\FactoryInterface;
-use Exception;
+use Piwik\Exception\ThingNotFoundException;
 use Piwik\Plugin\ReportsProvider;
 use Piwik\Plugin\WidgetsProvider;
 
@@ -41,7 +41,7 @@ public function __construct(FactoryInterface $abstractFactory, WidgetsProvider $
      * @param string $module
      * @param string|null $action
      * @param array $parameters
-     * @throws Exception Controller not found.
+     * @throws ThingNotFoundException Controller not found.
      * @return callable The controller is a PHP callable.
      */
     public function getController($module, $action, array &$parameters)
@@ -61,7 +61,7 @@ public function getController($module, $action, array &$parameters)
             return $controller;
         }
 
-        throw new BadRequestException(sprintf("Action '%s' not found in the module '%s'", $action, $module), 404);
+        throw new ThingNotFoundException(sprintf("Action '%s' not found in the module '%s'", $action, $module));
     }
 
     private function createPluginController($module, $action)