some TODO cleanup

Author: toger5

src/embedded.ts

@@ -690,6 +690,10 @@ function processAndThrow(error: unknown): never {
     }
 }
 
+/**
+ * This converts an "Request timed out" error from the PostmessageTransport into a ConnectionError.
+ * It either throws the original error or a new ConnectionError.
+ **/
 function timeoutToConnectionError(error: unknown): never {
     // TODO: this should not check on error.message but instead it should be a specific type
     // error instanceof WidgetTimeoutError

src/matrixrtc/MatrixRTCSession.ts

@@ -61,28 +61,11 @@ export type MatrixRTCSessionEventHandlerMap = {
 
 export interface MembershipConfig {
     /**
-     * Use the new Manager
-     */
-    useNewMembershipManager?: boolean;
-
-    /**
-     * This is just for testing
+     * Use the new Manager.
      *
-     * TODO: remove as part of PR cleanup
+     * Default: `false`.
      */
-    membershipManagerFactory?: (
-        joinConfig: MembershipConfig | undefined,
-        room: Pick<Room, "getLiveTimeline" | "roomId" | "getVersion">,
-        client: Pick<
-            MatrixClient,
-            | "getUserId"
-            | "getDeviceId"
-            | "sendStateEvent"
-            | "_unstable_sendDelayedStateEvent"
-            | "_unstable_updateDelayedEvent"
-        >,
-        getOldestMembership: () => CallMembership | undefined,
-    ) => IMembershipManager;
+    useNewMembershipManager?: boolean;
 
     /**
      * The timeout (in milliseconds) after we joined the call, that our membership should expire
@@ -373,14 +356,7 @@ export class MatrixRTCSession extends TypedEventEmitter<MatrixRTCSessionEvent, M
             return;
         } else {
             // Create MembershipManager
-            if (joinConfig?.membershipManagerFactory) {
-                this.membershipManager = joinConfig.membershipManagerFactory(
-                    joinConfig,
-                    this.roomSubset,
-                    this.client,
-                    () => this.getOldestMembership(),
-                );
-            } else if (joinConfig?.useNewMembershipManager ?? false) {
+            if (joinConfig?.useNewMembershipManager ?? false) {
                 this.membershipManager = new MembershipManager(joinConfig, this.roomSubset, this.client, () =>
                     this.getOldestMembership(),
                 );