change(ffi): expose the full RoomPowerLevels object and move corresponding methods to it#5250
Merged
stefanceriu merged 2 commits intomainfrom Jun 19, 2025
Merged
change(ffi): expose the full RoomPowerLevels object and move corresponding methods to it#5250stefanceriu merged 2 commits intomainfrom
stefanceriu merged 2 commits intomainfrom
Conversation
stefanceriu
force-pushed
the
stefan/roomPowerLevels
branch
from
d3ebbc9 to
369c75f
Compare
andybalaam
approved these changes
Jun 19, 2025
Member
andybalaam
left a comment
andybalaam
left a comment
There was a problem hiding this comment.
Looks sensible to me, but the CI is moaning about some formatting.
stefanceriu
force-pushed
the
stefan/roomPowerLevels
branch
from
e418d83 to
2c6a0e0
Compare
Contributor
It just needs a bit of a rebase onto main. |
…nding methods to it. This patch expands on the already existent `RoomPowerLevels` record (which it renames to `RoomPowerLevelsValues` to work around uniffi not exposing public fields) and nests them inside a new exported object that also provides methods for retrieving the actions that an user can take, methods moved from the room object. This reduces the amount of async calls the clients need to make, simplifies the API and groups the code better together.
stefanceriu
force-pushed
the
stefan/roomPowerLevels
branch
from
2c6a0e0 to
f580f2e
Compare
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found.
Additional details and impacted files@@ Coverage Diff @@
## main #5250 +/- ##
==========================================
+ Coverage 90.13% 90.18% +0.04%
==========================================
Files 334 334
Lines 104717 104681 -36
Branches 104717 104681 -36
==========================================
+ Hits 94387 94404 +17
+ Misses 6277 6224 -53
Partials 4053 4053 ☔ View full report in Codecov by Sentry. |
Member
Author
|
All green, thank you gents! |
poljar
added a commit
that referenced
this pull request
Jul 10, 2025
poljar
added a commit
that referenced
this pull request
Jul 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch expands on the already existent
RoomPowerLevelsrecord (which it renames toRoomPowerLevelsValuesto work around uniffi not exposing public fields) and nests them inside a new exported object that also provides methods for retrieving the actions that an user can take, methods moved from the room object. This reduces the amount of async calls the clients need to make, simplifies the API and groups the code better together.On the sdk/base level those methods can be removed as the underlying power levels are already exposed.