Exclude insecure devices on Olm encryption

[uhoreg]

Fixes the encrypting part of #4147

Probably easiest to review commit-by-commit

• Public API changes documented in changelogs (optional)

Signed-off-by:

[codspeed-hq]

CodSpeed Performance Report

Merging #5457 will not alter performance

_{Comparing uhoreg:exclude_insecure_devices_olm_encryption (9967057) with main (b164cd6)}

Summary

✅ 6 untouched benchmarks

[codecov]

Codecov Report

❌ Patch coverage is 90.31792% with 67 lines in your changes missing coverage. Please review.
✅ Project coverage is 88.93%. Comparing base (92192c5) to head (9967057).
⚠️ Report is 22 commits behind head on main.
✅ All tests successful. No failed tests found.

Files with missing lines	Patch %	Lines
...c/session_manager/group_sessions/share_strategy.rs	90.29%	55 Missing and 10 partials ⚠️
crates/matrix-sdk-crypto/src/identities/device.rs	90.00%	0 Missing and 1 partial ⚠️
crates/matrix-sdk-crypto/src/machine/mod.rs	87.50%	0 Missing and 1 partial ⚠️

Additional details and impacted files

@@           Coverage Diff            @@
##             main    #5457    +/-   ##
========================================
  Coverage   88.92%   88.93%            
========================================
  Files         333      333            
  Lines       92267    92932   +665     
  Branches    92267    92932   +665     
========================================
+ Hits        82051    82651   +600     
- Misses       6374     6427    +53     
- Partials     3842     3854    +12     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[uhoreg]

Code Coverage failure is due to the runner running out of disk space. It succeeded last night. Will re-try in a bit.

[poljar]

Code Coverage failure is due to the runner running out of disk space. It succeeded last night. Will re-try in a bit.

I attempted to free some more space up in #5464. You might need to rebase for this PR to pick up things.

[andybalaam]

I got a bit lost in all this and would appreciate you talking me through it if possible.

[andybalaam]

Looks good, thanks!

[uhoreg]

@andybalaam or @poljar Can one of you mash the "merge" button? I don't have permissions to do so.

[poljar]

I'll let the reviewer take car of this, unless Andy doesn't merge by the end of the day.