Improve error message when multipart submissions cannot be parsed (#108)

richvdh · web-flow · commit 53879d31f01f · 2025-11-28T14:39:59.000Z
diff --git a/changelog.d/108.feature b/changelog.d/108.feature
@@ -0,0 +1 @@
+Improve HTTP error on malformed multipart submissions.
diff --git a/submit.go b/submit.go
@@ -304,7 +304,7 @@ func parseRequest(w http.ResponseWriter, req *http.Request, reportDir string, ma
 			p, err1 := parseMultipartRequest(w, req, reportDir, maxloglines)
 			if err1 != nil {
 				log.Println("Error parsing multipart data:", err1)
-				writeError(w, 400, submitErrorResponse{Error: "Bad multipart data", ErrorCode: ErrCodeBadContent})
+				writeError(w, 400, submitErrorResponse{Error: fmt.Sprintf("Bad multipart data: %v", err1), ErrorCode: ErrCodeBadContent})
 				return nil
 			}
 			return p

Original file line number	Diff line number	Diff line change
`@@ -0,0 +1 @@`
	`1`	`+Improve HTTP error on malformed multipart submissions.`
Original file line number	Diff line number	Diff line change
`@@ -304,7 +304,7 @@ func parseRequest(w http.ResponseWriter, req *http.Request, reportDir string, ma`
`304`	`304`	`p, err1 := parseMultipartRequest(w, req, reportDir, maxloglines)`
`305`	`305`	`if err1 != nil {`
`306`	`306`	`log.Println("Error parsing multipart data:", err1)`
`307`		`- writeError(w, 400, submitErrorResponse{Error: "Bad multipart data", ErrorCode: ErrCodeBadContent})`
	`307`	`+ writeError(w, 400, submitErrorResponse{Error: fmt.Sprintf("Bad multipart data: %v", err1), ErrorCode: ErrCodeBadContent})`
`308`	`308`	`return nil`
`309`	`309`	`}`
`310`	`310`	`return p`