newsfile and lint

Author: dklimpel

changelog.d/12833.misc

@@ -0,0 +1 @@
+Add some type hints to tests files.

tests/crypto/test_event_signing.py

@@ -39,7 +39,7 @@ def setUp(self):
         # NB: `signedjson` expects `nacl.signing.SigningKey` instances which have been
         # monkeypatched to include new `alg` and `version` attributes. This is captured
         # by the `signedjson.types.SigningKey` protocol.
-        self.signing_key: signedjson.types.SigningKey = nacl.signing.SigningKey(
+        self.signing_key: signedjson.types.SigningKey = nacl.signing.SigningKey(  # type: ignore[assignment]
             SIGNING_KEY_SEED
         )
         self.signing_key.alg = KEY_ALG

tests/http/test_servlet.py

@@ -60,7 +60,9 @@ def test_parse_json_value(self):
         with self.assertRaises(SynapseError):
             parse_json_value_from_request(make_request(b""))
 
-        result3 = parse_json_value_from_request(make_request(b""), allow_empty_body=True)
+        result3 = parse_json_value_from_request(
+            make_request(b""), allow_empty_body=True
+        )
         self.assertIsNone(result3)
 
         # Invalid UTF-8.

tests/logging/test_opentracing.py

@@ -34,7 +34,7 @@
 try:
     import jaeger_client
 except ImportError:
-    jaeger_client = None
+    jaeger_client = None  # type: ignore
 
 from tests.unittest import TestCase
 
@@ -43,7 +43,7 @@ class LogContextScopeManagerTestCase(TestCase):
     if LogContextScopeManager is None:
         skip = "Requires opentracing"  # type: ignore[unreachable]
     if jaeger_client is None:
-        skip = "Requires jaeger_client"
+        skip = "Requires jaeger_client"  # type: ignore[unreachable]
 
     def setUp(self) -> None:
         # since this is a unit test, we don't really want to mess around with the