Skip to content
This repository was archived by the owner on Apr 26, 2024. It is now read-only.

Commit 5308239

Browse files
authored
Reduce logging verbosity of URL cache cleanup. (#7295)
1 parent ff5604e commit 5308239

2 files changed

Lines changed: 8 additions & 2 deletions

File tree

changelog.d/7295.misc

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
Reduce log verbosity of url cache cleanup tasks.

synapse/rest/media/v1/preview_url_resource.py

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -402,7 +402,7 @@ async def _expire_url_cache_data(self):
402402

403403
now = self.clock.time_msec()
404404

405-
logger.info("Running url preview cache expiry")
405+
logger.debug("Running url preview cache expiry")
406406

407407
if not (await self.store.db.updates.has_completed_background_updates()):
408408
logger.info("Still running DB updates; skipping expiry")
@@ -435,6 +435,8 @@ async def _expire_url_cache_data(self):
435435

436436
if removed_media:
437437
logger.info("Deleted %d entries from url cache", len(removed_media))
438+
else:
439+
logger.debug("No entries removed from url cache")
438440

439441
# Now we delete old images associated with the url cache.
440442
# These may be cached for a bit on the client (i.e., they
@@ -481,7 +483,10 @@ async def _expire_url_cache_data(self):
481483

482484
await self.store.delete_url_cache_media(removed_media)
483485

484-
logger.info("Deleted %d media from url cache", len(removed_media))
486+
if removed_media:
487+
logger.info("Deleted %d media from url cache", len(removed_media))
488+
else:
489+
logger.debug("No media removed from url cache")
485490

486491

487492
def decode_and_calc_og(body, media_uri, request_encoding=None):

0 commit comments

Comments
 (0)