WIP: Applied feedback

Author: Yoric

changelog.d/12703.misc

@@ -1 +1 @@
-Introduce a string enum `Code` to replace the namespace class `Codes`.
+Convert namespace class `Codes` into a string enum.

synapse/api/errors.py

@@ -31,7 +31,7 @@
 logger = logging.getLogger(__name__)
 
 
-class Code(str, Enum):
+class Codes(str, Enum):
     """
     All known error codes, as an enum of strings.
     """
@@ -93,11 +93,6 @@ def __repr__(self) -> str:
     UNREDACTED_CONTENT_DELETED = "FI.MAU.MSC2815_UNREDACTED_CONTENT_DELETED"
 
 
-# `Codes` used to be a namespace for codes. This is now replaced
-# with the enum `Code` but we maintain it for backwards compatibility.
-Codes = Code
-
-
 class CodeMessageException(RuntimeError):
     """An exception with integer code and message string attributes.