Use git tags for automatic version resolution in build (#201)

Made-with: Cursor

Co-authored-by: Nevyana Angelova <[email protected]>

Author: nevyangelova

Makefile

@@ -248,7 +248,7 @@ debug-dist: apply server webapp-debug bundle
 
 ## Runs any lints and unit tests defined for the server and webapp, if they exist.
 .PHONY: test
-test: webapp/.npminstall
+test: apply webapp/.npminstall
 ifneq ($(HAS_SERVER),)
 	$(GO) test -v $(GO_TEST_FLAGS) -ldflags '$(LDFLAGS)' ./server/...
 endif

build/manifest/main.go

@@ -4,11 +4,18 @@ import (
 	"encoding/json"
 	"fmt"
 	"os"
+	"strings"
 
 	"github.com/mattermost/mattermost/server/public/model"
 	"github.com/pkg/errors"
 )
 
+var (
+	BuildHashShort  string
+	BuildTagLatest  string
+	BuildTagCurrent string
+)
+
 const pluginIDGoFileTemplate = `// This file is automatically generated. Do not modify it manually.
 
 package main
@@ -100,6 +107,32 @@ func findManifest() (*model.Manifest, error) {
 		return nil, errors.Wrap(err, "failed to parse manifest")
 	}
 
+	// If no version is listed in the manifest, generate one based on the state of the current
+	// commit, and use the first version we find (to prevent causing errors)
+	if manifest.Version == "" {
+		var version string
+		tags := strings.Fields(BuildTagCurrent)
+		for _, t := range tags {
+			if strings.HasPrefix(t, "v") {
+				version = t
+				break
+			}
+		}
+		if version == "" {
+			switch {
+			case BuildTagLatest != "" && BuildHashShort != "":
+				version = BuildTagLatest + "+" + BuildHashShort
+			case BuildTagLatest != "":
+				version = BuildTagLatest
+			case BuildHashShort != "":
+				version = "v0.0.0+" + BuildHashShort
+			default:
+				version = "v0.0.0"
+			}
+		}
+		manifest.Version = strings.TrimPrefix(version, "v")
+	}
+
 	return &manifest, nil
 }
 

build/setup.mk

@@ -4,8 +4,13 @@ ifeq ($(GO),)
     $(error "go is not available: see https://golang.org/doc/install")
 endif
 
+# Gather build variables to inject into the manifest tool
+BUILD_HASH_SHORT = $(shell git rev-parse --short HEAD)
+BUILD_TAG_LATEST = $(shell git describe --tags --match 'v*' --abbrev=0 2>/dev/null)
+BUILD_TAG_CURRENT = $(shell git tag --points-at HEAD)
+
 # Ensure that the build tools are compiled. Go's caching makes this quick.
-$(shell cd build/manifest && $(GO) build -o ../bin/manifest)
+$(shell cd build/manifest && $(GO) build -ldflags '-X "main.BuildHashShort=$(BUILD_HASH_SHORT)" -X "main.BuildTagLatest=$(BUILD_TAG_LATEST)" -X "main.BuildTagCurrent=$(BUILD_TAG_CURRENT)"' -o ../bin/manifest)
 
 # Ensure that the deployment tools are compiled. Go's caching makes this quick.
 $(shell cd build/deploy && $(GO) build -o ../bin/deploy)

plugin.json

@@ -2,7 +2,6 @@
     "id": "com.mattermost.wrangler",
     "name": "Wrangler",
     "description": "Manage messages across teams and channels",
-    "version": "0.9.0",
     "min_server_version": "10.11.0",
     "server": {
         "executables": {