WIP logging to figure out custom column race condition

Author: mattrunyon

packages/dashboard-core-plugins/src/panels/IrisGridPanel.tsx

@@ -105,6 +105,7 @@ import {
   emitLinkPointSelected,
   emitLinkSourceDataSelected,
 } from '../linker/LinkerEvent';
+import { flushSync } from 'react-dom';
 
 const log = Log.module('IrisGridPanel');
 
@@ -817,6 +818,7 @@ export class IrisGridPanel extends PureComponent<
     const panelId = LayoutUtils.getIdFromPanel(this);
     assertNotNull(panelId);
     emitFilterColumnsChanged(glEventHub, panelId, columns);
+    flushSync(() => {});
   }
 
   startModelListening(model: IrisGridModel): void {

packages/iris-grid/src/IrisGrid.tsx

@@ -194,6 +194,7 @@ import type ColumnHeaderGroup from './ColumnHeaderGroup';
 import { IrisGridThemeContext } from './IrisGridThemeProvider';
 import { isMissingPartitionError } from './MissingPartitionError';
 import { NoPastePermissionModal } from './NoPastePermissionModal';
+import { flushSync } from 'react-dom';
 
 const log = Log.module('IrisGrid');
 
@@ -3462,7 +3463,9 @@ class IrisGrid extends Component<IrisGridProps, IrisGridState> {
           `change moved columns for removed custom columns`,
           newMovedColumns
         );
-        this.setState({ movedColumns: newMovedColumns });
+        flushSync(() => {
+          this.setState({ movedColumns: newMovedColumns });
+        });
       }
       if (!deepEqual(selectDistinctColumns, newSelectDistinctColumns)) {
         log.debug(
@@ -3473,7 +3476,9 @@ class IrisGrid extends Component<IrisGridProps, IrisGridState> {
       }
     }
 
-    this.setState({ customColumns });
+    flushSync(() => {
+      this.setState({ customColumns });
+    });
     if (customColumns.length > 0) {
       // If there are no custom columns, the change handler never fires
       // This causes the loader to stay until canceled by the user

packages/iris-grid/src/IrisGridModelUpdater.tsx

@@ -152,6 +152,7 @@ function IrisGridModelUpdater({
   );
   useOnChange(
     function updateViewport() {
+      console.log('updating viewport', columns?.at(-1));
       model.setViewport(top, bottom, columns);
     },
     [model, top, bottom, columns]

packages/iris-grid/src/IrisGridTableModelTemplate.ts

@@ -1173,6 +1173,7 @@ class IrisGridTableModelTemplate<
     };
 
     const { columns } = data;
+    console.log(data, columns);
     for (let r = 0; r < data.rows.length; r += 1) {
       const row = data.rows[r];
       const newRow = this.extractViewportRow(row, columns);
@@ -1374,6 +1375,8 @@ class IrisGridTableModelTemplate<
         top,
         bottom
       );
+      console.log('apply viewport', columns?.at(-1));
+      console.trace();
       this.applyBufferedViewport(viewportTop, viewportBottom, columns);
     },
     APPLY_VIEWPORT_THROTTLE,