Skip to content

Commit 24d3599

Browse files
Fix middle button mouse up on status header always opening status in a new tab (mastodon#34700)
1 parent 6c74383 commit 24d3599

1 file changed

Lines changed: 2 additions & 3 deletions

File tree

app/javascript/mastodon/components/status.jsx

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -175,9 +175,8 @@ class Status extends ImmutablePureComponent {
175175
}
176176
};
177177

178-
handleMouseUp = e => {
178+
handleHeaderClick = e => {
179179
// Only handle clicks on the empty space above the content
180-
181180
if (e.target !== e.currentTarget && e.detail >= 1) {
182181
return;
183182
}
@@ -547,7 +546,7 @@ class Status extends ImmutablePureComponent {
547546
<div className={classNames('status', `status-${status.get('visibility')}`, { 'status-reply': !!status.get('in_reply_to_id'), 'status--in-thread': !!rootId, 'status--first-in-thread': previousId && (!connectUp || connectToRoot), muted: this.props.muted })} data-id={status.get('id')}>
548547
{(connectReply || connectUp || connectToRoot) && <div className={classNames('status__line', { 'status__line--full': connectReply, 'status__line--first': !status.get('in_reply_to_id') && !connectToRoot })} />}
549548

550-
<div onMouseUp={this.handleMouseUp} className='status__info'>
549+
<div onClick={this.handleHeaderClick} onAuxClick={this.handleHeaderClick} className='status__info'>
551550
<Link to={`/@${status.getIn(['account', 'acct'])}/${status.get('id')}`} className='status__relative-time'>
552551
<span className='status__visibility-icon'><VisibilityIcon visibility={status.get('visibility')} /></span>
553552
<RelativeTimestamp timestamp={status.get('created_at')} />{status.get('edited_at') && <abbr title={intl.formatMessage(messages.edited, { date: intl.formatDate(status.get('edited_at'), { year: 'numeric', month: 'short', day: '2-digit', hour: '2-digit', minute: '2-digit' }) })}> *</abbr>}

0 commit comments

Comments
 (0)