fix(android): same callback logic between showModal options (#220)

maggialejandro · maggialejandro-rp · web-flow · commit 7eef64a75a0c · 2020-07-29T15:30:49.000-03:00
Co-authored-by: Alejandro &lt;alejandro.maggi@recargapay.com&gt;
diff --git a/android/src/main/java/br/com/classapp/RNSensitiveInfo/RNSensitiveInfoModule.java b/android/src/main/java/br/com/classapp/RNSensitiveInfo/RNSensitiveInfoModule.java
@@ -363,7 +363,8 @@ public void onAuthenticationError(int errorCode, @NonNull CharSequence errString
 
                                 @Override
                                 public void onAuthenticationFailed() {
-                                    pm.reject(AppConstants.E_AUTHENTICATION_NOT_RECOGNIZED, strings.containsKey("notRecognized") ? strings.get("notRecognized").toString() : "Fingerprint not recognized, try again");
+                                    getReactApplicationContext().getJSModule(DeviceEventManagerModule.RCTDeviceEventEmitter.class)
+                                            .emit("FINGERPRINT_AUTHENTICATION_HELP", "Fingerprint not recognized.");
                                 }
                             }
 
@@ -476,7 +477,8 @@ public void onAuthenticationError(int errorCode, @NonNull CharSequence errString
 
                                 @Override
                                 public void onAuthenticationFailed() {
-                                    pm.reject(AppConstants.E_AUTHENTICATION_NOT_RECOGNIZED, strings.containsKey("notRecognized") ? strings.get("notRecognized").toString() : "Fingerprint not recognized, try again");
+                                    getReactApplicationContext().getJSModule(DeviceEventManagerModule.RCTDeviceEventEmitter.class)
+                                            .emit("FINGERPRINT_AUTHENTICATION_HELP", "Fingerprint not recognized.");
                                 }
                             }
 
diff --git a/android/src/main/java/br/com/classapp/RNSensitiveInfo/utils/AppConstants.java b/android/src/main/java/br/com/classapp/RNSensitiveInfo/utils/AppConstants.java
@@ -5,7 +5,6 @@ public interface AppConstants {
     String DIALOG_FRAGMENT_TAG = "authFragment";
 
     // error codes
-    String E_AUTHENTICATION_NOT_RECOGNIZED = "E_AUTHENTICATION_NOT_RECOGNIZED";
     String E_AUTHENTICATION_CANCELLED = "E_AUTHENTICATION_CANCELLED";
     String E_INIT_FAILURE = "E_INIT_FAILURE";
 }

Original file line number	Diff line number	Diff line change
`@@ -363,7 +363,8 @@ public void onAuthenticationError(int errorCode, @NonNull CharSequence errString`
`363`	`363`
`364`	`364`	`@Override`
`365`	`365`	`public void onAuthenticationFailed() {`
`366`		`- pm.reject(AppConstants.E_AUTHENTICATION_NOT_RECOGNIZED, strings.containsKey("notRecognized") ? strings.get("notRecognized").toString() : "Fingerprint not recognized, try again");`
	`366`	`+ getReactApplicationContext().getJSModule(DeviceEventManagerModule.RCTDeviceEventEmitter.class)`
	`367`	`+ .emit("FINGERPRINT_AUTHENTICATION_HELP", "Fingerprint not recognized.");`
`367`	`368`	`}`
`368`	`369`	`}`
`369`	`370`
`@@ -476,7 +477,8 @@ public void onAuthenticationError(int errorCode, @NonNull CharSequence errString`
`476`	`477`
`477`	`478`	`@Override`
`478`	`479`	`public void onAuthenticationFailed() {`
`479`		`- pm.reject(AppConstants.E_AUTHENTICATION_NOT_RECOGNIZED, strings.containsKey("notRecognized") ? strings.get("notRecognized").toString() : "Fingerprint not recognized, try again");`
	`480`	`+ getReactApplicationContext().getJSModule(DeviceEventManagerModule.RCTDeviceEventEmitter.class)`
	`481`	`+ .emit("FINGERPRINT_AUTHENTICATION_HELP", "Fingerprint not recognized.");`
`480`	`482`	`}`
`481`	`483`	`}`
`482`	`484`
Original file line number	Diff line number	Diff line change
`@@ -5,7 +5,6 @@ public interface AppConstants {`
`5`	`5`	`String DIALOG_FRAGMENT_TAG = "authFragment";`
`6`	`6`
`7`	`7`	`// error codes`
`8`		`- String E_AUTHENTICATION_NOT_RECOGNIZED = "E_AUTHENTICATION_NOT_RECOGNIZED";`
`9`	`8`	`String E_AUTHENTICATION_CANCELLED = "E_AUTHENTICATION_CANCELLED";`
`10`	`9`	`String E_INIT_FAILURE = "E_INIT_FAILURE";`
`11`	`10`	`}`