Fixes TypeError for domain() when domain reads as blank.#27
Merged
rodneyrehm merged 1 commit intomedialize:gh-pagesfrom May 19, 2012
mutewinter:empty_domain_fix
Merged
Fixes TypeError for domain() when domain reads as blank.#27rodneyrehm merged 1 commit intomedialize:gh-pagesfrom mutewinter:empty_domain_fix
rodneyrehm merged 1 commit intomedialize:gh-pagesfrom
mutewinter:empty_domain_fix
Conversation
rodneyrehm
added a commit
that referenced
this pull request
May 19, 2012
Fixing TypeError for domain() on dot-less hostnames
Member
|
good catch! I added some tests and released version 1.6.1 :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When calling
url.domain()orurl.subdomain()on a URI of the formhttp://test/, a TypeError results. This patch fixes that error.