fix(product, dashboard): align product and variant volumetric attributes data types#14762
Open
NicolasGorga wants to merge 14 commits intodevelopfrom
Open
fix(product, dashboard): align product and variant volumetric attributes data types#14762NicolasGorga wants to merge 14 commits intodevelopfrom
NicolasGorga wants to merge 14 commits intodevelopfrom
Conversation
🦋 Changeset detectedLatest commit: daa0a93 The changes in this PR will be included in the next version bump. This PR includes changesets to release 77 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for GitHub. 9 Skipped Deployments
|
|
Thank you for your contribution! After reviewing this PR, we need a few things addressed before we can move forward: Required changes:
Notes:
|
Contributor
Author
Yes this is already covered |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
What — What changes are introduced in this PR?
Align product (currently strings) and variants (currently integers) volumetric attributes (width, length, height, weight) data types and also to reality, by making them decimals.
Why — Why are these changes relevant or necessary?
There is a mismatch between both models for representing the same properties and also, the int data type is too restrictive and not representative of the reality of volumetric attributes.
How — How have these changes been implemented?
Updated product properties from string to decimal and variant's from integer to decimal.
Testing — How have these changes been tested, or how can the reviewer test the feature?
Please provide answer here
Examples
Provide examples or code snippets that demonstrate how this feature works, or how it can be used in practice.
This helps with documentation and ensures maintainers can quickly understand and verify the change.
// Example usageChecklist
Please ensure the following before requesting a review:
yarn changesetand follow the promptsAdditional Context
Add any additional context, related issues, or references that might help the reviewer understand this PR.
fixes #14736