Skip to content

fix(product, dashboard): align product and variant volumetric attributes data types#14762

Open
NicolasGorga wants to merge 14 commits intodevelopfrom
fix/align-volumetric-product-attributes
Open

fix(product, dashboard): align product and variant volumetric attributes data types#14762
NicolasGorga wants to merge 14 commits intodevelopfrom
fix/align-volumetric-product-attributes

Conversation

@NicolasGorga
Copy link
Copy Markdown
Contributor

Summary

What — What changes are introduced in this PR?

Align product (currently strings) and variants (currently integers) volumetric attributes (width, length, height, weight) data types and also to reality, by making them decimals.

Why — Why are these changes relevant or necessary?

There is a mismatch between both models for representing the same properties and also, the int data type is too restrictive and not representative of the reality of volumetric attributes.

How — How have these changes been implemented?

Updated product properties from string to decimal and variant's from integer to decimal.

Testing — How have these changes been tested, or how can the reviewer test the feature?

Please provide answer here


Examples

Provide examples or code snippets that demonstrate how this feature works, or how it can be used in practice.
This helps with documentation and ensures maintainers can quickly understand and verify the change.

// Example usage

Checklist

Please ensure the following before requesting a review:

  • I have added a changeset for this PR
    • Every non-breaking change should be marked as a patch
    • To add a changeset, run yarn changeset and follow the prompts
  • The changes are covered by relevant tests
  • I have verified the code works as intended locally
  • I have linked the related issue(s) if applicable

Additional Context

Add any additional context, related issues, or references that might help the reviewer understand this PR.

fixes #14736

@NicolasGorga NicolasGorga requested a review from a team as a code owner February 14, 2026 01:53
@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Feb 14, 2026

🦋 Changeset detected

Latest commit: daa0a93

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 77 packages
Name Type
@medusajs/dashboard Patch
@medusajs/product Patch
@medusajs/admin-bundler Patch
@medusajs/medusa Patch
integration-tests-http Patch
@medusajs/test-utils Patch
@medusajs/medusa-oas-cli Patch
@medusajs/analytics Patch
@medusajs/api-key Patch
@medusajs/auth Patch
@medusajs/caching Patch
@medusajs/cart Patch
@medusajs/currency Patch
@medusajs/customer Patch
@medusajs/file Patch
@medusajs/fulfillment Patch
@medusajs/index Patch
@medusajs/inventory Patch
@medusajs/link-modules Patch
@medusajs/locking Patch
@medusajs/notification Patch
@medusajs/order Patch
@medusajs/payment Patch
@medusajs/pricing Patch
@medusajs/promotion Patch
@medusajs/rbac Patch
@medusajs/region Patch
@medusajs/sales-channel Patch
@medusajs/settings Patch
@medusajs/stock-location Patch
@medusajs/store Patch
@medusajs/tax Patch
@medusajs/translation Patch
@medusajs/user Patch
@medusajs/workflow-engine-inmemory Patch
@medusajs/workflow-engine-redis Patch
@medusajs/draft-order Patch
@medusajs/oas-github-ci Patch
@medusajs/cache-inmemory Patch
@medusajs/cache-redis Patch
@medusajs/event-bus-local Patch
@medusajs/event-bus-redis Patch
@medusajs/analytics-local Patch
@medusajs/analytics-posthog Patch
@medusajs/auth-emailpass Patch
@medusajs/auth-github Patch
@medusajs/auth-google Patch
@medusajs/caching-redis Patch
@medusajs/file-local Patch
@medusajs/file-s3 Patch
@medusajs/fulfillment-manual Patch
@medusajs/locking-postgres Patch
@medusajs/locking-redis Patch
@medusajs/notification-local Patch
@medusajs/notification-sendgrid Patch
@medusajs/payment-stripe Patch
@medusajs/core-flows Patch
@medusajs/framework Patch
@medusajs/js-sdk Patch
@medusajs/modules-sdk Patch
@medusajs/orchestration Patch
@medusajs/types Patch
@medusajs/utils Patch
@medusajs/workflows-sdk Patch
@medusajs/http-types-generator Patch
@medusajs/cli Patch
@medusajs/deps Patch
@medusajs/telemetry Patch
@medusajs/admin-sdk Patch
@medusajs/admin-shared Patch
@medusajs/admin-vite-plugin Patch
@medusajs/icons Patch
@medusajs/toolbox Patch
@medusajs/ui-preset Patch
create-medusa-app Patch
medusa-dev-cli Patch
@medusajs/ui Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link
Copy Markdown

vercel bot commented Feb 14, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

9 Skipped Deployments
Project Deployment Actions Updated (UTC)
api-reference Ignored Ignored Apr 10, 2026 7:58pm
api-reference-v2 Ignored Ignored Preview Apr 10, 2026 7:58pm
bloom-docs Ignored Ignored Preview Apr 10, 2026 7:58pm
cloud-docs Ignored Ignored Preview Apr 10, 2026 7:58pm
docs-ui Ignored Ignored Preview Apr 10, 2026 7:58pm
docs-v2 Ignored Ignored Preview Apr 10, 2026 7:58pm
medusa-docs Ignored Ignored Preview Apr 10, 2026 7:58pm
resources-docs Ignored Ignored Preview Apr 10, 2026 7:58pm
user-guide Ignored Ignored Preview Apr 10, 2026 7:58pm

Request Review

@medusa-os-bot
Copy link
Copy Markdown

medusa-os-bot bot commented Apr 9, 2026

Thank you for your contribution!

After reviewing this PR, we need a few things addressed before we can move forward:

Required changes:

  • packages/admin/dashboard/src/routes/products/product-create/constants.tsProductCreateVariantSchema still uses optionalInt for weight, height, width, and length (lines 22–25). These should be updated to optionalFloat to match the new decimal database type. The PR updates the edit-variant form correctly but misses this schema, leaving it inconsistent with the new data model.

Notes:

  • The migration changes product columns from TEXT to a float type — please verify that the migration includes an explicit USING column::real cast clause (or equivalent) to handle the text-to-float coercion for existing data. A missing USING clause will cause the migration to fail on instances with existing product data.

@NicolasGorga
Copy link
Copy Markdown
Contributor Author

Notes:

  • The migration changes product columns from TEXT to a float type — please verify that the migration includes an explicit USING column::real cast clause (or equivalent) to handle the text-to-float coercion for existing data. A missing USING clause will cause the migration to fail on instances with existing product data.

Yes this is already covered

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Incorrect product DTO

1 participant