You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
This PR includes no changesets
When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types
After an initial review, this PR looks good to us. Here's a summary:
✅ Follows contribution guidelines
✅ New changelog page has a corresponding sidebar entry
✅ Generated files (sidebar, edit-dates) updated correctly
✅ Existing tests present for the modified ContentMenu/Toc component
Notes:
www/packages/docs-ui/src/components/ContentMenu/Toc/index.tsx was modified (+6/-1) but the test file wasn't updated. If the new behavior (e.g. a new frontmatter-controlled early return) isn't covered by the existing test cases, a test for the new branch would be good to add.
A team member will do a final review before this is merged. We appreciate your patience!
Keeping branch in case we want to get back to this
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add new changelog page to showcase bloom features
Closes DX-2555