Skip to content

chore: fix http types not matching validators#15017

Open
shahednasser wants to merge 9 commits intodevelopfrom
fix/http-types
Open

chore: fix http types not matching validators#15017
shahednasser wants to merge 9 commits intodevelopfrom
fix/http-types

Conversation

@shahednasser
Copy link
Copy Markdown
Member

Use the http-types-generator to fix http types not matching Zod validators

@shahednasser shahednasser requested a review from a team as a code owner April 6, 2026 10:22
@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Apr 6, 2026

🦋 Changeset detected

Latest commit: 00ba651

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 77 packages
Name Type
@medusajs/http-types-generator Patch
@medusajs/types Patch
@medusajs/medusa Patch
@medusajs/event-bus-redis Patch
@medusajs/draft-order Patch
@medusajs/framework Patch
@medusajs/js-sdk Patch
@medusajs/modules-sdk Patch
@medusajs/orchestration Patch
@medusajs/utils Patch
@medusajs/workflows-sdk Patch
@medusajs/medusa-oas-cli Patch
@medusajs/admin-bundler Patch
@medusajs/dashboard Patch
integration-tests-http Patch
@medusajs/test-utils Patch
@medusajs/analytics Patch
@medusajs/api-key Patch
@medusajs/auth Patch
@medusajs/cache-inmemory Patch
@medusajs/cache-redis Patch
@medusajs/caching Patch
@medusajs/cart Patch
@medusajs/currency Patch
@medusajs/customer Patch
@medusajs/event-bus-local Patch
@medusajs/file Patch
@medusajs/fulfillment Patch
@medusajs/index Patch
@medusajs/inventory Patch
@medusajs/link-modules Patch
@medusajs/locking Patch
@medusajs/notification Patch
@medusajs/order Patch
@medusajs/payment Patch
@medusajs/pricing Patch
@medusajs/product Patch
@medusajs/promotion Patch
@medusajs/rbac Patch
@medusajs/region Patch
@medusajs/sales-channel Patch
@medusajs/settings Patch
@medusajs/stock-location Patch
@medusajs/store Patch
@medusajs/tax Patch
@medusajs/translation Patch
@medusajs/user Patch
@medusajs/workflow-engine-inmemory Patch
@medusajs/workflow-engine-redis Patch
@medusajs/analytics-local Patch
@medusajs/analytics-posthog Patch
@medusajs/auth-emailpass Patch
@medusajs/auth-github Patch
@medusajs/auth-google Patch
@medusajs/caching-redis Patch
@medusajs/file-local Patch
@medusajs/file-s3 Patch
@medusajs/fulfillment-manual Patch
@medusajs/locking-postgres Patch
@medusajs/locking-redis Patch
@medusajs/notification-local Patch
@medusajs/notification-sendgrid Patch
@medusajs/payment-stripe Patch
@medusajs/core-flows Patch
@medusajs/oas-github-ci Patch
@medusajs/cli Patch
@medusajs/deps Patch
@medusajs/telemetry Patch
@medusajs/admin-sdk Patch
@medusajs/admin-shared Patch
@medusajs/admin-vite-plugin Patch
@medusajs/icons Patch
@medusajs/toolbox Patch
@medusajs/ui-preset Patch
create-medusa-app Patch
medusa-dev-cli Patch
@medusajs/ui Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link
Copy Markdown

vercel bot commented Apr 6, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

9 Skipped Deployments
Project Deployment Actions Updated (UTC)
api-reference Ignored Ignored Apr 9, 2026 7:08am
api-reference-v2 Ignored Ignored Preview Apr 9, 2026 7:08am
bloom-docs Ignored Ignored Preview Apr 9, 2026 7:08am
cloud-docs Ignored Ignored Preview Apr 9, 2026 7:08am
docs-ui Ignored Ignored Preview Apr 9, 2026 7:08am
docs-v2 Ignored Ignored Preview Apr 9, 2026 7:08am
medusa-docs Ignored Ignored Preview Apr 9, 2026 7:08am
resources-docs Ignored Ignored Preview Apr 9, 2026 7:08am
user-guide Ignored Ignored Preview Apr 9, 2026 7:08am

Request Review

@shahednasser
Copy link
Copy Markdown
Member Author

@medusabot review

@claude
Copy link
Copy Markdown

claude bot commented Apr 9, 2026

Thank you for your contribution! 🎉

After an initial review, this PR looks good to us. Here's a summary:

✅ Follows contribution guidelines
✅ Tests included (file-merger, name-registry, and type-pipeline specs updated/added)
✅ Changeset included
✅ Follows Medusa's conventions

A team member will do a final review before this is merged. We appreciate your patience!

Notes:

  • packages/core/types/src/http/inventory-level/index.ts is not modified in this PR, but all files under inventory-level/admin/ are deleted. Since the tsconfig includes all files under src/, TypeScript will still try to compile inventory-level/index.ts (which has export * from "./admin") even if the main index.ts removes the ./inventory-level re-export. Worth double-checking that either inventory-level/index.ts is also deleted or its content is cleared to avoid a stale broken import.

@shahednasser
Copy link
Copy Markdown
Member Author

@medusajs-bot review

@medusa-os-bot
Copy link
Copy Markdown

medusa-os-bot bot commented Apr 9, 2026

After an initial review, this PR looks good to us. Here's a summary:

✅ Follows contribution guidelines
✅ Tests included (file-merger, name-registry, and type-pipeline specs updated/added)
✅ Changeset included
✅ Follows Medusa's conventions

A team member will do a final review before this is merged.

Notes:

  • packages/core/types/src/http/inventory-level/index.ts is not modified or deleted in this PR, but all files under inventory-level/admin/ are deleted. The package tsconfig includes all files under src/ — so TypeScript will still compile inventory-level/index.ts (which has export * from "./admin") even after its target is gone, causing a module resolution error at build time. This file should either be deleted or emptied before merging.

@shahednasser
Copy link
Copy Markdown
Member Author

@medusajs-bot review

@medusa-os-bot
Copy link
Copy Markdown

medusa-os-bot bot commented Apr 9, 2026

The packages/core/types/src/http/inventory-level/index.ts concern from the previous review is still unresolved — the file still exports export * from "./admin", but all files under admin/ are deleted by this PR. This will cause a module resolution error at build time.

Required changes:

  • Delete or clear packages/core/types/src/http/inventory-level/index.ts (and the parent inventory-level/index.ts if applicable)

@medusa-os-bot
Copy link
Copy Markdown

medusa-os-bot bot commented Apr 9, 2026

The inventory-level/index.ts issue from previous reviews is still unresolved.

packages/core/types/src/http/inventory-level/index.ts still contains:

export * from "./admin"

But all files under inventory-level/admin/ are deleted by this PR. This will cause a module resolution error at build time.

Required changes:

  • Delete packages/core/types/src/http/inventory-level/index.ts (and the parent inventory-level/ directory if it becomes empty)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant