silence warning: thermopro_tp862b.c:78 - b[7] == ~b[8] causes sign-compare warning due to integer promotion of ~ on unsigned

merbanan · merbanan · commit 5e46ac42caa4 · 2026-04-03T22:19:30.000+02:00
diff --git a/src/devices/thermopro_tp862b.c b/src/devices/thermopro_tp862b.c
@@ -75,7 +75,7 @@ static int thermopro_tp862b_decode(r_device *decoder, bitbuffer_t *bitbuffer)
     bitbuffer_extract_bytes(bitbuffer, 0, offset, b, 9 * 8);
 
     // Validate Checksum format. Byte 7 must be equal to byte 8 inverted.
-    if (b[7] == ~b[8]) {
+    if (b[7] == (uint8_t)~b[8]) {
         decoder_logf(decoder, 2, __func__, "Checksum byte 7 is supposed to be equal to byte 8 inverted. Actual: %02x vs %02x (inverted %02x)", b[7], b[8], ~b[8]);
         return DECODE_FAIL_MIC;
     }

Original file line number	Diff line number	Diff line change
`@@ -75,7 +75,7 @@ static int thermopro_tp862b_decode(r_device decoder, bitbuffer_t bitbuffer)`
`75`	`75`	`bitbuffer_extract_bytes(bitbuffer, 0, offset, b, 9 * 8);`
`76`	`76`
`77`	`77`	`// Validate Checksum format. Byte 7 must be equal to byte 8 inverted.`
`78`		`- if (b[7] == ~b[8]) {`
	`78`	`+ if (b[7] == (uint8_t)~b[8]) {`
`79`	`79`	`decoder_logf(decoder, 2, __func__, "Checksum byte 7 is supposed to be equal to byte 8 inverted. Actual: %02x vs %02x (inverted %02x)", b[7], b[8], ~b[8]);`
`80`	`80`	`return DECODE_FAIL_MIC;`
`81`	`81`	`}`