Skip to content

Commit 03bb2d1

Browse files
committed
fix api crash and add regression test
1 parent 9d46620 commit 03bb2d1

2 files changed

Lines changed: 10 additions & 3 deletions

File tree

democrasite/users/api/views.py

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -25,9 +25,7 @@ class UserViewSet(RetrieveModelMixin, ListModelMixin, UpdateModelMixin, GenericV
2525
lookup_field = "username"
2626

2727
def get_queryset(self, *args, **kwargs):
28-
user_id = self.request.user.id
29-
assert user_id is not None
30-
return self.queryset.filter(id=user_id)
28+
return self.queryset.filter(id=self.request.user.id)
3129

3230
@action(detail=False)
3331
def me(self, request):

democrasite/users/tests/api/test_views.py

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
import pytest
2+
from django.contrib.auth.models import AnonymousUser
23
from rest_framework.test import APIRequestFactory
34

45
from democrasite.users.api.views import UserViewSet
@@ -20,6 +21,14 @@ def test_get_queryset(
2021

2122
assert user in view.get_queryset()
2223

24+
def test_logged_out(self, api_rf: APIRequestFactory, view: UserViewSet):
25+
request = api_rf.get("/fake-url/")
26+
request.user = AnonymousUser()
27+
28+
view.request = request
29+
30+
assert not view.get_queryset()
31+
2332
def test_me(self, api_rf: APIRequestFactory, user: User, view: UserViewSet):
2433
request = api_rf.get("/fake-url/")
2534
request.user = user

0 commit comments

Comments
 (0)