Skip to content

Commit 0c92361

Browse files
committed
Slightly simplify bill detail view logic
1 parent aa448d6 commit 0c92361

1 file changed

Lines changed: 6 additions & 8 deletions

File tree

democrasite/webiscite/views.py

Lines changed: 6 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66
from django.contrib.auth.mixins import LoginRequiredMixin
77
from django.contrib.auth.mixins import UserPassesTestMixin
88
from django.contrib.messages.views import SuccessMessageMixin
9-
from django.http import Http404
9+
from django.shortcuts import get_object_or_404
1010
from django.utils.translation import gettext_lazy as _
1111
from django.views.decorators.http import require_POST
1212
from django.views.generic import DetailView
@@ -96,13 +96,11 @@ class BillDetailView(DetailView):
9696
def get_object(self, queryset=None):
9797
pk = self.kwargs.get("pk")
9898

99-
try:
100-
if self.request.user.is_authenticated:
101-
return Bill.objects.annotate_user_vote(self.request.user).get(pk=pk)
102-
return Bill.objects.get(pk=pk)
103-
104-
except Bill.DoesNotExist as err:
105-
raise Http404(_("No Bills found matching query")) from err
99+
if self.request.user.is_authenticated:
100+
return get_object_or_404(
101+
Bill.objects.annotate_user_vote(self.request.user), pk=pk
102+
)
103+
return get_object_or_404(Bill)
106104

107105

108106
bill_detail_view = BillDetailView.as_view()

0 commit comments

Comments
 (0)