Move phpstan_fixtures test data to tests/src/Rules/data (#974)

* Move phpstan_fixtures test data to tests/src/Rules/data

Moves rule test data files out of the phpstan_fixtures Drupal module
fixture and into the standard tests/src/Rules/data/ directory, keeping
test data co-located with the tests that use it.

Also removes dead fixture files that were no longer referenced by any
test (AppRootParameter, DeprecatedGlobalConstants, EntityFieldReflection,
EntityQueryHasAccessRule).

Refs #723

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

* Add unit test for SplString pseudo-service type resolution

Replaces the coverage that was lost when AppRootParameter.php was removed.
DrupalServiceDefinition::getType() maps SplString to StringType to handle
Drupal pseudo-services like 'app.root' which are strings injected into the
container rather than real objects.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

* Register app.root as a synthetic SplString service in DrupalAutoloader

app.root is set programmatically by DrupalKernel::initializeContainer() as
a synthetic SplString service (not defined in any services.yml). The
DrupalAutoloader already hardcodes other synthetic services like kernel,
class_loader, and service_container — app.root belongs in the same block.

This makes the existing SplString → StringType mapping in
DrupalServiceDefinition::getType() reachable, and lets type assertions on
\Drupal::getContainer()->get('app.root') resolve to string.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

* Remove dead SplString pseudo-service handling

app.root is a container parameter in Drupal, not a service. The SplString
workaround in DrupalServiceDefinition::getType() was never reachable
because nothing registered app.root as a service with class SplString.
AppRootParameter.php was already removed as part of dead code cleanup.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

---------

Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>

Author: mglaman

src/Drupal/DrupalServiceDefinition.php

@@ -3,7 +3,6 @@
 namespace mglaman\PHPStanDrupal\Drupal;
 
 use PHPStan\Type\ObjectType;
-use PHPStan\Type\StringType;
 use PHPStan\Type\Type;
 use PHPStan\Type\TypeCombinator;
 use function count;
@@ -110,13 +109,6 @@ public function getDeprecatedDescription(): string
 
     public function getType(): Type
     {
-        // Work around Drupal misusing the SplString class for string
-        // pseudo-services such as 'app.root'.
-        // @see https://www.drupal.org/project/drupal/issues/3074585
-        if ($this->getClass() === 'SplString') {
-            return new StringType();
-        }
-
         $decorating_services = $this->getDecorators();
         if (count($decorating_services) !== 0) {
             $combined_services = [];

tests/fixtures/drupal/modules/phpstan_fixtures/src/AppRootParameter.php

@@ -27,7 +27,7 @@ public function testConfigExportRuleCheck(string $path, array $errorMessages): v
     public static function pluginData(): \Generator
     {
         yield [
-            __DIR__ . '/../../fixtures/drupal/modules/phpstan_fixtures/src/Entity/ConfigWithoutExport.php',
+            __DIR__ . '/data/config-entity-without-export.php',
             [
                [
                    'Configuration entity must define a `config_export` key. See https://www.drupal.org/node/2481909',
@@ -36,7 +36,7 @@ public static function pluginData(): \Generator
             ]
         ];
         yield [
-            __DIR__ . '/../../fixtures/drupal/modules/phpstan_fixtures/src/Entity/ConfigWithExport.php',
+            __DIR__ . '/data/config-entity-with-export.php',
             []
         ];
     }

tests/fixtures/drupal/modules/phpstan_fixtures/src/DeprecatedGlobalConstants.php

@@ -27,21 +27,21 @@ public function test(array $files, array $errors): void
     public static function cases(): \Generator
     {
         yield [
-            [__DIR__.'/../../fixtures/drupal/modules/phpstan_fixtures/src/EntityQueryWithAccessRule.php'],
+            [__DIR__.'/data/entity-query-access-check-valid.php'],
             [],
         ];
 
         yield [
-            [__DIR__.'/../../fixtures/drupal/modules/phpstan_fixtures/src/EntityQueryWithoutAccessRule.php'],
+            [__DIR__.'/data/entity-query-access-check-invalid.php'],
             [
                 [
                     'Relying on entity queries to check access by default is deprecated in drupal:9.2.0 and an error will be thrown from drupal:10.0.0. Call \Drupal\Core\Entity\Query\QueryInterface::accessCheck() with TRUE or FALSE to specify whether access should be checked.',
-                    11,
+                    9,
                     'See https://www.drupal.org/node/3201242',
                 ],
                 [
                     'Relying on entity queries to check access by default is deprecated in drupal:9.2.0 and an error will be thrown from drupal:10.0.0. Call \Drupal\Core\Entity\Query\QueryInterface::accessCheck() with TRUE or FALSE to specify whether access should be checked.',
-                    19,
+                    17,
                     'See https://www.drupal.org/node/3201242',
                 ],
             ],

tests/fixtures/drupal/modules/phpstan_fixtures/src/EntityFieldReflection/EntityFieldMagicalGetters.php

@@ -29,7 +29,7 @@ public static function resultData(): \Generator
             [],
         ];
         yield [
-            __DIR__ . '/../../fixtures/drupal/modules/phpstan_fixtures/src/UsesDeprecatedUrlFunction.php',
+            __DIR__ . '/data/global-drupal-di-deprecated-url.php',
             [
                 [
                     '\Drupal calls should be avoided in classes, use dependency injection instead',
@@ -38,7 +38,7 @@ public static function resultData(): \Generator
             ]
         ];
         yield [
-            __DIR__ . '/../../fixtures/drupal/modules/phpstan_fixtures/src/TestServicesMappingExtension.php',
+            __DIR__ . '/data/global-drupal-di-service-mapping.php',
             [
                 [
                     '\Drupal calls should be avoided in classes, use dependency injection instead',

tests/fixtures/drupal/modules/phpstan_fixtures/src/EntityFieldReflection/EntityFieldOriginalProperty.php

@@ -26,12 +26,12 @@ public static function cases(): \Generator
     {
         yield [
             [
-                __DIR__ . '/../../fixtures/drupal/modules/phpstan_fixtures/phpstan_fixtures.module'
+                __DIR__ . '/data/load-include-invalid.php'
             ],
             [
                 [
                     'File modules/phpstan_fixtures/phpstan_fixtures.fetch.inc could not be loaded from Drupal\Core\Extension\ModuleHandlerInterface::loadInclude',
-                    25,
+                    5,
                 ]
             ],
         ];