Skip to content

Commit 310e6b5

Browse files
cpcloudclaude
andauthored
fix(ci): revert to non-draft releases to preserve release notes (#719)
## Summary - GoReleaser's `keep-existing` mode wipes the release body on draft releases, replacing semantic-release's notes with an empty body - Revert to non-draft releases: semantic-release creates a published release with notes, `release: [created]` fires, GoReleaser adds artifacts without touching the body - Remove the `workflow_call` plumbing from CI (no longer needed) - Keep `workflow_dispatch` for manual re-releases closes #715 Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
1 parent cbf0f60 commit 310e6b5

3 files changed

Lines changed: 3 additions & 45 deletions

File tree

.github/workflows/ci.yml

Lines changed: 0 additions & 26 deletions
Original file line numberDiff line numberDiff line change
@@ -203,8 +203,6 @@ jobs:
203203
cancel-in-progress: ${{ github.event_name == 'pull_request' }}
204204
permissions:
205205
contents: write
206-
outputs:
207-
tag: ${{ steps.release-check.outputs.tag }}
208206
steps:
209207
- name: Generate app token
210208
id: app-token
@@ -225,31 +223,7 @@ jobs:
225223
- name: Install semantic-release
226224
run: npm install -g semantic-release@25.0.3 @semantic-release/exec@7.1.0 @semantic-release/git@10.0.1
227225

228-
- name: Save pre-release version
229-
id: pre
230-
run: echo "version=$(cat VERSION 2>/dev/null)" >> "$GITHUB_OUTPUT"
231-
232226
- name: Run semantic-release
233227
run: npx semantic-release ${{ github.event_name == 'pull_request' && '--dry-run' || '' }}
234228
env:
235229
GITHUB_TOKEN: ${{ steps.app-token.outputs.token }}
236-
237-
- name: Check for new release
238-
id: release-check
239-
run: |
240-
NEW_VERSION=$(cat VERSION)
241-
if [ "$NEW_VERSION" != "${{ steps.pre.outputs.version }}" ]; then
242-
echo "tag=v${NEW_VERSION}" >> "$GITHUB_OUTPUT"
243-
fi
244-
245-
release:
246-
name: Release Artifacts
247-
needs: [semantic-release]
248-
if: needs.semantic-release.outputs.tag != ''
249-
permissions:
250-
contents: write
251-
packages: write
252-
uses: ./.github/workflows/release.yml
253-
with:
254-
tag: ${{ needs.semantic-release.outputs.tag }}
255-
secrets: inherit

.github/workflows/release.yml

Lines changed: 3 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -4,18 +4,8 @@
44
name: Release Artifacts
55

66
on:
7-
workflow_call:
8-
inputs:
9-
tag:
10-
description: "Release tag (e.g. v1.75.0)"
11-
required: true
12-
type: string
13-
workflow_dispatch:
14-
inputs:
15-
tag:
16-
description: "Release tag (e.g. v1.75.0)"
17-
required: true
18-
type: string
7+
release:
8+
types: [published]
199

2010
concurrency:
2111
group: release-artifacts
@@ -37,7 +27,7 @@ jobs:
3727
steps:
3828
- uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6
3929
with:
40-
ref: ${{ inputs.tag }}
30+
ref: ${{ github.event.release.tag_name }}
4131
fetch-depth: 0
4232
persist-credentials: false
4333

@@ -62,11 +52,6 @@ jobs:
6252
env:
6353
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
6454

65-
- name: Publish release
66-
env:
67-
GH_TOKEN: ${{ secrets.GITHUB_TOKEN }}
68-
run: gh release edit "${{ inputs.tag }}" --draft=false
69-
7055
- name: Clean up untagged GHCR images
7156
env:
7257
GH_TOKEN: ${{ secrets.GITHUB_TOKEN }}

.releaserc.json

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,6 @@
1111
"message": "chore(release): ${nextRelease.version} [skip ci]"
1212
}],
1313
["@semantic-release/github", {
14-
"draftRelease": true,
1514
"successComment": false,
1615
"failComment": false
1716
}]

0 commit comments

Comments
 (0)