refactor: drop trivial helpers, use new(v) and data.DateLayout (#958)

## Summary

- Remove `fmtIntAlways` and `fmtSize` wrappers in `cmd/micasa/show.go`;
inline `strconv.Itoa` / `strconv.FormatInt` at call sites.
- Collapse `if val { return "true" } return "false"` in `ops_tree.go` to
`strconv.FormatBool`.
- Delete `ptr[T any]` test helpers in `internal/data` and `internal/app`
in favor of Go 1.26's `new(v)` builtin; deduplicate scattered `ptr` /
`ptrTime` closures in `dashboard_test.go` into one package-level
`ptrTime`.
- Have `fmtMoney` delegate to `fmtMoneyVal` instead of duplicating the
format string.
- Replace hardcoded `"2006-01-02"` literals with the existing
`data.DateLayout` constant where the same package already used it.
- Inline `jn()` test helper in `internal/extract/shadow_test.go`; call
sites read the same as `json.Number(...)` without the indirection.

Author: cpcloud

cmd/micasa/show.go

@@ -24,7 +24,7 @@ func fmtMoney(cents *int64) string {
 	if cents == nil {
 		return "-"
 	}
-	return fmt.Sprintf("$%.2f", float64(*cents)/100)
+	return fmtMoneyVal(*cents)
 }
 
 func fmtDate(t *time.Time) string {
@@ -41,10 +41,6 @@ func fmtInt(n int) string {
 	return strconv.Itoa(n)
 }
 
-func fmtIntAlways(n int) string {
-	return strconv.Itoa(n)
-}
-
 func fmtFloat(f float64) string {
 	if f == 0 {
 		return "-"
@@ -130,7 +126,7 @@ func fmtDateVal(t time.Time) string {
 	if t.IsZero() {
 		return "-"
 	}
-	return t.Format("2006-01-02")
+	return t.Format(data.DateLayout)
 }
 
 // withDeletedCol appends a DELETED column and deleted_at JSON field when includeDeleted is true.
@@ -150,7 +146,7 @@ func withDeletedCol[T any](
 		value: func(item T) string {
 			da := deletedAt(item)
 			if da.Valid {
-				return da.Time.Format("2006-01-02")
+				return da.Time.Format(data.DateLayout)
 			}
 			return "-"
 		},
@@ -602,7 +598,7 @@ var maintenanceCols = []showCol[data.MaintenanceItem]{
 	{"APPLIANCE", func(m data.MaintenanceItem) string { return fmtStr(m.Appliance.Name) }},
 	{"SEASON", func(m data.MaintenanceItem) string { return fmtStr(m.Season) }},
 	{"LAST SERVICED", func(m data.MaintenanceItem) string { return fmtDate(m.LastServicedAt) }},
-	{"INTERVAL", func(m data.MaintenanceItem) string { return fmtIntAlways(m.IntervalMonths) }},
+	{"INTERVAL", func(m data.MaintenanceItem) string { return strconv.Itoa(m.IntervalMonths) }},
 	{"DUE", func(m data.MaintenanceItem) string { return fmtDate(m.DueDate) }},
 	{"COST", func(m data.MaintenanceItem) string { return fmtMoney(m.CostCents) }},
 }
@@ -669,16 +665,12 @@ func showServiceLog(w io.Writer, store *data.Store, asJSON, includeDeleted bool)
 
 // --- documents ---
 
-func fmtSize(n int64) string {
-	return strconv.FormatInt(n, 10)
-}
-
 var documentCols = []showCol[data.Document]{
 	{"TITLE", func(d data.Document) string { return fmtStr(d.Title) }},
 	{"FILE", func(d data.Document) string { return fmtStr(d.FileName) }},
 	{"ENTITY", func(d data.Document) string { return fmtStr(d.EntityKind) }},
 	{"MIME", func(d data.Document) string { return fmtStr(d.MIMEType) }},
-	{"SIZE", func(d data.Document) string { return fmtSize(d.SizeBytes) }},
+	{"SIZE", func(d data.Document) string { return strconv.FormatInt(d.SizeBytes, 10) }},
 	{"NOTES", func(d data.Document) string { return fmtStr(d.Notes) }},
 }
 

internal/app/calendar_test.go

@@ -12,6 +12,8 @@ import (
 	"github.com/charmbracelet/x/ansi"
 	"github.com/stretchr/testify/assert"
 	"github.com/stretchr/testify/require"
+
+	"github.com/micasa-dev/micasa/internal/data"
 )
 
 const testDate = "2026-02-15"
@@ -396,7 +398,7 @@ func TestCalendarTodayKeyNavigation(t *testing.T) {
 	sendKey(m, "enter")
 	assert.True(t, confirmed, "OnConfirm should have been called")
 	assert.Nil(t, m.calendar, "calendar should be dismissed")
-	assert.Equal(t, now.Format("2006-01-02"), dateVal,
+	assert.Equal(t, now.Format(data.DateLayout), dateVal,
 		"confirmed date should be today")
 }
 

internal/app/handler_crud_test.go

@@ -643,7 +643,7 @@ func TestIncidentHandlerLoadDeleteRestoreRoundTrip(t *testing.T) {
 		Title:       "Broken window",
 		Status:      data.IncidentStatusOpen,
 		Severity:    data.IncidentSeverityUrgent,
-		DateNoticed: time.Now().Format("2006-01-02"),
+		DateNoticed: time.Now().Format(data.DateLayout),
 	}
 	require.NoError(t, h.SubmitForm(m))
 

internal/app/model_keys.go

@@ -16,6 +16,8 @@ import (
 	"charm.land/bubbles/v2/key"
 	tea "charm.land/bubbletea/v2"
 	"charm.land/lipgloss/v2"
+
+	"github.com/micasa-dev/micasa/internal/data"
 )
 
 // handleDashboardKeys intercepts keys that belong to the dashboard (j/k
@@ -539,7 +541,7 @@ func (m *Model) confirmCalendar() {
 	if m.calendar == nil {
 		return
 	}
-	dateStr := m.calendar.Cursor.Format("2006-01-02")
+	dateStr := m.calendar.Cursor.Format(data.DateLayout)
 	if m.calendar.FieldPtr != nil {
 		*m.calendar.FieldPtr = dateStr
 	}
@@ -555,7 +557,7 @@ func (m *Model) openCalendar(fieldPtr *string, onConfirm func()) {
 	var selected time.Time
 	hasValue := false
 	if fieldPtr != nil && *fieldPtr != "" {
-		if t, err := time.ParseInLocation("2006-01-02", *fieldPtr, time.Local); err == nil {
+		if t, err := time.ParseInLocation(data.DateLayout, *fieldPtr, time.Local); err == nil {
 			cursor = t
 			selected = t
 			hasValue = true

internal/app/ops_tree.go

@@ -632,10 +632,7 @@ func classifyValue(v any) (string, treeValueKind) {
 		}
 		return fmt.Sprintf("%g", val), tvNumber
 	case bool:
-		if val {
-			return "true", tvBool
-		}
-		return "false", tvBool
+		return strconv.FormatBool(val), tvBool
 	case nil:
 		return "null", tvNull
 	default:

internal/app/view_test.go

@@ -591,27 +591,27 @@ func TestApplianceAge(t *testing.T) {
 		{"nil purchase", nil, ""},
 		{
 			"less than a month",
-			ptr(time.Date(2026, 1, 20, 0, 0, 0, 0, time.UTC)),
+			new(time.Date(2026, 1, 20, 0, 0, 0, 0, time.UTC)),
 			"<1m",
 		},
 		{
 			"a few months",
-			ptr(time.Date(2025, 10, 5, 0, 0, 0, 0, time.UTC)),
+			new(time.Date(2025, 10, 5, 0, 0, 0, 0, time.UTC)),
 			"4m",
 		},
 		{
 			"one year exact",
-			ptr(time.Date(2025, 2, 10, 0, 0, 0, 0, time.UTC)),
+			new(time.Date(2025, 2, 10, 0, 0, 0, 0, time.UTC)),
 			"1y",
 		},
 		{
 			"years and months",
-			ptr(time.Date(2023, 6, 15, 0, 0, 0, 0, time.UTC)),
+			new(time.Date(2023, 6, 15, 0, 0, 0, 0, time.UTC)),
 			"2y 7m",
 		},
 		{
 			"future date",
-			ptr(time.Date(2027, 1, 1, 0, 0, 0, 0, time.UTC)),
+			new(time.Date(2027, 1, 1, 0, 0, 0, 0, time.UTC)),
 			"",
 		},
 	}
@@ -622,12 +622,6 @@ func TestApplianceAge(t *testing.T) {
 	}
 }
 
-func ptr[T any](
-	v T,
-) *T {
-	return &v
-}
-
 func TestNavBadgeLabel(t *testing.T) {
 	t.Parallel()
 	m := newTestModel(t)

internal/data/dashboard_test.go

@@ -17,10 +17,6 @@ func TestListMaintenanceWithSchedule(t *testing.T) {
 	cat := MaintenanceCategory{Name: "TestCat"}
 	require.NoError(t, store.db.Create(&cat).Error)
 
-	ptrTime := func(y, m, d int) *time.Time {
-		t := time.Date(y, time.Month(m), d, 0, 0, 0, 0, time.UTC)
-		return &t
-	}
 	// Item with interval > 0 should appear.
 	require.NoError(t, store.db.Create(&MaintenanceItem{
 		Name: "With Interval", CategoryID: cat.ID,
@@ -43,10 +39,6 @@ func TestListMaintenanceWithScheduleDueDate(t *testing.T) {
 	cat := MaintenanceCategory{Name: "DueDateCat"}
 	require.NoError(t, store.db.Create(&cat).Error)
 
-	ptrTime := func(y, m, d int) *time.Time {
-		t := time.Date(y, time.Month(m), d, 0, 0, 0, 0, time.UTC)
-		return &t
-	}
 	// Item with due date (no interval) should appear.
 	require.NoError(t, store.db.Create(&MaintenanceItem{
 		Name: "With DueDate", CategoryID: cat.ID,
@@ -204,10 +196,6 @@ func TestListExpiringWarranties(t *testing.T) {
 	t.Parallel()
 	store := newTestStore(t)
 	now := time.Date(2026, 2, 8, 0, 0, 0, 0, time.UTC)
-	ptrTime := func(y, m, d int) *time.Time {
-		t := time.Date(y, time.Month(m), d, 0, 0, 0, 0, time.UTC)
-		return &t
-	}
 	// Expiring in 30 days -- should appear.
 	require.NoError(
 		t,
@@ -261,7 +249,6 @@ func TestListRecentServiceLogs(t *testing.T) {
 func TestYTDSpending(t *testing.T) {
 	t.Parallel()
 	store := newTestStore(t)
-	ptr := func(v int64) *int64 { return &v }
 
 	cat := MaintenanceCategory{Name: "SpendCat"}
 	require.NoError(t, store.db.Create(&cat).Error)
@@ -272,13 +259,13 @@ func TestYTDSpending(t *testing.T) {
 	require.NoError(t, store.db.Create(&ServiceLogEntry{
 		MaintenanceItemID: item.ID,
 		ServicedAt:        time.Date(2026, 1, 15, 0, 0, 0, 0, time.UTC),
-		CostCents:         ptr(5000),
+		CostCents:         new(int64(5000)),
 	}).Error)
 	// Last year -- should not count.
 	require.NoError(t, store.db.Create(&ServiceLogEntry{
 		MaintenanceItemID: item.ID,
 		ServicedAt:        time.Date(2025, 12, 1, 0, 0, 0, 0, time.UTC),
-		CostCents:         ptr(9999),
+		CostCents:         new(int64(9999)),
 	}).Error)
 
 	yearStart := time.Date(2026, 1, 1, 0, 0, 0, 0, time.UTC)
@@ -292,16 +279,16 @@ func TestYTDSpending(t *testing.T) {
 	require.NoError(t, store.db.First(&pt).Error)
 	require.NoError(t, store.db.Create(&Project{
 		Title: "P1", ProjectTypeID: pt.ID, Status: ProjectStatusCompleted,
-		ActualCents: ptr(20000),
+		ActualCents: new(int64(20000)),
 	}).Error)
 	require.NoError(t, store.db.Create(&Project{
 		Title: "P2", ProjectTypeID: pt.ID, Status: ProjectStatusInProgress,
-		ActualCents: ptr(10000),
+		ActualCents: new(int64(10000)),
 	}).Error)
 	// Project updated last year — still included (no date filter).
 	oldProj := Project{
 		Title: "P3", ProjectTypeID: pt.ID, Status: ProjectStatusCompleted,
-		ActualCents: ptr(7777),
+		ActualCents: new(int64(7777)),
 	}
 	require.NoError(t, store.db.Create(&oldProj).Error)
 	require.NoError(t, store.db.Exec(
@@ -320,13 +307,12 @@ func TestTotalProjectSpendUnaffectedByEdits(t *testing.T) {
 	// not change the spending total. The old updated_at filter caused edits
 	// to inflate/deflate the YTD figure.
 	store := newTestStore(t)
-	ptr := func(v int64) *int64 { return &v }
 
 	var pt ProjectType
 	require.NoError(t, store.db.First(&pt).Error)
 	p := Project{
 		Title: "Kitchen Remodel", ProjectTypeID: pt.ID,
-		Status: ProjectStatusCompleted, ActualCents: ptr(50000),
+		Status: ProjectStatusCompleted, ActualCents: new(int64(50000)),
 	}
 	require.NoError(t, store.db.Create(&p).Error)
 

internal/data/store_test.go

@@ -240,7 +240,7 @@ func TestServiceLogCRUD(t *testing.T) {
 	require.NoError(t, store.CreateServiceLog(&ServiceLogEntry{
 		MaintenanceItemID: maintID,
 		ServicedAt:        time.Date(2026, 2, 1, 0, 0, 0, 0, time.UTC),
-		CostCents:         func() *int64 { v := int64(15000); return &v }(),
+		CostCents:         new(int64(15000)),
 		Notes:             "vendor did it",
 	}, Vendor{Name: "Test Plumber", Phone: "555-555-0001"}))
 
@@ -1807,6 +1807,10 @@ func newTestStoreWithDemoData(t *testing.T, seed uint64) *Store {
 	return store
 }
 
+func ptrTime(y, m, d int) *time.Time {
+	return new(time.Date(y, time.Month(m), d, 0, 0, 0, 0, time.UTC))
+}
+
 func TestCountQuotesByProject(t *testing.T) {
 	t.Parallel()
 	store := newTestStore(t)