chore: audit and fix agent config, codebase docs, and skills (#738)

## Summary

- Add `nix run '.#pre-commit'` step to `/pre-commit-check` skill
- Add missing `/pre-commit-check` and `/blog-post` skill triggers to
AGENTS.md
- Switch `/create-pr` skill from `--body-file` to HEREDOC, ban `/tmp`
file writes
- Update codebase docs: add Season constants/field to `types.md`,
clarify handler count, cross-reference AGENTS.md from `patterns.md`
- Bump verification dates on codebase docs

---------

Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>

Author: cpcloud

.claude/codebase/patterns.md

@@ -1,6 +1,6 @@
 <!-- Copyright 2026 Phillip Cloud -->
 <!-- Licensed under the Apache License, Version 2.0 -->
-<!-- verified: 2026-03-07 -->
+<!-- verified: 2026-03-10 -->
 
 # Code Patterns & Conventions
 
@@ -97,7 +97,7 @@ User edits (keyboard, calendar picker)
 - openAddForm(m) - enters form mode
 - requireZone(t, m, zoneID) - asserts zone exists
 
-### Mandatory Patterns
+### Mandatory Patterns (see AGENTS.md "Testing" for authoritative rules)
 - User-flow tests via keystrokes, never just internal API calls
 - Form tests: openAddForm(m) + set values + sendKey(m, "ctrl+s")
 - Inline edit: sendKey(m, "i") + set ColCursor + sendKey(m, "e")

.claude/codebase/types.md

@@ -1,6 +1,6 @@
 <!-- Copyright 2026 Phillip Cloud -->
 <!-- Licensed under the Apache License, Version 2.0 -->
-<!-- verified: 2026-03-07 -->
+<!-- verified: 2026-03-10 -->
 
 # Key Types & Interfaces
 
@@ -53,8 +53,9 @@ Central Bubbletea state. Key fields:
 - Snapshot(store, id) (undoEntry, error)
 - SyncFixedValues(store, specs)
 
-Implementations: projectHandler, quoteHandler, maintenanceHandler,
-incidentHandler, applianceHandler, serviceLogHandler, vendorHandler, documentHandler
+8 implementations (one per entity tab; formHouse is handled separately):
+projectHandler, quoteHandler, maintenanceHandler, incidentHandler,
+applianceHandler, serviceLogHandler, vendorHandler, documentHandler
 
 ### columnSpec (types.go)
 Title, Min/MaxWidth, Flex, Align, Kind (cellKind), Link (FK ref), FixedValues, HideOrder
@@ -86,7 +87,7 @@ Parent info (tab, entity, ID), Breadcrumb string, Tab (the detail sub-tab)
 - Quote - ProjectID, VendorID, total/labor/materials/other (cents)
 - Vendor - name (unique), contact, phone, email, website, notes
 - MaintenanceCategory - lookup table (not soft-deletable)
-- MaintenanceItem - name, categoryID, applianceID?, interval, dueDate, cost
+- MaintenanceItem - name, categoryID, applianceID?, season, interval, dueDate, cost
 - ServiceLogEntry - MaintenanceItemID (CASCADE), vendorID?, date, cost
 - Appliance - name, brand, model, serial, warranty, cost
 - Incident - title, status, severity, dates, applianceID?, vendorID?, cost
@@ -98,6 +99,9 @@ Parent info (tab, entity, ID), Breadcrumb string, Tab (the detail sub-tab)
 ### Project Status Constants
 ProjectStatusIdeating, Planned, Quoted, InProgress, Delayed, Completed, Abandoned
 
+### Season Constants
+SeasonSpring, SeasonSummer, SeasonFall, SeasonWinter
+
 ### Incident Constants
 - Status: Open, InProgress, Resolved
 - Severity: Urgent, Soon, Whenever

.claude/commands/create-pr.md

@@ -10,9 +10,10 @@ Create a pull request for the current branch.
 
 ## PR conventions
 
-- **Use `--body-file`**: Write the PR body to a file and pass
-  `--body-file` instead of `--body`. This avoids shell-quoting issues
-  that silently corrupt markdown.
+- **Use a HEREDOC for the body**: Pass the PR body via a HEREDOC to
+  avoid shell-quoting issues. Do not write temporary files to `/tmp`.
+  Example: `gh pr create --title "..." --body "$(cat <<'EOF'` ...
+  `EOF` `)"`
 - **Rebase merges only**: This repo uses `gh pr merge --rebase`. No merge
   commits, no squash merges.
 - **No "Test plan" section**: CI covers tests, lint, vet, and build.

.claude/commands/pre-commit-check.md

@@ -4,10 +4,11 @@
 Do NOT run pre-commit hooks manually. The git hooks run automatically on
 `git commit` (pre-commit stage) and `git push` (pre-push stage).
 
-Before committing, just make sure the code compiles and tests pass:
+Before committing, run these checks:
 
-1. `go build ./...` -- verify it compiles
-2. `go test -shuffle=on ./...` -- all packages, shuffled, no `-v`
+1. `nix run '.#pre-commit' -- --from-ref origin/main --to-ref HEAD --verbose` -- run all pre-commit hooks against changed files
+2. `go build ./...` -- verify it compiles
+3. `go test -shuffle=on ./...` -- all packages, shuffled, no `-v`
 
 If the commit hook fails, fix the issue and commit again. Never use
 `--no-verify`.

AGENTS.md

@@ -167,6 +167,8 @@ details; do not duplicate that detail here.
 - `/record-demo` -- after any UI/UX feature work; commit the GIF
 - `/new-fk-relationship` -- when adding FK links between soft-deletable entities
 - `/add-entity` -- when adding a new entity model (full wiring checklist)
+- `/pre-commit-check` -- before committing, to verify code compiles and tests pass
+- `/blog-post` -- when writing or updating Hugo blog content in `docs/`
 - `/debug-dump` -- when diagnosing rendering bugs (VHS or live TUI)
 
 ### Shell and tools