feat(ui): format vendor phone numbers for display

cpcloud · claude · cpcloud · commit 86b47952533b · 2026-03-30T15:05:41.000-04:00
Adds Locale field to Vendor model and cellTelephoneNumber kind. Formats phone numbers at row-build time using per-vendor locale with system-default fallback. Wires formatting into the TUI table, extraction preview, and preserves Locale through form round-trips. closes #860 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
diff --git a/internal/app/coldefs.go b/internal/app/coldefs.go
@@ -218,7 +218,7 @@ var vendorColumnDefs = []columnDef{
 	{"Name", columnSpec{Title: "Name", Min: 14, Max: 24, Flex: true}},
 	{"Contact", columnSpec{Title: "Contact", Min: 10, Max: 20, Flex: true}},
 	{"Email", columnSpec{Title: "Email", Min: 12, Max: 24, Flex: true}},
-	{"Phone", columnSpec{Title: "Phone", Min: 12, Max: 16}},
+	{"Phone", columnSpec{Title: "Phone", Min: 12, Max: 20, Kind: cellTelephoneNumber}},
 	{"Website", columnSpec{Title: "Website", Min: 12, Max: 28, Flex: true}},
 	{
 		"Quotes",
diff --git a/internal/app/extraction_render.go b/internal/app/extraction_render.go
@@ -12,6 +12,7 @@ import (
 	"time"
 
 	"charm.land/lipgloss/v2"
+	"github.com/micasa-dev/micasa/internal/config"
 	"github.com/micasa-dev/micasa/internal/data"
 	"github.com/micasa-dev/micasa/internal/extract"
 	"github.com/micasa-dev/micasa/internal/locale"
@@ -707,7 +708,7 @@ func previewColumns(tableName string, cur locale.Currency) []previewColDef {
 			{data.ColName, s[1], fmtAnyText},
 			{data.ColContactName, s[2], fmtAnyText},
 			{data.ColEmail, s[3], fmtAnyText},
-			{data.ColPhone, s[4], fmtAnyText},
+			{data.ColPhone, s[4], fmtPhone},
 			{data.ColWebsite, s[5], fmtAnyText},
 		}
 	case tableDocuments:
@@ -873,6 +874,17 @@ func fmtAnyText(v any) string {
 	}
 }
 
+func fmtPhone(v any) string {
+	if v == nil {
+		return ""
+	}
+	s, ok := v.(string)
+	if !ok {
+		return fmtAnyText(v)
+	}
+	return locale.FormatPhoneNumber(s, strings.ToUpper(config.DetectCountry()))
+}
+
 func fmtAnyFK(v any) string {
 	s := fmtAnyText(v)
 	if s != "" && s != "0" {
diff --git a/internal/app/extraction_render_test.go b/internal/app/extraction_render_test.go
@@ -0,0 +1,36 @@
+// Copyright 2026 Phillip Cloud
+// Licensed under the Apache License, Version 2.0
+
+package app
+
+import (
+	"testing"
+
+	"github.com/micasa-dev/micasa/internal/data"
+	"github.com/micasa-dev/micasa/internal/locale"
+	"github.com/stretchr/testify/assert"
+	"github.com/stretchr/testify/require"
+)
+
+func TestPreviewColumnsVendorFormatsPhone(t *testing.T) {
+	// Not parallel: t.Setenv modifies process-global state.
+	// LC_ALL has highest precedence in DetectCountry().
+	t.Setenv("LC_ALL", "en_US.UTF-8")
+	cur, err := locale.ResolveDefault("")
+	require.NoError(t, err)
+	cols := previewColumns(data.TableVendors, cur)
+
+	// Find the phone column by key.
+	var phoneFmt func(any) string
+	for _, c := range cols {
+		if c.dataKey == data.ColPhone {
+			phoneFmt = c.format
+			break
+		}
+	}
+	require.NotNil(t, phoneFmt, "phone column not found in vendor preview")
+
+	// Should format parseable numbers, passthrough garbage.
+	assert.Equal(t, "(555) 123-4567", phoneFmt("5551234567"))
+	assert.Equal(t, "not a phone", phoneFmt("not a phone"))
+}
diff --git a/internal/app/forms.go b/internal/app/forms.go
@@ -126,6 +126,7 @@ type vendorFormData struct {
 	Phone       string
 	Website     string
 	Notes       string
+	Locale      string
 }
 
 // entityRef identifies a polymorphic document parent (kind + ID).
@@ -1102,6 +1103,7 @@ func (m *Model) parseVendorFormData() (data.Vendor, error) {
 		Phone:       strings.TrimSpace(values.Phone),
 		Website:     strings.TrimSpace(values.Website),
 		Notes:       strings.TrimSpace(values.Notes),
+		Locale:      strings.TrimSpace(values.Locale),
 	}, nil
 }
 
@@ -1153,6 +1155,7 @@ func vendorFormValues(vendor data.Vendor) *vendorFormData {
 		Phone:       vendor.Phone,
 		Website:     vendor.Website,
 		Notes:       vendor.Notes,
+		Locale:      vendor.Locale,
 	}
 }
 
diff --git a/internal/app/handlers.go b/internal/app/handlers.go
@@ -5,9 +5,11 @@ package app
 
 import (
 	"fmt"
+	"strings"
 	"time"
 
 	"charm.land/bubbles/v2/table"
+	"github.com/micasa-dev/micasa/internal/config"
 	"github.com/micasa-dev/micasa/internal/data"
 )
 
@@ -494,7 +496,8 @@ func (vendorHandler) Load(
 	quoteCounts := fetchCounts(store.CountQuotesByVendor, ids)
 	jobCounts := fetchCounts(store.CountServiceLogsByVendor, ids)
 	docCounts := fetchDocCounts(store, data.DocumentEntityVendor, ids)
-	rows, meta, cellRows := vendorRows(vendors, quoteCounts, jobCounts, docCounts)
+	defaultRegion := strings.ToUpper(config.DetectCountry())
+	rows, meta, cellRows := vendorRows(vendors, quoteCounts, jobCounts, docCounts, defaultRegion)
 	return rows, meta, cellRows, nil
 }
 
diff --git a/internal/app/mag.go b/internal/app/mag.go
@@ -26,13 +26,13 @@ func magFormat(c cell, includeUnit bool, currencySymbol string) string {
 	}
 
 	// Only transform kinds that carry meaningful numeric data.
-	// cellText is excluded because it covers phone numbers, serial numbers,
+	// cellText is excluded because it covers serial numbers,
 	// model numbers, and other identifiers that happen to look numeric.
 	switch c.Kind {
 	case cellMoney, cellDrilldown, cellOps:
 		// Definitely numeric; continue to parsing below.
 	case cellText, cellReadonly, cellDate, cellStatus, cellWarranty,
-		cellUrgency, cellNotes, cellEntity:
+		cellUrgency, cellNotes, cellEntity, cellTelephoneNumber:
 		return value
 	default:
 		panic(fmt.Sprintf("unhandled cellKind: %d", c.Kind))
diff --git a/internal/app/mag_test.go b/internal/app/mag_test.go
@@ -300,7 +300,7 @@ func seedTabMoneyCells(tab *Tab, amounts []string) {
 			case cellReadonly:
 				cr[j] = cell{Value: "1", Kind: cellReadonly}
 			case cellText, cellDate, cellStatus, cellDrilldown, cellWarranty,
-				cellUrgency, cellNotes, cellEntity, cellOps:
+				cellUrgency, cellNotes, cellEntity, cellOps, cellTelephoneNumber:
 				cr[j] = cell{Value: "test", Kind: spec.Kind}
 			default:
 				panic(fmt.Sprintf("unhandled cellKind: %d", spec.Kind))
@@ -390,7 +390,7 @@ func seedMoneyCells(m *Model) {
 		case cellReadonly:
 			row[i] = cell{Value: "1", Kind: cellReadonly}
 		case cellText, cellDate, cellStatus, cellDrilldown, cellWarranty,
-			cellUrgency, cellNotes, cellEntity, cellOps:
+			cellUrgency, cellNotes, cellEntity, cellOps, cellTelephoneNumber:
 			row[i] = cell{Value: "test", Kind: spec.Kind}
 		default:
 			panic(fmt.Sprintf("unhandled cellKind: %d", spec.Kind))
diff --git a/internal/app/sort.go b/internal/app/sort.go
@@ -129,7 +129,7 @@ func compareCells(tab *Tab, col, a, b int) int {
 			return cmpOrdered(strings.ToLower(va), strings.ToLower(vb))
 		}
 		return cmpOrdered(na, nb)
-	case cellText, cellStatus, cellNotes, cellEntity:
+	case cellText, cellStatus, cellNotes, cellEntity, cellTelephoneNumber:
 		return cmpOrdered(strings.ToLower(va), strings.ToLower(vb))
 	}
 	panic(fmt.Sprintf("unhandled cellKind: %d", kind))
diff --git a/internal/app/table.go b/internal/app/table.go
@@ -644,7 +644,7 @@ func cellStyle(kind cellKind) lipgloss.Style {
 	case cellReadonly:
 		return appStyles.Readonly()
 	case cellText, cellDate, cellStatus, cellDrilldown, cellWarranty,
-		cellUrgency, cellNotes, cellEntity, cellOps:
+		cellUrgency, cellNotes, cellEntity, cellOps, cellTelephoneNumber:
 		return defaultStyle
 	}
 	panic(fmt.Sprintf("unhandled cellKind: %d", kind))
diff --git a/internal/app/tables.go b/internal/app/tables.go
@@ -7,6 +7,7 @@ import (
 	"encoding/json"
 	"fmt"
 	"strconv"
+	"strings"
 	"time"
 
 	"charm.land/bubbles/v2/table"
@@ -311,8 +312,13 @@ func vendorRows(
 	quoteCounts map[string]int,
 	jobCounts map[string]int,
 	docCounts map[string]int,
+	defaultRegion string,
 ) ([]table.Row, []rowMeta, [][]cell) {
 	return buildRows(vendors, func(v data.Vendor) rowSpec {
+		region := defaultRegion
+		if v.Locale != "" {
+			region = strings.ToUpper(v.Locale)
+		}
 		return rowSpec{
 			ID:      v.ID,
 			Deleted: v.DeletedAt.Valid,
@@ -321,7 +327,7 @@ func vendorRows(
 				{Value: v.Name, Kind: cellText},
 				{Value: v.ContactName, Kind: cellText},
 				{Value: v.Email, Kind: cellText},
-				{Value: v.Phone, Kind: cellText},
+				{Value: locale.FormatPhoneNumber(v.Phone, region), Kind: cellTelephoneNumber},
 				{Value: v.Website, Kind: cellText},
 				{Value: countStr(quoteCounts, v.ID), Kind: cellDrilldown},
 				{Value: countStr(jobCounts, v.ID), Kind: cellDrilldown},
diff --git a/internal/app/types.go b/internal/app/types.go
@@ -377,12 +377,13 @@ const (
 	cellReadonly
 	cellDate
 	cellStatus
-	cellDrilldown // interactive count that opens a detail view
-	cellWarranty  // date with green/red coloring based on expiry
-	cellUrgency   // date colored by proximity (green -> yellow -> red)
-	cellNotes     // text that can be expanded in a read-only overlay
-	cellEntity    // entity ref with colored kind-letter prefix
-	cellOps       // extraction ops count; opens tree overlay on enter
+	cellDrilldown       // interactive count that opens a detail view
+	cellWarranty        // date with green/red coloring based on expiry
+	cellUrgency         // date colored by proximity (green -> yellow -> red)
+	cellNotes           // text that can be expanded in a read-only overlay
+	cellEntity          // entity ref with colored kind-letter prefix
+	cellOps             // extraction ops count; opens tree overlay on enter
+	cellTelephoneNumber // formatted phone number; passthrough for styling
 )
 
 type cell struct {
diff --git a/internal/app/vendor_test.go b/internal/app/vendor_test.go
@@ -63,6 +63,7 @@ func TestVendorRows(t *testing.T) {
 		map[string]int{"01JTEST00000000000000001": 3},
 		map[string]int{"01JTEST00000000000000002": 5},
 		nil,
+		"US",
 	)
 	require.Len(t, rows, 2)
 	assert.Equal(t, "01JTEST00000000000000001", meta[0].ID)
@@ -78,7 +79,7 @@ func TestVendorRows(t *testing.T) {
 func TestVendorRowsDocCount(t *testing.T) {
 	t.Parallel()
 	docCounts := map[string]int{"01JTEST00000000000000001": 9}
-	_, _, cells := vendorRows(sampleVendors(), nil, nil, docCounts)
+	_, _, cells := vendorRows(sampleVendors(), nil, nil, docCounts, "US")
 	require.Len(t, cells, 2)
 	assert.Equal(t, "9", cells[0][int(vendorColDocs)].Value)
 	assert.Equal(t, cellDrilldown, cells[0][int(vendorColDocs)].Kind)
@@ -123,11 +124,18 @@ func TestVendorColumnSpecKinds(t *testing.T) {
 	specs := vendorColumnSpecs()
 	// ID (0) is readonly.
 	assert.Equal(t, cellReadonly, specs[0].Kind, "ID column should be readonly")
-	// Editable columns: Name, Contact, Email, Phone, Website.
-	for _, col := range []int{1, 2, 3, 4, 5} {
+	// Editable text columns: Name, Contact, Email, Website.
+	for _, col := range []int{1, 2, 3, 5} {
 		assert.Equalf(t, cellText, specs[col].Kind,
 			"col %d (%s): expected cellText", col, specs[col].Title)
 	}
+	// Phone (4) is a telephone number.
+	assert.Equal(
+		t,
+		cellTelephoneNumber,
+		specs[4].Kind,
+		"Phone column should be cellTelephoneNumber",
+	)
 	// Quotes (6), Jobs (7), and Docs (8) are drilldown columns.
 	for _, col := range []int{6, 7, 8} {
 		assert.Equalf(t, cellDrilldown, specs[col].Kind,
@@ -167,6 +175,119 @@ func TestVendorJobsRowsSetsItemLinkID(t *testing.T) {
 	assert.Equal(t, "01JTEST00000000000000007", cells[0][1].LinkID)
 }
 
+func TestVendorPhoneFormattedInTable(t *testing.T) {
+	// Not parallel: t.Setenv modifies process-global state.
+	// Force US default so the UK phone only formats correctly when the
+	// implementation actually consults Vendor.Locale (not the system default).
+	t.Setenv("LC_ALL", "en_US.UTF-8")
+	m := newTestModelWithStore(t)
+
+	require.NoError(t, m.store.CreateVendor(&data.Vendor{
+		Name:   "Phone Test Co",
+		Phone:  "02079460958",
+		Locale: "GB",
+	}))
+
+	// Navigate to vendor tab and reload.
+	for i, tab := range m.tabs {
+		if tab.Kind == tabVendors {
+			m.active = i
+			break
+		}
+	}
+	require.NoError(t, m.reloadActiveTab())
+
+	tab := m.activeTab()
+	require.NotEmpty(t, tab.Rows)
+	require.NotEmpty(t, tab.CellRows)
+
+	// Find the phone cell (vendorColPhone).
+	phoneCell := tab.CellRows[0][int(vendorColPhone)]
+	assert.Equal(t, "020 7946 0958", phoneCell.Value)
+	assert.Equal(t, cellTelephoneNumber, phoneCell.Kind)
+}
+
+func TestVendorLocalePreservedOnEdit(t *testing.T) {
+	t.Parallel()
+	m := newTestModelWithStore(t)
+
+	// Create vendor with a Locale set.
+	require.NoError(t, m.store.CreateVendor(&data.Vendor{
+		Name:   "UK Plumber",
+		Phone:  "02079460958",
+		Locale: "GB",
+	}))
+
+	vendors, err := m.store.ListVendors(false)
+	require.NoError(t, err)
+	require.Len(t, vendors, 1)
+	id := vendors[0].ID
+
+	// Open the real edit form -- this calls vendorFormValues(vendor)
+	// which copies Locale from the DB record into formData.
+	require.NoError(t, m.startEditVendorForm(id))
+	m.fs.form.Init()
+
+	// Change the name through the form data (simulates user editing).
+	values, ok := m.fs.formData.(*vendorFormData)
+	require.True(t, ok)
+	values.Name = "UK Plumber Renamed"
+
+	// Submit -- parseVendorFormData carries Locale through.
+	require.NoError(t, m.submitVendorForm())
+
+	// Reload and verify Locale is preserved.
+	updated, err := m.store.GetVendor(id)
+	require.NoError(t, err)
+	assert.Equal(t, "GB", updated.Locale)
+	assert.Equal(t, "UK Plumber Renamed", updated.Name)
+}
+
+func TestVendorInlineEditPhoneUsesRawValue(t *testing.T) {
+	// Not parallel: t.Setenv modifies process-global state.
+	t.Setenv("LC_ALL", "en_US.UTF-8")
+	m := newTestModelWithStore(t)
+
+	// Use a UK phone + GB locale so the table cell displays a formatted
+	// value ("020 7946 0958") that differs from the raw DB value.
+	require.NoError(t, m.store.CreateVendor(&data.Vendor{
+		Name:   "Raw Phone Co",
+		Phone:  "02079460958",
+		Locale: "GB",
+	}))
+
+	// Switch to vendor tab and reload.
+	for i, tab := range m.tabs {
+		if tab.Kind == tabVendors {
+			m.active = i
+			break
+		}
+	}
+	require.NoError(t, m.reloadActiveTab())
+
+	tab := m.activeTab()
+	require.NotEmpty(t, tab.Rows)
+	require.NotEmpty(t, tab.CellRows)
+
+	// Verify the table cell shows the formatted value.
+	phoneCell := tab.CellRows[0][int(vendorColPhone)]
+	assert.Equal(t, "020 7946 0958", phoneCell.Value, "table should show formatted phone")
+
+	id := tab.Rows[0].ID
+
+	// Open inline edit for phone column.
+	require.NoError(t, m.inlineEditVendor(id, vendorColPhone))
+	require.NotNil(t, m.inlineInput)
+
+	// The inline input should contain the raw DB value, not the formatted one.
+	assert.Equal(
+		t,
+		"02079460958",
+		m.inlineInput.Input.Value(),
+		"inline edit should use raw DB value",
+	)
+}
+
 func sampleVendors() []data.Vendor {
 	return []data.Vendor{
 		{
diff --git a/internal/data/meta_generated.go b/internal/data/meta_generated.go
diff --git a/internal/data/models.go b/internal/data/models.go
diff --git a/internal/extract/operations_test.go b/internal/extract/operations_test.go

Original file line number	Diff line number	Diff line change
`@@ -218,7 +218,7 @@ var vendorColumnDefs = []columnDef{`
`218`	`218`	`{"Name", columnSpec{Title: "Name", Min: 14, Max: 24, Flex: true}},`
`219`	`219`	`{"Contact", columnSpec{Title: "Contact", Min: 10, Max: 20, Flex: true}},`
`220`	`220`	`{"Email", columnSpec{Title: "Email", Min: 12, Max: 24, Flex: true}},`
`221`		`- {"Phone", columnSpec{Title: "Phone", Min: 12, Max: 16}},`
	`221`	`+ {"Phone", columnSpec{Title: "Phone", Min: 12, Max: 20, Kind: cellTelephoneNumber}},`
`222`	`222`	`{"Website", columnSpec{Title: "Website", Min: 12, Max: 28, Flex: true}},`
`223`	`223`	`{`
`224`	`224`	`"Quotes",`
Original file line number	Diff line number	Diff line change
`@@ -126,6 +126,7 @@ type vendorFormData struct {`
`126`	`126`	`Phone string`
`127`	`127`	`Website string`
`128`	`128`	`Notes string`
	`129`	`+ Locale string`
`129`	`130`	`}`
`130`	`131`
`131`	`132`	`// entityRef identifies a polymorphic document parent (kind + ID).`
`@@ -1102,6 +1103,7 @@ func (m *Model) parseVendorFormData() (data.Vendor, error) {`
`1102`	`1103`	`Phone: strings.TrimSpace(values.Phone),`
`1103`	`1104`	`Website: strings.TrimSpace(values.Website),`
`1104`	`1105`	`Notes: strings.TrimSpace(values.Notes),`
	`1106`	`+ Locale: strings.TrimSpace(values.Locale),`
`1105`	`1107`	`}, nil`
`1106`	`1108`	`}`
`1107`	`1109`
`@@ -1153,6 +1155,7 @@ func vendorFormValues(vendor data.Vendor) *vendorFormData {`
`1153`	`1155`	`Phone: vendor.Phone,`
`1154`	`1156`	`Website: vendor.Website,`
`1155`	`1157`	`Notes: vendor.Notes,`
	`1158`	`+ Locale: vendor.Locale,`
`1156`	`1159`	`}`
`1157`	`1160`	`}`
`1158`	`1161`
Original file line number	Diff line number	Diff line change
`@@ -129,7 +129,7 @@ func compareCells(tab *Tab, col, a, b int) int {`
`129`	`129`	`return cmpOrdered(strings.ToLower(va), strings.ToLower(vb))`
`130`	`130`	`}`
`131`	`131`	`return cmpOrdered(na, nb)`
`132`		`- case cellText, cellStatus, cellNotes, cellEntity:`
	`132`	`+ case cellText, cellStatus, cellNotes, cellEntity, cellTelephoneNumber:`
`133`	`133`	`return cmpOrdered(strings.ToLower(va), strings.ToLower(vb))`
`134`	`134`	`}`
`135`	`135`	`panic(fmt.Sprintf("unhandled cellKind: %d", kind))`
Original file line number	Diff line number	Diff line change
`@@ -644,7 +644,7 @@ func cellStyle(kind cellKind) lipgloss.Style {`
`644`	`644`	`case cellReadonly:`
`645`	`645`	`return appStyles.Readonly()`
`646`	`646`	`case cellText, cellDate, cellStatus, cellDrilldown, cellWarranty,`
`647`		`- cellUrgency, cellNotes, cellEntity, cellOps:`
	`647`	`+ cellUrgency, cellNotes, cellEntity, cellOps, cellTelephoneNumber:`
`648`	`648`	`return defaultStyle`
`649`	`649`	`}`
`650`	`650`	`panic(fmt.Sprintf("unhandled cellKind: %d", kind))`