Skip to content

Commit ac37fb4

Browse files
cpcloudclaude
andcommitted
fix(data): check ListMaintenance errors in hard-delete tests
Replace silently discarded errors (items, _ :=) with require.NoError so failures produce clear assertion messages instead of index panics. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
1 parent 5337c24 commit ac37fb4

1 file changed

Lines changed: 8 additions & 4 deletions

File tree

internal/data/store_test.go

Lines changed: 8 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -2906,7 +2906,8 @@ func TestHardDeleteMaintenanceRemovesRowAndChildren(t *testing.T) {
29062906
require.NoError(t, store.CreateMaintenance(&MaintenanceItem{
29072907
Name: "Filter change", CategoryID: cats[0].ID,
29082908
}))
2909-
items, _ := store.ListMaintenance(false)
2909+
items, err := store.ListMaintenance(false)
2910+
require.NoError(t, err)
29102911
require.Len(t, items, 1)
29112912
maintID := items[0].ID
29122913

@@ -2941,7 +2942,8 @@ func TestHardDeleteMaintenanceWritesOplogForChildren(t *testing.T) {
29412942
require.NoError(t, store.CreateMaintenance(&MaintenanceItem{
29422943
Name: "Oil change", CategoryID: cats[0].ID,
29432944
}))
2944-
items, _ := store.ListMaintenance(false)
2945+
items, err := store.ListMaintenance(false)
2946+
require.NoError(t, err)
29452947
maintID := items[0].ID
29462948

29472949
require.NoError(t, store.CreateServiceLog(&ServiceLogEntry{
@@ -2983,7 +2985,8 @@ func TestHardDeleteMaintenanceDetachesServiceLogDocuments(t *testing.T) {
29832985
require.NoError(t, store.CreateMaintenance(&MaintenanceItem{
29842986
Name: "Roof repair", CategoryID: cats[0].ID,
29852987
}))
2986-
items, _ := store.ListMaintenance(false)
2988+
items, err := store.ListMaintenance(false)
2989+
require.NoError(t, err)
29872990
maintID := items[0].ID
29882991

29892992
require.NoError(t, store.CreateServiceLog(&ServiceLogEntry{
@@ -3016,7 +3019,8 @@ func TestHardDeleteMaintenanceDetachesOwnDocuments(t *testing.T) {
30163019
require.NoError(t, store.CreateMaintenance(&MaintenanceItem{
30173020
Name: "Gutter cleaning", CategoryID: cats[0].ID,
30183021
}))
3019-
items, _ := store.ListMaintenance(false)
3022+
items, err := store.ListMaintenance(false)
3023+
require.NoError(t, err)
30203024
maintID := items[0].ID
30213025

30223026
// Attach a document directly to the maintenance item.

0 commit comments

Comments
 (0)