Skip to content

Commit d414d2f

Browse files
committed
ci(vendor-hash): drop go-mod-tidy from SKIP
The Tidy go modules step upstream already runs `go mod tidy`, so by the time the Commit and push step runs the tree is tidy and the go-mod-tidy hook is a pass-through no-op. Leaving it in SKIP was defending against a scenario that cannot occur on this path. vendor-hash-check is still skipped for the reason documented on the env comment.
1 parent 62b8395 commit d414d2f

1 file changed

Lines changed: 6 additions & 8 deletions

File tree

.github/workflows/update-vendor-hash.yml

Lines changed: 6 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -129,14 +129,12 @@ jobs:
129129

130130
- name: Commit and push
131131
env:
132-
# Skip hooks this workflow would always trip as false positives:
133-
# - vendor-hash-check fires when go.sum is staged but nix/package.nix
134-
# is not, which is exactly the state when `go mod tidy` reshapes
135-
# go.sum without altering vendor contents (this step already ran
136-
# the authoritative hash computation above).
137-
# - go-mod-tidy reruns tidy and complains if it would change files;
138-
# the Tidy go modules step upstream already tidied.
139-
SKIP: vendor-hash-check,go-mod-tidy
132+
# vendor-hash-check fires when go.sum is staged but nix/package.nix
133+
# is not, which is exactly the state when `go mod tidy` reshapes
134+
# go.sum without altering vendor contents. The compute step above
135+
# already ran the authoritative nix build, so this hook has nothing
136+
# to add here.
137+
SKIP: vendor-hash-check
140138
run: |
141139
git config user.name "github-actions[bot]"
142140
git config user.email "github-actions[bot]@users.noreply.github.com"

0 commit comments

Comments
 (0)