FLOW-11254 Snowflake connector: improve server instance URL validation (#4212)

* NO-FLOW Fix build warnings (#19)

* FLOW-11254 Validate configure URL is a Snowflake domain

---------

Co-authored-by: Piotr Zalas <127133187+sfc-gh-pzalas@users.noreply.github.com>

Author: sfc-gh-kbogusz

certified-connectors/Snowflake v2/SnowflakeTestApp.Tests/Sql/SqlEndpointIntegrationTest.cs

@@ -246,10 +246,10 @@ public async Task CancelStatementEndpoint_WithAuth_ReturnsBadRequest()
         }
 
         /// <summary>
-        /// Test cancellation of already completed SQL statement - should return 422
+        /// Test cancellation of already completed SQL statement - Snowflake returns 200
         /// </summary>
         [TestMethod]
-        public async Task SqlExecutionFlow_CancelCompletedStatement_Returns422()
+        public async Task SqlExecutionFlow_CancelCompletedStatement_Returns200()
         {
             var testToken = GetTestToken();
             HttpClient.DefaultRequestHeaders.Add("Authorization", $"Bearer {testToken}");
@@ -281,11 +281,11 @@ public async Task SqlExecutionFlow_CancelCompletedStatement_Returns422()
             string statementHandle = executeResult["Metadata"]["StatementHandle"].ToString();
             Assert.IsFalse(string.IsNullOrEmpty(statementHandle), "Statement handle should be present in response");
 
-            // Try to cancel already completed statement - should return 422
+            // Try to cancel already completed statement - Snowflake returns 200
             var cancelContent = new StringContent("{}", Encoding.UTF8, "application/json");
             var cancelResponse = await HttpClient.PostAsync($"{BaseUrl}/sql/{statementHandle}/cancel", cancelContent);
 
-            Assert.AreEqual(422, (int)cancelResponse.StatusCode, "Cancel should return 422 for already completed statement");
+            Assert.AreEqual(HttpStatusCode.OK, cancelResponse.StatusCode, "Cancel of completed statement should return 200");
         }
     }
 } 

certified-connectors/Snowflake v2/SnowflakeTestApp/Mocks/ConnectionParametersProviderMock.cs

@@ -160,4 +160,4 @@ public TokenMock(string token)
 
         public DateTime TokenAcquireTime => DateTime.UtcNow.AddMinutes(-1);
     }
-}
+}

certified-connectors/Snowflake v2/SnowflakeV2CoreLogic/Controllers/SnowflakeSQLController.cs

@@ -182,6 +182,9 @@ private static void ValidateInstanceUrl(
             {
                 throw new ArgumentException($"The Instance parameter cannot contain a trailing slash. Please remove it and try again.");
             }
+
+            // Validate that the instance belongs to a valid Snowflake domain
+            instanceUrl.EnsureValidSnowflakeUrl("Instance");
         }
     }
 }

certified-connectors/Snowflake v2/SnowflakeV2CoreLogic/SnowflakeV2CoreLogic.csproj

@@ -11,6 +11,9 @@
   <ItemGroup>
     <None Include="SnowflakeV2RuleSet.ruleset" />
   </ItemGroup>
+  <ItemGroup>
+    <InternalsVisibleTo Include="SnowflakeV2CoreLogic.Tests" />
+  </ItemGroup>
   <ItemGroup>
     <PackageReference Include="Microsoft.AspNet.OData" Version="5.11.0" />
     <PackageReference Include="Microsoft.Extensions.Logging.Abstractions" Version="6.0.4" />

certified-connectors/Snowflake v2/SnowflakeV2CoreLogic/Utilities/EnsureExtensions.cs

@@ -21,7 +21,7 @@ internal static class EnsureExtensions
         private static readonly Regex IdentifierRegexPattern = new Regex(IdentifierFullRegex, RegexOptions.Compiled);
 
         // Setup the regex for the snowflake URL
-        private static readonly string UrlFullRegex = @"[a-zA-Z0-9-_.]+\.snowflakecomputing\.com|[a-zA-Z0-9-_.]+\.privatelink\.snowflakecomputing\.com";
+        private static readonly string UrlFullRegex = @"^([a-zA-Z0-9-_.]+\.snowflakecomputing\.com|[a-zA-Z0-9-_.]+\.privatelink\.snowflakecomputing\.com)$";
         private static readonly Regex UrlRegexPattern = new Regex(UrlFullRegex, RegexOptions.Compiled);
 
         /// <summary>