-
Notifications
You must be signed in to change notification settings - Fork 92
Expand file tree
/
Copy pathpublishE2E.test.ts
More file actions
504 lines (388 loc) · 15 KB
/
publishE2E.test.ts
File metadata and controls
504 lines (388 loc) · 15 KB
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
import { describe, expect, it, afterEach, jest } from '@jest/globals';
import fs from 'fs-extra';
import path from 'path';
import { addGitObserver, clearGitObservers } from 'workspace-tools';
import { generateChangeFiles } from '../__fixtures__/changeFiles';
import { defaultBranchName, defaultRemoteBranchName } from '../__fixtures__/gitDefaults';
import { initMockLogs } from '../__fixtures__/mockLogs';
import { npmShow } from '../__fixtures__/npmShow';
import { Repository } from '../__fixtures__/repository';
import { RepositoryFactory } from '../__fixtures__/repositoryFactory';
import { publish } from '../commands/publish';
import { getDefaultOptions } from '../options/getDefaultOptions';
import { BeachballOptions } from '../types/BeachballOptions';
import { initNpmMock } from '../__fixtures__/mockNpm';
import { getPackageInfos } from '../monorepo/getPackageInfos';
// Spawning actual npm to run commands against a fake registry is extremely slow, so mock it for
// this test (packagePublish covers the more complete npm registry scenario).
//
// If an issue is found in the future that could only be caught by this test using real npm,
// a new test file with a real registry should be created to cover that specific scenario.
jest.mock('../packageManager/npm');
describe('publish command (e2e)', () => {
initNpmMock();
let repositoryFactory: RepositoryFactory | undefined;
// show error logs for these tests
initMockLogs({ alsoLog: ['error'] });
function getOptions(repo: Repository, overrides?: Partial<BeachballOptions>): BeachballOptions {
return {
...getDefaultOptions(),
branch: defaultRemoteBranchName,
registry: 'fake',
path: repo.rootPath,
command: 'publish',
message: 'apply package updates',
tag: 'latest',
yes: true,
access: 'public',
...overrides,
};
}
afterEach(() => {
clearGitObservers();
if (repositoryFactory) {
repositoryFactory.cleanUp();
repositoryFactory = undefined;
}
});
it('publishes a single package', async () => {
repositoryFactory = new RepositoryFactory('single');
const repo = repositoryFactory.cloneRepository();
generateChangeFiles(['foo'], repo.rootPath);
repo.push();
await publish(getOptions(repo));
expect(await npmShow('foo')).toMatchObject({
name: 'foo',
versions: ['1.1.0'],
'dist-tags': { latest: '1.1.0' },
});
repo.checkout(defaultBranchName);
repo.pull();
expect(repo.getCurrentTags()).toEqual(['foo_v1.1.0']);
});
it('publishes from detached HEAD', async () => {
repositoryFactory = new RepositoryFactory('single');
const repo = repositoryFactory.cloneRepository();
generateChangeFiles(['foo'], repo.rootPath);
repo.push();
repo.checkout('--detach');
await publish(getOptions(repo, { push: false }));
expect(await npmShow('foo')).toMatchObject({
name: 'foo',
versions: ['1.1.0'],
'dist-tags': { latest: '1.1.0' },
});
});
it('publishes from a race condition', async () => {
repositoryFactory = new RepositoryFactory('single');
const repo = repositoryFactory.cloneRepository();
generateChangeFiles(['foo'], repo.rootPath);
repo.push();
// Adds a step that injects a race condition
let fetchCount = 0;
addGitObserver((args, output) => {
if (args[0] === 'fetch') {
if (fetchCount === 0) {
const anotherRepo = repositoryFactory!.cloneRepository();
// inject a checkin
anotherRepo.updateJsonFile('package.json', { version: '1.0.2' });
anotherRepo.push();
}
fetchCount++;
}
});
await publish(getOptions(repo));
expect(await npmShow('foo')).toMatchObject({
name: 'foo',
versions: ['1.1.0'],
'dist-tags': { latest: '1.1.0' },
});
repo.checkout(defaultBranchName);
repo.pull();
expect(repo.getCurrentTags()).toEqual(['foo_v1.1.0']);
// this indicates 2 tries
expect(fetchCount).toBe(2);
});
it('publishes from a race condition in the dependencies', async () => {
repositoryFactory = new RepositoryFactory('single');
const repo = repositoryFactory.cloneRepository();
generateChangeFiles(['foo'], repo.rootPath);
repo.push();
// Adds a step that injects a race condition
let fetchCount = 0;
addGitObserver((args, output) => {
if (args[0] === 'fetch') {
if (fetchCount === 0) {
const anotherRepo = repositoryFactory!.cloneRepository();
// inject a checkin
const packageJsonFile = anotherRepo.pathTo('package.json');
const contents = fs.readJSONSync(packageJsonFile, 'utf-8');
delete contents.dependencies.baz;
anotherRepo.commitChange('package.json', JSON.stringify(contents, null, 2));
anotherRepo.push();
}
fetchCount++;
}
});
await publish(getOptions(repo));
expect(await npmShow('foo')).toMatchObject({
name: 'foo',
versions: ['1.1.0'],
'dist-tags': { latest: '1.1.0' },
});
repo.checkout(defaultBranchName);
repo.pull();
expect(repo.getCurrentTags()).toEqual(['foo_v1.1.0']);
// this indicates 2 tries
expect(fetchCount).toBe(2);
const packageJsonFile = repo.pathTo('package.json');
const contents = JSON.parse(fs.readFileSync(packageJsonFile, 'utf-8'));
expect(contents.dependencies.baz).toBeUndefined();
});
it('publishes without bump', async () => {
repositoryFactory = new RepositoryFactory('single');
const repo = repositoryFactory.cloneRepository();
generateChangeFiles(['foo'], repo.rootPath);
repo.push();
await publish(getOptions(repo, { bump: false }));
expect(await npmShow('foo')).toMatchObject({
name: 'foo',
versions: ['1.0.0'],
'dist-tags': { latest: '1.0.0' },
});
repo.checkout(defaultBranchName);
repo.pull();
expect(repo.getCurrentTags()).toEqual([]);
});
it('publishes only changed packages in a monorepo', async () => {
repositoryFactory = new RepositoryFactory('monorepo');
const repo = repositoryFactory.cloneRepository();
generateChangeFiles(['foo'], repo.rootPath);
repo.push();
await publish(getOptions(repo));
await npmShow('bar', { shouldFail: true });
expect(await npmShow('foo')).toMatchObject({
name: 'foo',
versions: ['1.1.0'],
'dist-tags': { latest: '1.1.0' },
});
repo.checkout(defaultBranchName);
repo.pull();
expect(repo.getCurrentTags()).toEqual(['foo_v1.1.0']);
});
it('publishes dependent packages in a monorepo', async () => {
repositoryFactory = new RepositoryFactory('monorepo');
const repo = repositoryFactory.cloneRepository();
// bump baz => dependent bump bar => dependent bump foo
generateChangeFiles(['baz'], repo.rootPath);
expect(repositoryFactory.fixture.folders!.packages.foo.dependencies!.bar).toBeTruthy();
expect(repositoryFactory.fixture.folders!.packages.bar.dependencies!.baz).toBeTruthy();
repo.push();
await publish(getOptions(repo));
expect(await npmShow('baz')).toMatchObject({
name: 'baz',
versions: ['1.4.0'],
'dist-tags': { latest: '1.4.0' },
});
expect(await npmShow('bar')).toMatchObject({
name: 'bar',
versions: ['1.3.5'],
'dist-tags': { latest: '1.3.5' },
dependencies: { baz: '^1.4.0' },
});
expect(await npmShow('foo')).toMatchObject({
name: 'foo',
versions: ['1.0.1'],
'dist-tags': { latest: '1.0.1' },
dependencies: { bar: '^1.3.5' },
});
repo.checkout(defaultBranchName);
repo.pull();
expect(repo.getCurrentTags()).toEqual(['bar_v1.3.5', 'baz_v1.4.0', 'foo_v1.0.1']);
});
it('publishes new monorepo packages if requested', async () => {
// use a slightly smaller fixture to only publish one extra package
repositoryFactory = new RepositoryFactory({
folders: {
packages: { foo: { version: '1.0.0' }, bar: { version: '1.3.4' } },
},
});
const repo = repositoryFactory.cloneRepository();
generateChangeFiles(['foo'], repo.rootPath);
// generateChangeFiles(['bar'], repo.rootPath);
repo.push();
await publish(getOptions(repo, { new: true }));
expect(await npmShow('foo')).toMatchObject({ name: 'foo', versions: ['1.1.0'] });
expect(await npmShow('bar')).toMatchObject({ name: 'bar', versions: ['1.3.4'] });
repo.checkout(defaultBranchName);
repo.pull();
expect(repo.getCurrentTags()).toEqual(['bar_v1.3.4', 'foo_v1.1.0']);
});
it("doesn't publish an out-of-scope package", async () => {
repositoryFactory = new RepositoryFactory('monorepo');
const repo = repositoryFactory.cloneRepository();
generateChangeFiles(['foo'], repo.rootPath);
generateChangeFiles(['bar'], repo.rootPath);
repo.push();
await publish(getOptions(repo, { scope: ['!packages/foo'] }));
await npmShow('foo', { shouldFail: true });
expect(repo.getCurrentTags()).toEqual([]);
expect(await npmShow('bar')).toMatchObject({
name: 'bar',
versions: ['1.4.0'],
'dist-tags': { latest: '1.4.0' },
});
repo.checkout(defaultBranchName);
repo.pull();
expect(repo.getCurrentTags()).toEqual(['bar_v1.4.0']);
});
it('respects prepublish hooks', async () => {
repositoryFactory = new RepositoryFactory('monorepo');
const repo = repositoryFactory.cloneRepository();
generateChangeFiles(['foo'], repo.rootPath);
repo.push();
await publish(
getOptions(repo, {
path: repo.rootPath,
hooks: {
prepublish: (packagePath: string) => {
const packageJsonPath = path.join(packagePath, 'package.json');
const packageJson = fs.readJSONSync(packageJsonPath);
if (packageJson.onPublish) {
Object.assign(packageJson, packageJson.onPublish);
delete packageJson.onPublish;
fs.writeFileSync(packageJsonPath, JSON.stringify(packageJson, null, 2) + '\n');
}
},
},
})
);
// Query the information from package.json from the registry to see if it was successfully patched
const show = (await npmShow('foo'))!;
expect(show.name).toEqual('foo');
expect(show.main).toEqual('lib/index.js');
expect(show.hasOwnProperty('onPublish')).toBeFalsy();
repo.checkout(defaultBranchName);
repo.pull();
// All git results should still have previous information
expect(repo.getCurrentTags()).toEqual(['foo_v1.1.0']);
const fooPackageJson = fs.readJSONSync(repo.pathTo('packages/foo/package.json'));
expect(fooPackageJson.main).toBe('src/index.ts');
expect(fooPackageJson.onPublish.main).toBe('lib/index.js');
});
it('respects postpublish hooks', async () => {
repositoryFactory = new RepositoryFactory('monorepo');
const repo = repositoryFactory.cloneRepository();
let notified;
generateChangeFiles(['foo'], repo.rootPath);
repo.push();
await publish(
getOptions(repo, {
path: repo.rootPath,
hooks: {
postpublish: packagePath => {
const packageJsonPath = path.join(packagePath, 'package.json');
const packageJson = fs.readJSONSync(packageJsonPath);
if (packageJson.afterPublish) {
notified = packageJson.afterPublish.notify;
}
},
},
})
);
const fooPackageJson = fs.readJSONSync(repo.pathTo('packages/foo/package.json'));
expect(fooPackageJson.main).toBe('src/index.ts');
expect(notified).toBe(fooPackageJson.afterPublish.notify);
});
it('can perform a successful npm publish without fetch', async () => {
repositoryFactory = new RepositoryFactory('single');
const repo = repositoryFactory.cloneRepository();
generateChangeFiles(['foo'], repo.rootPath);
repo.push();
let fetchCount = 0;
addGitObserver((args, output) => {
if (args[0] === 'fetch') {
fetchCount++;
}
});
await publish(getOptions(repo, { fetch: false }));
expect(await npmShow('foo')).toMatchObject({
name: 'foo',
versions: ['1.1.0'],
'dist-tags': { latest: '1.1.0' },
});
// no fetch when flag set to false
expect(fetchCount).toBe(0);
});
it('specifies fetch depth when depth param is defined', async () => {
repositoryFactory = new RepositoryFactory('single');
const repo = repositoryFactory.cloneRepository();
generateChangeFiles(['foo'], repo.rootPath);
repo.push();
let fetchCommand: string = '';
addGitObserver((args, output) => {
if (args[0] === 'fetch') {
fetchCommand = args.join(' ');
}
});
await publish(getOptions(repo, { depth: 10 }));
expect(await npmShow('foo')).toMatchObject({
name: 'foo',
versions: ['1.1.0'],
'dist-tags': { latest: '1.1.0' },
});
expect(fetchCommand).toMatch('--depth=10');
});
it('calls precommit hook before committing changes', async () => {
repositoryFactory = new RepositoryFactory('monorepo');
const repo = repositoryFactory.cloneRepository();
generateChangeFiles(['foo'], repo.rootPath);
repo.push();
await publish(
getOptions(repo, {
path: repo.rootPath,
hooks: {
precommit: async cwd => {
await new Promise(resolve => {
fs.writeFile(path.resolve(cwd, 'foo.txt'), 'foo', resolve);
});
},
},
})
);
repo.checkout(defaultBranchName);
repo.pull();
// All git results should still have previous information
expect(repo.getCurrentTags()).toEqual(['foo_v1.1.0']);
const manifestJson = fs.readFileSync(repo.pathTo('foo.txt'));
expect(manifestJson.toString()).toMatchInlineSnapshot(`"foo"`);
});
it.only('does a dry run if requested', async () => {
repositoryFactory = new RepositoryFactory('monorepo');
const repo = repositoryFactory.cloneRepository();
// bump baz => dependent bump bar => dependent bump foo
generateChangeFiles(['baz'], repo.rootPath);
expect(repositoryFactory.fixture.folders!.packages.foo.dependencies!.bar).toBeTruthy();
expect(repositoryFactory.fixture.folders!.packages.bar.dependencies!.baz).toBeTruthy();
repo.push();
await publish({ ...getOptions(repo), dryRun: true });
// not published to registry
await npmShow('baz', { shouldFail: true });
await npmShow('bar', { shouldFail: true });
await npmShow('foo', { shouldFail: true });
// versions are bumped locally
let packageInfos = getPackageInfos(repo.rootPath);
expect(packageInfos.foo.version).toEqual('1.0.1');
expect(packageInfos.bar.version).toEqual('1.3.5');
expect(packageInfos.baz.version).toEqual('1.4.0');
repo.checkout(defaultBranchName);
repo.pull();
// no tags created
expect(repo.getCurrentTags()).toEqual([]);
// versions haven't been updated in remote
packageInfos = getPackageInfos(repo.rootPath);
expect(packageInfos.foo.version).toEqual('1.0.0');
expect(packageInfos.bar.version).toEqual('1.3.4');
expect(packageInfos.baz.version).toEqual('1.3.4');
});
});