Update verdaccio to v6

Author: ecraig12345

change/beachball-e606449d-61ec-4934-8a24-91aa58cae28b.json

@@ -0,0 +1,7 @@
+{
+  "type": "none",
+  "comment": "Tests: update verdaccio to v6",
+  "packageName": "beachball",
+  "email": "elcraig@microsoft.com",
+  "dependentChangeType": "none"
+}

package.json

@@ -66,19 +66,12 @@
   "resolutions": {
     "@types/node": "^22.0.0",
     "lodash": "^4.18.1",
-    "body-parser/qs@6.11.0": "^6.14.2",
     "express/qs@6.11.0": "^6.14.2",
     "@cypress/request/qs@6.10.4": "^6.14.2",
     "syncpack/minimatch@6.2.0": "^6.2.3",
     "syncpack/semver@7.5.0": "^7.7.4",
-    "verdaccio/handlebars@4.7.8": "^4.7.9",
-    "verdaccio/js-yaml@4.1.0": "^4.1.0",
-    "verdaccio/validator@13.11.0": "^13.15.22",
-    "@verdaccio/config/js-yaml@4.1.0": "^4.1.0",
-    "@verdaccio/config/minimatch@7.4.6": "^7.4.9",
-    "@verdaccio/core/ajv@8.12.0": "^8.18.0",
-    "@verdaccio/url/validator@13.11.0": "^13.15.22",
-    "@verdaccio/utils/minimatch@7.4.6": "^7.4.9"
+    "@verdaccio/core/ajv@8.17.1": "^8.18.0",
+    "@verdaccio/core/ajv@8.18.0": "^8.18.0"
   },
   "rationale": {
     "devDependencies": {
@@ -88,8 +81,6 @@
       "lodash": "Unpin due to security issue",
       "*/qs": "Unpin due to security issue",
       "*/semver": "Unpin due to security issues",
-      "*/verdaccio/*": "Unpin due to security issues",
-      "*/@verdaccio/*/*": "Unpin due to security issues",
       "*/minimatch": "Unpin minimatch due to security issues"
     }
   }

packages/beachball/.depcheckrc.yml

@@ -11,3 +11,7 @@ ignores:
   - 'eslint-*'
   - '@types/node'
   - '@jest/globals'
+  # needed for type references from verdaccio (not listed in deps)
+  - '@verdaccio/types'
+  # needed for type references from @verdaccio/types
+  - '@types/jsonwebtoken'

packages/beachball/package.json

@@ -48,23 +48,19 @@
   },
   "devDependencies": {
     "@microsoft/beachball-scripts": "1.0.0",
+    "@types/jsonwebtoken": "^9.0.10",
     "@types/minimatch": "^3.0.0",
     "@types/prompts": "^2.4.2",
     "@types/semver": "^7.3.13",
     "@types/tmp": "^0.2.3",
     "@types/yargs-parser": "^21.0.0",
+    "@verdaccio/types": "^13.0.0",
     "get-port": "^5.0.0",
     "normalized-tmpdir": "1.0.1",
     "strip-ansi": "^6.0.1",
     "tmp": "^0.2.1",
-    "verdaccio": "5.29.2",
-    "verdaccio-auth-memory": "10.2.2",
-    "verdaccio-memory": "10.3.2"
-  },
-  "rationale": {
-    "devDependencies": {
-      "verdaccio-auth-memory@10.2.2": "node 18 required by newer version",
-      "verdaccio-memory@10.3.2": "node 18 required by newer version"
-    }
+    "verdaccio": "^6.5.2",
+    "verdaccio-auth-memory": "^13.0.0",
+    "verdaccio-memory": "^10.4.3"
   }
 }

packages/beachball/src/__fixtures__/registry.ts

@@ -114,7 +114,7 @@ export class Registry {
       const registry = this.getUrl();
       const result = await execa('npm', ['whoami', '--registry', registry]);
       return result.stdout.trim();
-    } catch (err) {
+    } catch {
       return undefined;
     }
   }
@@ -178,7 +178,7 @@ export class Registry {
     return new Promise((resolve, reject) => {
       let hasReturned = false;
       const rejectWrapper = (err: unknown) => {
-        !hasReturned && reject(err);
+        !hasReturned && reject(err instanceof Error ? err : new Error(String(err)));
         hasReturned = true;
       };
 
@@ -270,7 +270,7 @@ export class Registry {
       configBuilder.addLogger({
         type: 'file',
         level: 'trace',
-        format: 'file',
+        format: 'pretty',
         path: path.join(process.cwd(), `verdaccio-${Date.now()}.log`),
       });
     }

packages/beachball/src/__functional__/packageManager/packagePublish.test.ts

@@ -6,7 +6,7 @@ import { removeTempDir, tmpdir } from '../../__fixtures__/tmpdir';
 import * as npmModule from '../../packageManager/npm';
 import { packagePublish } from '../../packageManager/packagePublish';
 import type { PackageInfo } from '../../types/PackageInfo';
-import type { npm, NpmResult } from '../../packageManager/npm';
+import { npm, NpmResult } from '../../packageManager/npm';
 import { writeJson } from '../../object/writeJson';
 import { getNpmPackageInfo } from '../../packageManager/getNpmPackageInfo';
 import { env } from '../../env';
@@ -27,7 +27,6 @@ const testPackage = { name: testName, version: testVersion };
 // TODO: re-enable when jest and verdaccio are updated
 describe.skip('packagePublish', () => {
   let npmSpy: jest.SpiedFunction<typeof npm>;
-  let npmVersion: string;
   let tempRoot: string;
   let tempPackageJsonPath: string;
   /**
@@ -90,8 +89,6 @@ describe.skip('packagePublish', () => {
       tempRoot = tmpdir();
       tempPackageJsonPath = path.join(tempRoot, 'package.json');
       writeJson(tempPackageJsonPath, testPackage);
-
-      npmVersion = (await npmModule.npm(['--version'], { cwd: tempRoot })).stdout.trim() || '';
     });
 
     beforeEach(async () => {
@@ -187,12 +184,6 @@ describe.skip('packagePublish', () => {
     });
 
     it('handles auth error and does not retry', async () => {
-      // TODO: remove condition once node version is upgraded (this test doesn't work with npm 6 because
-      // that version seems to allow truly anonymous publishing with verdaccio)
-      if (npmVersion.startsWith('6.')) {
-        console.warn('Skipping auth error test on npm 6');
-        return;
-      }
       await registry.logout();
 
       const testPackageInfo = getTestPackageInfo();