cleanup

Author: ecraig12345

src/changefile/promptForChange.ts

@@ -1,5 +1,5 @@
 import prompts from 'prompts';
-import { prerelease } from 'semver';
+import semver from 'semver';
 import { ChangeFileInfo, ChangeType } from '../types/ChangeInfo';
 import { BeachballOptions } from '../types/BeachballOptions';
 import { isValidChangeType } from '../validation/isValidChangeType';
@@ -28,12 +28,18 @@ export async function promptForChange(params: {
 
   // Get the questions for each package first, in case one package has a validation issue
   const packageQuestions: { [pkg: string]: prompts.PromptObject[] } = {};
+  let hasError = false;
   for (const pkg of changedPackages) {
     const questions = _getQuestionsForPackage({ pkg, ...params });
-    if (!questions) {
-      return; // validation issue
+    if (questions) {
+      packageQuestions[pkg] = questions;
+    } else {
+      // show all the errors before returning
+      hasError = true;
     }
-    packageQuestions[pkg] = questions;
+  }
+  if (hasError) {
+    return;
   }
 
   // Now prompt for each package
@@ -56,6 +62,7 @@ export async function promptForChange(params: {
 
 /**
  * Build the list of questions to ask the user for this package.
+ * Also validates the options and returns undefined if there's an issue.
  * @internal exported for testing
  */
 export function _getQuestionsForPackage(params: {
@@ -75,7 +82,7 @@ export function _getQuestionsForPackage(params: {
   }
 
   const packageInfo = packageInfos[pkg];
-  const showPrereleaseOption = !!prerelease(packageInfo.version);
+  const showPrereleaseOption = !!semver.prerelease(packageInfo.version);
   const changeTypeChoices: prompts.Choice[] = [
     ...(showPrereleaseOption ? [{ value: 'prerelease', title: ' Prerelease - bump prerelease version' }] : []),
     { value: 'patch', title: ' Patch      - bug fixes; no API changes.' },