Skip to content

Commit 6a448d1

Browse files
committed
Configure trusted publishing
1 parent 9e731bd commit 6a448d1

2 files changed

Lines changed: 26 additions & 13 deletions

File tree

.github/workflows/pr.yml

Lines changed: 18 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -22,28 +22,41 @@ jobs:
2222
build:
2323
strategy:
2424
matrix:
25-
os: [ubuntu-latest, windows-latest]
26-
npm: [8]
2725
include:
2826
- os: ubuntu-latest
2927
# npm 6 and 8 have slightly different behavior with verdaccio in publishing tests.
3028
# It's unclear if this translates to meaningful differences in behavior in actual scenarios,
3129
# but test against both versions to be safe. (Only do this on the ubuntu build for speed.)
3230
npm: 6
31+
node: 14
32+
# node 14/npm 8 on ubuntu and windows
33+
- os: ubuntu-latest
34+
npm: 8
35+
node: 14
36+
- os: windows-latest
37+
npm: 8
38+
node: 14
39+
# node 22/npm 11 on ubuntu and windows
40+
- os: ubuntu-latest
41+
npm: 11
42+
node: 22
43+
- os: windows-latest
44+
npm: 11
45+
node: 22
3346

34-
name: build (${{ matrix.os }}, npm ${{ matrix.npm }})
47+
name: build (${{ matrix.os }}, node ${{ matrix.node }}, npm ${{ matrix.npm }})
3548

3649
runs-on: ${{ matrix.os }}
3750

3851
steps:
3952
- name: Check out code
4053
uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6
4154

42-
- name: Install Node.js from .nvmrc
55+
- name: Install Node.js ${{ matrix.node }}
4356
uses: actions/setup-node@53b83947a5a98c8d113130e565377fae1a50d02f # v6
4457
with:
4558
cache: yarn
46-
node-version-file: .nvmrc
59+
node-version: ${{ matrix.node }}
4760

4861
# Guarantee a predictable version of npm for the first round of tests
4962
- name: Install npm@${{ matrix.npm }}

.github/workflows/release.yml

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -4,8 +4,10 @@ name: Release
44
on:
55
workflow_dispatch:
66

7+
# Use newer node and npm for trusted publishing support
78
env:
8-
npmVersion: 8
9+
npmVersion: 11
10+
nodeVersion: 22
911

1012
concurrency:
1113
group: ${{ github.workflow }}-${{ github.ref }}
@@ -26,14 +28,13 @@ jobs:
2628
# Don't save creds in the git config (so it's easier to override later)
2729
persist-credentials: false
2830

29-
- name: Install Node.js from .nvmrc
31+
- name: Install Node.js ${{ env.nodeVersion }}
3032
uses: actions/setup-node@53b83947a5a98c8d113130e565377fae1a50d02f # v6
3133
with:
32-
node-version-file: .nvmrc
34+
node-version: ${{ env.nodeVersion }}
3335

34-
# Guarantee a predictable version of npm (the PR build tests against both 6 and 8)
35-
- name: Install package managers
36-
run: npm install --global npm@${{ env.npmVersion }} yarn@1
36+
- name: Install npm@${{ env.npmVersion }}
37+
run: npm install --global npm@${{ env.npmVersion }}
3738

3839
- run: yarn --frozen-lockfile
3940

@@ -58,7 +59,6 @@ jobs:
5859
# Add a token to the remote URL for auth during release
5960
git remote set-url origin "https://$REPO_PAT@github.com/$GITHUB_REPOSITORY"
6061
61-
yarn release -y -n "$NPM_AUTHTOKEN"
62+
yarn release -y
6263
env:
63-
NPM_AUTHTOKEN: ${{ secrets.NPM_AUTHTOKEN }}
6464
REPO_PAT: ${{ secrets.REPO_PAT }}

0 commit comments

Comments
 (0)