updateRelatedChangeType perf improvements (#1046)

Author: ecraig12345

change/beachball-f68d7ef6-b961-4120-a82e-68dc570bd35f.json

@@ -0,0 +1,7 @@
+{
+  "type": "minor",
+  "comment": "Remove redundant processing in updateRelatedChangeType, and other minor optimizations",
+  "packageName": "beachball",
+  "email": "elcraig@microsoft.com",
+  "dependentChangeType": "patch"
+}

src/__fixtures__/packageInfos.ts

@@ -5,6 +5,10 @@ import { getDefaultOptions } from '../options/getDefaultOptions';
 
 const defaultOptions = getDefaultOptions();
 
+export type PartialPackageInfos = {
+  [name: string]: Partial<Omit<PackageInfo, 'combinedOptions'>> & { combinedOptions?: Partial<BeachballOptions> };
+};
+
 /**
  * Makes a properly typed PackageInfos object from a partial object, filling in defaults:
  * ```
@@ -18,9 +22,7 @@ const defaultOptions = getDefaultOptions();
  * }
  * ```
  */
-export function makePackageInfos(packageInfos: {
-  [name: string]: Partial<Omit<PackageInfo, 'combinedOptions'>> & { combinedOptions?: Partial<BeachballOptions> };
-}): PackageInfos {
+export function makePackageInfos(packageInfos: PartialPackageInfos): PackageInfos {
   return _.mapValues(packageInfos, (info, name): PackageInfo => {
     const { combinedOptions, ...rest } = info;
     return {

src/__tests__/bump/getDependentsForPackages.test.ts

@@ -0,0 +1,53 @@
+import { describe, it, expect } from '@jest/globals';
+import { makePackageInfos } from '../../__fixtures__/packageInfos';
+import { consideredDependencies } from '../../types/PackageInfo';
+import { getDependentsForPackages } from '../../bump/getDependentsForPackages';
+
+describe('getDependentsForPackages', () => {
+  it.each(consideredDependencies)('includes %s', depType => {
+    const packages = makePackageInfos({
+      foo: { [depType]: { baz: '1.0.0' } },
+      bar: { [depType]: { baz: '1.0.0' } },
+      baz: {},
+    });
+    const dependents = getDependentsForPackages({
+      packageInfos: packages,
+      scopedPackages: new Set(Object.keys(packages)),
+    });
+    expect(dependents).toEqual({
+      baz: ['foo', 'bar'],
+    });
+  });
+
+  it('does not include transitive dependencies', () => {
+    const packages = makePackageInfos({
+      foo: { dependencies: { bar: '1.0.0' } },
+      bar: { dependencies: { baz: '1.0.0' } },
+      baz: {},
+    });
+    const dependents = getDependentsForPackages({
+      packageInfos: packages,
+      scopedPackages: new Set(Object.keys(packages)),
+    });
+    expect(dependents).toEqual({
+      bar: ['foo'],
+      baz: ['bar'],
+    });
+  });
+
+  it('only includes dependencies of in-scope packages', () => {
+    const packages = makePackageInfos({
+      foo: { dependencies: { bar: '1.0.0' } },
+      bar: { dependencies: { baz: '1.0.0' } },
+      baz: {},
+    });
+    const dependents = getDependentsForPackages({
+      packageInfos: packages,
+      // means only look at dependencies of foo
+      scopedPackages: new Set(['foo']),
+    });
+    expect(dependents).toEqual({
+      bar: ['foo'],
+    });
+  });
+});