Move to new eng package, split build to CJS+ESM (#173)

Author: bwateratmsft

.eslintignore

@@ -1,9 +1,13 @@
-lib/test/**
+!dist
+dist/*/test/**
 .eslint*
 .vscode
+.nvmrc
 src
 tsconfig.json
 .github
 .azure-pipelines
 *.tgz
 .gitattributes
+*.map
+eslint.config.mjs

.eslintrc.json

@@ -1 +1 @@
-16.17
+22.18

.npmignore

@@ -5,52 +5,16 @@
     "version": "0.2.0",
     "configurations": [
         {
-            "type": "node",
+            "name": "Run Tests",
             "request": "launch",
-            "name": "Mocha All",
-            "program": "${workspaceFolder}/node_modules/mocha/bin/_mocha",
-            "args": [
-                "--timeout", // Set an infinite timeout when debugging so breakpoints don't mislead into thinking the test failed
-                "0",
-                "--file",
-                "${workspaceFolder}/lib/test/global.test.js",
-                "--recursive",
-                "${workspaceFolder}/lib/test"
+            "runtimeArgs": [
+                "test",
             ],
-            "preLaunchTask": "${defaultBuildTask}",
-            "resolveSourceMapLocations": [
-                "${workspaceFolder}/**",
-                "!**/node_modules/**"
-            ],
-            "internalConsoleOptions": "openOnSessionStart",
-            "presentation": {
-                "group": "Mocha",
-            }
-        },
-        {
-            "type": "node",
-            "request": "launch",
-            "name": "Mocha Unit Tests",
-            "program": "${workspaceFolder}/node_modules/mocha/bin/_mocha",
-            "args": [
-                "--timeout", // Set an infinite timeout when debugging so breakpoints don't mislead into thinking the test failed
-                "0",
-                "--file",
-                "${workspaceFolder}/lib/test/global.test.js",
-                "--grep",
-                "/unit/i",
-                "--recursive",
-                "${workspaceFolder}/lib/test"
-            ],
-            "preLaunchTask": "${defaultBuildTask}",
-            "resolveSourceMapLocations": [
-                "${workspaceFolder}/**",
-                "!**/node_modules/**"
+            "runtimeExecutable": "npm",
+            "skipFiles": [
+                "<node_internals>/**"
             ],
-            "internalConsoleOptions": "openOnSessionStart",
-            "presentation": {
-                "group": "Mocha",
-            }
+            "type": "node"
         },
         {
             "name": "Test Client Extension",
@@ -59,9 +23,9 @@
             "args": [
                 "--extensionDevelopmentPath=${workspaceFolder}/src/test/clientExtension",
                 "--disable-extension=ms-azuretools.vscode-containers", // Keep the Container Tools extension from running so it doesn't interfere with testing
+                "--disable-extension=docker.docker", // Keep the Docker DX extension from running so it doesn't interfere with testing
                 "--disable-extension=redhat.vscode-yaml", // Keep the YAML extension from running so it doesn't interfere with testing
             ],
-            "preLaunchTask": "tsc-watch: client extension",
             "presentation": {
                 "hidden": true,
             }
@@ -92,7 +56,7 @@
                 "group": "Live testing",
                 "order": 1
             },
-            "preLaunchTask": "tsc-watch: language service"
+            "preLaunchTask": "Build+Watch+CJS"
         }
     ]
 }

.nvmrc

@@ -8,7 +8,6 @@
     "editor.codeActionsOnSave": {
         "source.fixAll": "explicit"
     },
-    "typescript.preferences.importModuleSpecifier": "relative",
     "git.branchProtection": [
         "main",
         "rel/*"

.vscode/launch.json

@@ -2,35 +2,24 @@
     "version": "2.0.0",
     "tasks": [
         {
-            "type": "typescript",
-            "tsconfig": "tsconfig.json",
-            "option": "watch",
-            "problemMatcher": [
-                "$tsc-watch"
+            "label": "Build+Watch+CJS",
+            "type": "shell",
+            "command": "npm",
+            "args": [
+                "run",
+                "build:cjs",
+                "--",
+                "--watch",
             ],
             "group": {
                 "kind": "build",
-                "isDefault": true
-            },
-            "presentation": {
-                "reveal": "never"
+                "isDefault": true,
             },
             "isBackground": true,
-            "label": "tsc-watch: language service"
-        },
-        {
-            "type": "typescript",
-            "tsconfig": "src/test/clientExtension/tsconfig.json",
-            "option": "watch",
-            "problemMatcher": [
-                "$tsc-watch"
-            ],
-            "group": "build",
             "presentation": {
-                "reveal": "never"
+                "revealProblems": "onProblem"
             },
-            "isBackground": true,
-            "label": "tsc-watch: client extension"
+            "problemMatcher": "$tsc-watch",
         }
     ]
 }

.vscode/settings.json

@@ -3,4 +3,4 @@
  *  Copyright (c) Microsoft Corporation. All rights reserved.
  *  Licensed under the MIT License. See LICENSE in the project root for license information.
  *--------------------------------------------------------------------------------------------*/
-require("../lib/server");
+require("../dist/cjs/server");

.vscode/tasks.json

@@ -0,0 +1,14 @@
+/*---------------------------------------------------------------------------------------------
+ *  Copyright (c) Microsoft Corporation. All rights reserved.
+ *  Licensed under the MIT License. See LICENSE.md in the project root for license information.
+ *--------------------------------------------------------------------------------------------*/
+
+import { azExtEslintRecommendedTypeChecked } from '@microsoft/vscode-azext-eng/eslint'; // Other configurations exist
+import { defineConfig, globalIgnores } from 'eslint/config';
+
+export default defineConfig(
+    globalIgnores([
+        'src/test/clientExtension',
+    ]),
+    azExtEslintRecommendedTypeChecked,
+);