-
Notifications
You must be signed in to change notification settings - Fork 50
Expand file tree
/
Copy pathRedirectHandlerTests.cs
More file actions
903 lines (819 loc) · 47.2 KB
/
Copy pathRedirectHandlerTests.cs
File metadata and controls
903 lines (819 loc) · 47.2 KB
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
733
734
735
736
737
738
739
740
741
742
743
744
745
746
747
748
749
750
751
752
753
754
755
756
757
758
759
760
761
762
763
764
765
766
767
768
769
770
771
772
773
774
775
776
777
778
779
780
781
782
783
784
785
786
787
788
789
790
791
792
793
794
795
796
797
798
799
800
801
802
803
804
805
806
807
808
809
810
811
812
813
814
815
816
817
818
819
820
821
822
823
824
825
826
827
828
829
830
831
832
833
834
835
836
837
838
839
840
841
842
843
844
845
846
847
848
849
850
851
852
853
854
855
856
857
858
859
860
861
862
863
864
865
866
867
868
869
870
871
872
873
874
875
876
877
878
879
880
881
882
883
884
885
886
887
888
889
890
891
892
893
894
895
896
897
898
899
900
901
902
903
using System;
using System.Linq;
using System.Net;
using System.Net.Http;
using System.Net.Http.Headers;
using System.Threading;
using System.Threading.Tasks;
using Microsoft.Kiota.Http.HttpClientLibrary.Middleware;
using Microsoft.Kiota.Http.HttpClientLibrary.Middleware.Options;
using Microsoft.Kiota.Http.HttpClientLibrary.Tests.Mocks;
using Xunit;
namespace Microsoft.Kiota.Http.HttpClientLibrary.Tests.Middleware
{
/// <summary>
/// A mock IWebProxy implementation for testing proxy bypass scenarios.
/// </summary>
internal class MockWebProxy : IWebProxy
{
private readonly Uri _proxyUri;
private readonly string[] _bypassList;
public MockWebProxy(Uri proxyUri, params string[] bypassList)
{
_proxyUri = proxyUri;
_bypassList = bypassList;
}
public ICredentials? Credentials { get; set; }
public Uri? GetProxy(Uri destination) => _proxyUri;
public bool IsBypassed(Uri host)
{
return _bypassList.Any(bypass => host.Host.IndexOf(bypass, StringComparison.OrdinalIgnoreCase) >= 0);
}
}
/// <summary>
/// A mock DelegatingHandler for testing that allows setting responses and proper chaining.
/// </summary>
internal class MockDelegatingRedirectHandler : DelegatingHandler
{
private HttpResponseMessage? _response1;
private HttpResponseMessage? _response2;
private bool _response1Sent;
protected override Task<HttpResponseMessage> SendAsync(HttpRequestMessage request, CancellationToken cancellationToken)
{
if(!_response1Sent)
{
_response1Sent = true;
_response1!.RequestMessage = request;
return Task.FromResult(_response1);
}
else
{
_response1Sent = false;
_response2!.RequestMessage = request;
return Task.FromResult(_response2);
}
}
public void SetHttpResponse(HttpResponseMessage? response1, HttpResponseMessage? response2 = null)
{
_response1Sent = false;
_response1 = response1;
_response2 = response2;
}
}
public sealed class RedirectHandlerTests : IDisposable
{
private readonly MockRedirectHandler _testHttpMessageHandler;
private readonly RedirectHandler _redirectHandler;
private readonly HttpMessageInvoker _invoker;
public RedirectHandlerTests()
{
this._testHttpMessageHandler = new MockRedirectHandler();
this._redirectHandler = new RedirectHandler
{
InnerHandler = _testHttpMessageHandler
};
this._invoker = new HttpMessageInvoker(this._redirectHandler);
}
public void Dispose()
{
this._invoker.Dispose();
GC.SuppressFinalize(this);
}
[Fact]
public void RedirectHandler_Constructor()
{
// Assert
using RedirectHandler redirect = new RedirectHandler();
Assert.Null(redirect.InnerHandler);
Assert.NotNull(redirect.RedirectOption);
Assert.Equal(5, redirect.RedirectOption.MaxRedirect); // default MaxRedirects is 5
Assert.IsType<RedirectHandler>(redirect);
}
[Fact]
public void RedirectHandler_HttpMessageHandlerConstructor()
{
// Assert
Assert.NotNull(this._redirectHandler.InnerHandler);
Assert.NotNull(_redirectHandler.RedirectOption);
Assert.Equal(5, _redirectHandler.RedirectOption.MaxRedirect); // default MaxRedirects is 5
Assert.Equal(this._redirectHandler.InnerHandler, this._testHttpMessageHandler);
Assert.IsType<RedirectHandler>(this._redirectHandler);
}
[Fact]
public void RedirectHandler_RedirectOptionConstructor()
{
// Assert
using RedirectHandler redirect = new RedirectHandler(new RedirectHandlerOption { MaxRedirect = 2, AllowRedirectOnSchemeChange = true });
Assert.Null(redirect.InnerHandler);
Assert.NotNull(redirect.RedirectOption);
Assert.Equal(2, redirect.RedirectOption.MaxRedirect);
Assert.True(redirect.RedirectOption.AllowRedirectOnSchemeChange);
Assert.IsType<RedirectHandler>(redirect);
}
[Fact]
public async Task OkStatusShouldPassThrough()
{
using(var httpRequestMessage = new HttpRequestMessage(HttpMethod.Get, "http://example.org/foo"))
{
// Arrange
var redirectResponse = new HttpResponseMessage(HttpStatusCode.OK);
this._testHttpMessageHandler.SetHttpResponse(redirectResponse); // sets the mock response
// Act
var response = await this._invoker.SendAsync(httpRequestMessage, new CancellationToken());
// Assert
Assert.Equal(HttpStatusCode.OK, response.StatusCode);
Assert.Same(response.RequestMessage, httpRequestMessage);
}
}
[Theory]
[InlineData(HttpStatusCode.MovedPermanently)] // 301
[InlineData(HttpStatusCode.Found)] // 302
[InlineData(HttpStatusCode.TemporaryRedirect)] // 307
[InlineData((HttpStatusCode)308)] // 308 not available in netstandard
public async Task ShouldRedirectSameMethodAndContent(HttpStatusCode statusCode)
{
using(var httpRequestMessage = new HttpRequestMessage(HttpMethod.Post, "http://example.org/foo"))
{
// Arrange
httpRequestMessage.Content = new StringContent("Hello World");
var redirectResponse = new HttpResponseMessage(statusCode);
redirectResponse.Headers.Location = new Uri("http://example.org/bar");
this._testHttpMessageHandler.SetHttpResponse(redirectResponse, new HttpResponseMessage(HttpStatusCode.OK));// sets the mock response
// Act
var response = await _invoker.SendAsync(httpRequestMessage, new CancellationToken());
// Assert
Assert.Equal(response.RequestMessage?.Method, httpRequestMessage.Method);
Assert.NotSame(response.RequestMessage, httpRequestMessage);
Assert.NotNull(response.RequestMessage?.Content);
Assert.Equal("Hello World", await response.RequestMessage.Content.ReadAsStringAsync(
#if NET5_0_OR_GREATER
TestContext.Current.CancellationToken
#endif
));
}
}
[Fact]
public async Task ShouldRedirectChangeMethodAndContent()
{
using(var httpRequestMessage = new HttpRequestMessage(HttpMethod.Post, "http://example.org/foo"))
{
// Arrange
httpRequestMessage.Content = new StringContent("Hello World");
var redirectResponse = new HttpResponseMessage(HttpStatusCode.SeeOther);
redirectResponse.Headers.Location = new Uri("http://example.org/bar");
this._testHttpMessageHandler.SetHttpResponse(redirectResponse, new HttpResponseMessage(HttpStatusCode.OK));// sets the mock response
// Act
var response = await _invoker.SendAsync(httpRequestMessage, new CancellationToken());
// Assert
Assert.NotEqual(response.RequestMessage?.Method, httpRequestMessage.Method);
Assert.Equal(response.RequestMessage?.Method, HttpMethod.Get);
Assert.NotSame(response.RequestMessage, httpRequestMessage);
Assert.Null(response.RequestMessage?.Content);
}
}
[Theory]
[InlineData(HttpStatusCode.MovedPermanently)] // 301
[InlineData(HttpStatusCode.Found)] // 302
[InlineData(HttpStatusCode.TemporaryRedirect)] // 307
[InlineData((HttpStatusCode)308)] // 308
public async Task RedirectWithDifferentHostShouldRemoveAuthHeader(HttpStatusCode statusCode)
{
using(var httpRequestMessage = new HttpRequestMessage(HttpMethod.Get, "http://example.org/foo"))
{
// Arrange
httpRequestMessage.Headers.Authorization = new AuthenticationHeaderValue("fooAuth", "aparam");
var redirectResponse = new HttpResponseMessage(statusCode);
redirectResponse.Headers.Location = new Uri("http://example.net/bar");
this._testHttpMessageHandler.SetHttpResponse(redirectResponse, new HttpResponseMessage(HttpStatusCode.OK));// sets the mock response
// Act
var response = await _invoker.SendAsync(httpRequestMessage, new CancellationToken());
// Assert
Assert.NotSame(response.RequestMessage, httpRequestMessage);
Assert.NotSame(response.RequestMessage?.RequestUri?.Host, httpRequestMessage.RequestUri?.Host);
Assert.Null(response.RequestMessage?.Headers.Authorization);
}
}
[Theory]
[InlineData(HttpStatusCode.MovedPermanently)] // 301
[InlineData(HttpStatusCode.Found)] // 302
[InlineData(HttpStatusCode.TemporaryRedirect)] // 307
[InlineData((HttpStatusCode)308)] // 308
public async Task RedirectWithDifferentSchemeThrowsInvalidOperationExceptionIfAllowRedirectOnSchemeChangeIsDisabled(HttpStatusCode statusCode)
{
using(var httpRequestMessage = new HttpRequestMessage(HttpMethod.Get, "https://example.org/foo"))
{
// Arrange
httpRequestMessage.Headers.Authorization = new AuthenticationHeaderValue("fooAuth", "aparam");
var redirectResponse = new HttpResponseMessage(statusCode);
redirectResponse.Headers.Location = new Uri("http://example.org/bar");
this._testHttpMessageHandler.SetHttpResponse(redirectResponse, new HttpResponseMessage(HttpStatusCode.OK));// sets the mock response
// Act
var exception = await Assert.ThrowsAsync<InvalidOperationException>(() => this._invoker.SendAsync(httpRequestMessage, CancellationToken.None));
// Assert
Assert.Contains("Redirects with changing schemes not allowed by default", exception.Message);
Assert.Equal("Scheme changed from https to http.", exception.InnerException?.Message);
Assert.IsType<InvalidOperationException>(exception);
}
}
[Theory]
[InlineData(HttpStatusCode.MovedPermanently)] // 301
[InlineData(HttpStatusCode.Found)] // 302
[InlineData(HttpStatusCode.TemporaryRedirect)] // 307
[InlineData((HttpStatusCode)308)] // 308
public async Task RedirectWithDifferentSchemeShouldRemoveAuthHeaderIfAllowRedirectOnSchemeChangeIsEnabled(HttpStatusCode statusCode)
{
using(var httpRequestMessage = new HttpRequestMessage(HttpMethod.Get, "https://example.org/foo"))
{
// Arrange
httpRequestMessage.Headers.Authorization = new AuthenticationHeaderValue("fooAuth", "aparam");
var redirectResponse = new HttpResponseMessage(statusCode);
redirectResponse.Headers.Location = new Uri("http://example.org/bar");
this._redirectHandler.RedirectOption.AllowRedirectOnSchemeChange = true;// Enable redirects on scheme change
this._testHttpMessageHandler.SetHttpResponse(redirectResponse, new HttpResponseMessage(HttpStatusCode.OK));// sets the mock response
// Act
var response = await _invoker.SendAsync(httpRequestMessage, new CancellationToken());
// Assert
Assert.NotSame(response.RequestMessage, httpRequestMessage);
Assert.NotSame(response.RequestMessage?.RequestUri?.Scheme, httpRequestMessage.RequestUri?.Scheme);
Assert.Null(response.RequestMessage?.Headers.Authorization);
}
}
[Fact]
public async Task RedirectWithSameHostShouldKeepAuthHeader()
{
using(var httpRequestMessage = new HttpRequestMessage(HttpMethod.Post, "http://example.org/foo"))
{
// Arrange
httpRequestMessage.Headers.Authorization = new AuthenticationHeaderValue("fooAuth", "aparam");
var redirectResponse = new HttpResponseMessage(HttpStatusCode.Redirect);
redirectResponse.Headers.Location = new Uri("http://example.org/bar");
this._testHttpMessageHandler.SetHttpResponse(redirectResponse, new HttpResponseMessage(HttpStatusCode.OK));// sets the mock response
// Act
var response = await _invoker.SendAsync(httpRequestMessage, new CancellationToken());
// Assert
Assert.NotSame(response.RequestMessage, httpRequestMessage);
Assert.Equal(response.RequestMessage?.RequestUri?.Host, httpRequestMessage.RequestUri?.Host);
Assert.NotNull(response.RequestMessage?.Headers.Authorization);
}
}
[Theory]
[InlineData(HttpStatusCode.MovedPermanently)] // 301
[InlineData(HttpStatusCode.Found)] // 302
[InlineData(HttpStatusCode.TemporaryRedirect)] // 307
[InlineData((HttpStatusCode)308)] // 308
public async Task RedirectWithDifferentPortShouldRemoveAuthHeader(HttpStatusCode statusCode)
{
using(var httpRequestMessage = new HttpRequestMessage(HttpMethod.Get, "http://example.org:8080/foo"))
{
// Arrange
httpRequestMessage.Headers.Authorization = new AuthenticationHeaderValue("fooAuth", "aparam");
var redirectResponse = new HttpResponseMessage(statusCode);
redirectResponse.Headers.Location = new Uri("http://example.org:9090/bar");
this._testHttpMessageHandler.SetHttpResponse(redirectResponse, new HttpResponseMessage(HttpStatusCode.OK));// sets the mock response
// Act
var response = await _invoker.SendAsync(httpRequestMessage, new CancellationToken());
// Assert
Assert.NotSame(response.RequestMessage, httpRequestMessage);
Assert.Equal(response.RequestMessage?.RequestUri?.Host, httpRequestMessage.RequestUri?.Host);
Assert.NotEqual(response.RequestMessage?.RequestUri?.Port, httpRequestMessage.RequestUri?.Port);
Assert.Null(response.RequestMessage?.Headers.Authorization);
}
}
[Theory]
[InlineData(HttpStatusCode.MovedPermanently)] // 301
[InlineData(HttpStatusCode.Found)] // 302
[InlineData(HttpStatusCode.TemporaryRedirect)] // 307
[InlineData((HttpStatusCode)308)] // 308
public async Task RedirectWithDifferentPortShouldRemoveCookieHeader(HttpStatusCode statusCode)
{
using(var httpRequestMessage = new HttpRequestMessage(HttpMethod.Get, "http://example.org:8080/foo"))
{
// Arrange
httpRequestMessage.Headers.Add("Cookie", "session=abc123");
var redirectResponse = new HttpResponseMessage(statusCode);
redirectResponse.Headers.Location = new Uri("http://example.org:9090/bar");
this._testHttpMessageHandler.SetHttpResponse(redirectResponse, new HttpResponseMessage(HttpStatusCode.OK));// sets the mock response
// Act
var response = await _invoker.SendAsync(httpRequestMessage, new CancellationToken());
// Assert
Assert.NotSame(response.RequestMessage, httpRequestMessage);
Assert.Equal(response.RequestMessage?.RequestUri?.Host, httpRequestMessage.RequestUri?.Host);
Assert.NotEqual(response.RequestMessage?.RequestUri?.Port, httpRequestMessage.RequestUri?.Port);
Assert.False(response.RequestMessage?.Headers.Contains("Cookie"));
}
}
[Fact]
public async Task RedirectWithSamePortShouldKeepAuthHeader()
{
using(var httpRequestMessage = new HttpRequestMessage(HttpMethod.Post, "http://example.org:8080/foo"))
{
// Arrange
httpRequestMessage.Headers.Authorization = new AuthenticationHeaderValue("fooAuth", "aparam");
var redirectResponse = new HttpResponseMessage(HttpStatusCode.Redirect);
redirectResponse.Headers.Location = new Uri("http://example.org:8080/bar");
this._testHttpMessageHandler.SetHttpResponse(redirectResponse, new HttpResponseMessage(HttpStatusCode.OK));// sets the mock response
// Act
var response = await _invoker.SendAsync(httpRequestMessage, new CancellationToken());
// Assert
Assert.NotSame(response.RequestMessage, httpRequestMessage);
Assert.Equal(response.RequestMessage?.RequestUri?.Host, httpRequestMessage.RequestUri?.Host);
Assert.Equal(response.RequestMessage?.RequestUri?.Port, httpRequestMessage.RequestUri?.Port);
Assert.NotNull(response.RequestMessage?.Headers.Authorization);
}
}
[Fact]
public async Task RedirectWithRelativeUrlShouldKeepRequestHost()
{
using(var httpRequestMessage = new HttpRequestMessage(HttpMethod.Post, "http://example.org/foo"))
{ // Arrange
var redirectResponse = new HttpResponseMessage(HttpStatusCode.Redirect);
redirectResponse.Headers.Location = new Uri("/bar", UriKind.Relative);
this._testHttpMessageHandler.SetHttpResponse(redirectResponse, new HttpResponseMessage(HttpStatusCode.OK));// sets the mock response
// Act
var response = await _invoker.SendAsync(httpRequestMessage, new CancellationToken());
// Assert
Assert.NotSame(response.RequestMessage, httpRequestMessage);
Assert.Equal("http://example.org/bar", response.RequestMessage?.RequestUri?.AbsoluteUri);
}
}
[Fact]
public async Task ExceedMaxRedirectsShouldThrowsException()
{
using(var httpRequestMessage = new HttpRequestMessage(HttpMethod.Post, "http://example.org/foo"))
{
// Arrange
var response1 = new HttpResponseMessage(HttpStatusCode.Redirect);
response1.Headers.Location = new Uri("http://example.org/bar");
var response2 = new HttpResponseMessage(HttpStatusCode.Redirect);
response2.Headers.Location = new Uri("http://example.org/foo");
this._testHttpMessageHandler.SetHttpResponse(response1, response2);// sets the mock response
// Act
var exception = await Assert.ThrowsAsync<InvalidOperationException>(() => this._invoker.SendAsync(
httpRequestMessage, CancellationToken.None));
// Assert
Assert.Equal("Too many redirects performed", exception.Message);
Assert.Equal("Max redirects exceeded. Redirect count : 5", exception.InnerException?.Message);
Assert.IsType<InvalidOperationException>(exception);
}
}
[Theory]
[InlineData(HttpStatusCode.MovedPermanently)] // 301
[InlineData(HttpStatusCode.Found)] // 302
[InlineData(HttpStatusCode.TemporaryRedirect)] // 307
[InlineData((HttpStatusCode)308)] // 308
public async Task RedirectWithDifferentHostShouldRemoveProxyAuthHeaderWhenNoProxyConfigured(HttpStatusCode statusCode)
{
using(var httpRequestMessage = new HttpRequestMessage(HttpMethod.Get, "http://example.org/foo"))
{
// Arrange - No proxy is configured, so ProxyAuthorization should be removed
httpRequestMessage.Headers.ProxyAuthorization = new AuthenticationHeaderValue("fooAuth", "aparam");
var redirectResponse = new HttpResponseMessage(statusCode);
redirectResponse.Headers.Location = new Uri("http://example.net/bar");
this._testHttpMessageHandler.SetHttpResponse(redirectResponse, new HttpResponseMessage(HttpStatusCode.OK));// sets the mock response
// Act
var response = await _invoker.SendAsync(httpRequestMessage, new CancellationToken());
// Assert - ProxyAuthorization is removed when no proxy is configured
Assert.NotSame(response.RequestMessage, httpRequestMessage);
Assert.NotSame(response.RequestMessage?.RequestUri?.Host, httpRequestMessage.RequestUri?.Host);
Assert.Null(response.RequestMessage?.Headers.ProxyAuthorization);
}
}
[Theory]
[InlineData(HttpStatusCode.MovedPermanently)] // 301
[InlineData(HttpStatusCode.Found)] // 302
[InlineData(HttpStatusCode.TemporaryRedirect)] // 307
[InlineData((HttpStatusCode)308)] // 308
public async Task RedirectWithDifferentHostShouldRemoveCookieHeader(HttpStatusCode statusCode)
{
using(var httpRequestMessage = new HttpRequestMessage(HttpMethod.Get, "http://example.org/foo"))
{
// Arrange
httpRequestMessage.Headers.Add("Cookie", "session=abc123");
var redirectResponse = new HttpResponseMessage(statusCode);
redirectResponse.Headers.Location = new Uri("http://example.net/bar");
this._testHttpMessageHandler.SetHttpResponse(redirectResponse, new HttpResponseMessage(HttpStatusCode.OK));// sets the mock response
// Act
var response = await _invoker.SendAsync(httpRequestMessage, new CancellationToken());
// Assert
Assert.NotSame(response.RequestMessage, httpRequestMessage);
Assert.NotSame(response.RequestMessage?.RequestUri?.Host, httpRequestMessage.RequestUri?.Host);
Assert.False(response.RequestMessage?.Headers.Contains("Cookie"));
}
}
[Theory]
[InlineData(HttpStatusCode.MovedPermanently)] // 301
[InlineData(HttpStatusCode.Found)] // 302
[InlineData(HttpStatusCode.TemporaryRedirect)] // 307
[InlineData((HttpStatusCode)308)] // 308
public async Task RedirectWithDifferentHostShouldRemoveCustomHeadersWithCustomCallback(HttpStatusCode statusCode)
{
// Arrange - Custom callback that removes additional headers on host change
var redirectOption = new RedirectHandlerOption
{
ScrubSensitiveHeaders = (request, originalUri, newUri, proxyResolver) =>
{
// Call default implementation first
RedirectHandlerOption.DefaultScrubSensitiveHeaders(request, originalUri, newUri, proxyResolver);
// Then add custom logic for additional headers
var isDifferentHostOrScheme = !newUri.Host.Equals(originalUri.Host, StringComparison.OrdinalIgnoreCase) ||
!newUri.Scheme.Equals(originalUri.Scheme, StringComparison.OrdinalIgnoreCase);
if(isDifferentHostOrScheme)
{
request.Headers.Remove("X-Api-Key");
request.Headers.Remove("X-Custom-Auth");
}
}
};
var mockHandler = new MockRedirectHandler();
var redirectHandler = new RedirectHandler(redirectOption)
{
InnerHandler = mockHandler
};
using var invoker = new HttpMessageInvoker(redirectHandler);
using var httpRequestMessage = new HttpRequestMessage(HttpMethod.Get, "http://example.org/foo");
httpRequestMessage.Headers.Add("X-Api-Key", "secret-api-key");
httpRequestMessage.Headers.Add("X-Custom-Auth", "custom-auth-value");
httpRequestMessage.Headers.Add("X-Safe-Header", "should-remain");
var redirectResponse = new HttpResponseMessage(statusCode);
redirectResponse.Headers.Location = new Uri("http://example.net/bar");
mockHandler.SetHttpResponse(redirectResponse, new HttpResponseMessage(HttpStatusCode.OK));
// Act
var response = await invoker.SendAsync(httpRequestMessage, CancellationToken.None);
// Assert - Custom headers should be removed, but non-sensitive should remain
Assert.NotSame(response.RequestMessage, httpRequestMessage);
Assert.False(response.RequestMessage?.Headers.Contains("X-Api-Key"));
Assert.False(response.RequestMessage?.Headers.Contains("X-Custom-Auth"));
Assert.True(response.RequestMessage?.Headers.Contains("X-Safe-Header"));
}
[Theory]
[InlineData(HttpStatusCode.MovedPermanently)] // 301
[InlineData(HttpStatusCode.Found)] // 302
[InlineData(HttpStatusCode.TemporaryRedirect)] // 307
[InlineData((HttpStatusCode)308)] // 308
public async Task RedirectWithDifferentSchemeShouldRemoveCustomHeadersWithCustomCallback(HttpStatusCode statusCode)
{
// Arrange - Custom callback that removes additional headers on scheme change
var redirectOption = new RedirectHandlerOption
{
AllowRedirectOnSchemeChange = true,
ScrubSensitiveHeaders = (request, originalUri, newUri, proxyResolver) =>
{
RedirectHandlerOption.DefaultScrubSensitiveHeaders(request, originalUri, newUri, proxyResolver);
var isDifferentHostOrScheme = !newUri.Host.Equals(originalUri.Host, StringComparison.OrdinalIgnoreCase) ||
!newUri.Scheme.Equals(originalUri.Scheme, StringComparison.OrdinalIgnoreCase);
if(isDifferentHostOrScheme)
{
request.Headers.Remove("X-Api-Key");
}
}
};
var mockHandler = new MockRedirectHandler();
var redirectHandler = new RedirectHandler(redirectOption)
{
InnerHandler = mockHandler
};
using var invoker = new HttpMessageInvoker(redirectHandler);
using var httpRequestMessage = new HttpRequestMessage(HttpMethod.Get, "https://example.org/foo");
httpRequestMessage.Headers.Add("X-Api-Key", "secret-api-key");
var redirectResponse = new HttpResponseMessage(statusCode);
redirectResponse.Headers.Location = new Uri("http://example.org/bar");
mockHandler.SetHttpResponse(redirectResponse, new HttpResponseMessage(HttpStatusCode.OK));
// Act
var response = await invoker.SendAsync(httpRequestMessage, CancellationToken.None);
// Assert - Custom headers should be removed on scheme change
Assert.NotSame(response.RequestMessage, httpRequestMessage);
Assert.False(response.RequestMessage?.Headers.Contains("X-Api-Key"));
}
[Fact]
public async Task RedirectWithSameHostAndSchemeCustomCallbackShouldKeepCustomHeaders()
{
// Arrange - Custom callback that only removes headers on host/scheme change
var redirectOption = new RedirectHandlerOption
{
ScrubSensitiveHeaders = (request, originalUri, newUri, proxyResolver) =>
{
RedirectHandlerOption.DefaultScrubSensitiveHeaders(request, originalUri, newUri, proxyResolver);
var isDifferentHostOrScheme = !newUri.Host.Equals(originalUri.Host, StringComparison.OrdinalIgnoreCase) ||
!newUri.Scheme.Equals(originalUri.Scheme, StringComparison.OrdinalIgnoreCase);
if(isDifferentHostOrScheme)
{
request.Headers.Remove("X-Api-Key");
}
}
};
var mockHandler = new MockRedirectHandler();
var redirectHandler = new RedirectHandler(redirectOption)
{
InnerHandler = mockHandler
};
using var invoker = new HttpMessageInvoker(redirectHandler);
using var httpRequestMessage = new HttpRequestMessage(HttpMethod.Get, "http://example.org/foo");
httpRequestMessage.Headers.Add("X-Api-Key", "secret-api-key");
var redirectResponse = new HttpResponseMessage(HttpStatusCode.Redirect);
redirectResponse.Headers.Location = new Uri("http://example.org/bar"); // Same host and scheme
mockHandler.SetHttpResponse(redirectResponse, new HttpResponseMessage(HttpStatusCode.OK));
// Act
var response = await invoker.SendAsync(httpRequestMessage, CancellationToken.None);
// Assert - Custom headers should be kept when host and scheme are the same
Assert.NotSame(response.RequestMessage, httpRequestMessage);
Assert.True(response.RequestMessage?.Headers.Contains("X-Api-Key"));
}
[Fact]
public async Task DefaultScrubSensitiveHeadersMethodCanBeReferencedDirectly()
{
// Arrange - Verify that the default static method can be referenced and used
var redirectOption = new RedirectHandlerOption
{
// Explicitly set to default to verify it's accessible
ScrubSensitiveHeaders = RedirectHandlerOption.DefaultScrubSensitiveHeaders
};
var mockHandler = new MockRedirectHandler();
var redirectHandler = new RedirectHandler(redirectOption)
{
InnerHandler = mockHandler
};
using var invoker = new HttpMessageInvoker(redirectHandler);
using var httpRequestMessage = new HttpRequestMessage(HttpMethod.Get, "http://example.org/foo");
httpRequestMessage.Headers.Authorization = new AuthenticationHeaderValue("Bearer", "token");
var redirectResponse = new HttpResponseMessage(HttpStatusCode.Redirect);
redirectResponse.Headers.Location = new Uri("http://example.net/bar");
mockHandler.SetHttpResponse(redirectResponse, new HttpResponseMessage(HttpStatusCode.OK));
// Act
var response = await invoker.SendAsync(httpRequestMessage, CancellationToken.None);
// Assert - Default behavior should remove Authorization on host change
Assert.Null(response.RequestMessage?.Headers.Authorization);
}
#if !BROWSER
[Theory]
[InlineData(HttpStatusCode.MovedPermanently)] // 301
[InlineData(HttpStatusCode.Found)] // 302
[InlineData(HttpStatusCode.TemporaryRedirect)] // 307
[InlineData((HttpStatusCode)308)] // 308
public async Task CustomCallbackCanUseProxyResolverToKeepHeadersWhenProxyActive(HttpStatusCode statusCode)
{
// Arrange - Custom callback that only removes custom headers when proxy is inactive
var mockProxy = new MockWebProxy(new Uri("http://proxy.example.com:8080")); // no bypasses
var httpClientHandler = new HttpClientHandler { Proxy = mockProxy };
var mockHandler = new MockDelegatingRedirectHandler
{
InnerHandler = httpClientHandler
};
var redirectOption = new RedirectHandlerOption
{
ScrubSensitiveHeaders = (request, originalUri, newUri, proxyResolver) =>
{
// Call default implementation
RedirectHandlerOption.DefaultScrubSensitiveHeaders(request, originalUri, newUri, proxyResolver);
// Only remove X-Api-Key if proxy is inactive (like ProxyAuthorization logic)
var isProxyInactive = proxyResolver == null || proxyResolver(newUri) == null;
var isDifferentHostOrScheme = !newUri.Host.Equals(originalUri.Host, StringComparison.OrdinalIgnoreCase) ||
!newUri.Scheme.Equals(originalUri.Scheme, StringComparison.OrdinalIgnoreCase);
if(isProxyInactive && isDifferentHostOrScheme)
{
request.Headers.Remove("X-Api-Key");
}
}
};
var redirectHandler = new RedirectHandler(redirectOption)
{
InnerHandler = mockHandler
};
using var invoker = new HttpMessageInvoker(redirectHandler);
using var httpRequestMessage = new HttpRequestMessage(HttpMethod.Get, "http://example.org/foo");
httpRequestMessage.Headers.Add("X-Api-Key", "secret-api-key");
var redirectResponse = new HttpResponseMessage(statusCode);
redirectResponse.Headers.Location = new Uri("http://example.net/bar"); // different host, but proxy is active
mockHandler.SetHttpResponse(redirectResponse, new HttpResponseMessage(HttpStatusCode.OK));
// Act
var response = await invoker.SendAsync(httpRequestMessage, CancellationToken.None);
// Assert - X-Api-Key should be kept because proxy is active
Assert.NotSame(response.RequestMessage, httpRequestMessage);
Assert.True(response.RequestMessage?.Headers.Contains("X-Api-Key"));
}
#endif
[Theory]
[InlineData(HttpStatusCode.MovedPermanently)] // 301
[InlineData(HttpStatusCode.Found)] // 302
[InlineData(HttpStatusCode.TemporaryRedirect)] // 307
[InlineData((HttpStatusCode)308)] // 308
public async Task RedirectWithDifferentSchemeShouldRemoveProxyAuthHeaderWhenNoProxyConfigured(HttpStatusCode statusCode)
{
using(var httpRequestMessage = new HttpRequestMessage(HttpMethod.Get, "https://example.org/foo"))
{
// Arrange - No proxy is configured, so ProxyAuthorization should be removed
httpRequestMessage.Headers.ProxyAuthorization = new AuthenticationHeaderValue("fooAuth", "aparam");
var redirectResponse = new HttpResponseMessage(statusCode);
redirectResponse.Headers.Location = new Uri("http://example.org/bar");
this._redirectHandler.RedirectOption.AllowRedirectOnSchemeChange = true;// Enable redirects on scheme change
this._testHttpMessageHandler.SetHttpResponse(redirectResponse, new HttpResponseMessage(HttpStatusCode.OK));// sets the mock response
// Act
var response = await _invoker.SendAsync(httpRequestMessage, new CancellationToken());
// Assert - ProxyAuthorization is removed when no proxy is configured
Assert.NotSame(response.RequestMessage, httpRequestMessage);
Assert.NotSame(response.RequestMessage?.RequestUri?.Scheme, httpRequestMessage.RequestUri?.Scheme);
Assert.Null(response.RequestMessage?.Headers.ProxyAuthorization);
}
}
[Theory]
[InlineData(HttpStatusCode.MovedPermanently)] // 301
[InlineData(HttpStatusCode.Found)] // 302
[InlineData(HttpStatusCode.TemporaryRedirect)] // 307
[InlineData((HttpStatusCode)308)] // 308
public async Task RedirectWithDifferentSchemeShouldRemoveCookieHeaderIfAllowRedirectOnSchemeChangeIsEnabled(HttpStatusCode statusCode)
{
using(var httpRequestMessage = new HttpRequestMessage(HttpMethod.Get, "https://example.org/foo"))
{
// Arrange
httpRequestMessage.Headers.Add("Cookie", "session=abc123");
var redirectResponse = new HttpResponseMessage(statusCode);
redirectResponse.Headers.Location = new Uri("http://example.org/bar");
this._redirectHandler.RedirectOption.AllowRedirectOnSchemeChange = true;// Enable redirects on scheme change
this._testHttpMessageHandler.SetHttpResponse(redirectResponse, new HttpResponseMessage(HttpStatusCode.OK));// sets the mock response
// Act
var response = await _invoker.SendAsync(httpRequestMessage, new CancellationToken());
// Assert
Assert.NotSame(response.RequestMessage, httpRequestMessage);
Assert.NotSame(response.RequestMessage?.RequestUri?.Scheme, httpRequestMessage.RequestUri?.Scheme);
Assert.False(response.RequestMessage?.Headers.Contains("Cookie"));
}
}
[Fact]
public async Task RedirectWithSameHostShouldRemoveProxyAuthHeaderWhenNoProxyConfigured()
{
using(var httpRequestMessage = new HttpRequestMessage(HttpMethod.Post, "http://example.org/foo"))
{
// Arrange - No proxy is configured, so ProxyAuthorization should be removed
httpRequestMessage.Headers.ProxyAuthorization = new AuthenticationHeaderValue("fooAuth", "aparam");
var redirectResponse = new HttpResponseMessage(HttpStatusCode.Redirect);
redirectResponse.Headers.Location = new Uri("http://example.org/bar");
this._testHttpMessageHandler.SetHttpResponse(redirectResponse, new HttpResponseMessage(HttpStatusCode.OK));// sets the mock response
// Act
var response = await _invoker.SendAsync(httpRequestMessage, new CancellationToken());
// Assert - ProxyAuthorization is removed when no proxy is configured
Assert.NotSame(response.RequestMessage, httpRequestMessage);
Assert.Equal(response.RequestMessage?.RequestUri?.Host, httpRequestMessage.RequestUri?.Host);
Assert.Null(response.RequestMessage?.Headers.ProxyAuthorization);
}
}
[Fact]
public async Task RedirectWithSameHostShouldKeepCookieHeader()
{
using(var httpRequestMessage = new HttpRequestMessage(HttpMethod.Post, "http://example.org/foo"))
{
// Arrange
httpRequestMessage.Headers.Add("Cookie", "session=abc123");
var redirectResponse = new HttpResponseMessage(HttpStatusCode.Redirect);
redirectResponse.Headers.Location = new Uri("http://example.org/bar");
this._testHttpMessageHandler.SetHttpResponse(redirectResponse, new HttpResponseMessage(HttpStatusCode.OK));// sets the mock response
// Act
var response = await _invoker.SendAsync(httpRequestMessage, new CancellationToken());
// Assert
Assert.NotSame(response.RequestMessage, httpRequestMessage);
Assert.Equal(response.RequestMessage?.RequestUri?.Host, httpRequestMessage.RequestUri?.Host);
Assert.True(response.RequestMessage?.Headers.Contains("Cookie"));
}
}
#if !BROWSER
[Theory]
[InlineData(HttpStatusCode.MovedPermanently)] // 301
[InlineData(HttpStatusCode.Found)] // 302
[InlineData(HttpStatusCode.TemporaryRedirect)] // 307
[InlineData((HttpStatusCode)308)] // 308
public async Task RedirectToBypassedProxyUrlShouldRemoveProxyAuthHeader(HttpStatusCode statusCode)
{
// Arrange - Create a handler chain with a proxy that bypasses "internal.local"
var mockProxy = new MockWebProxy(new Uri("http://proxy.example.com:8080"), "internal.local");
var httpClientHandler = new HttpClientHandler { Proxy = mockProxy };
var mockHandler = new MockDelegatingRedirectHandler
{
InnerHandler = httpClientHandler
};
var redirectHandler = new RedirectHandler
{
InnerHandler = mockHandler
};
using var invoker = new HttpMessageInvoker(redirectHandler);
using var httpRequestMessage = new HttpRequestMessage(HttpMethod.Get, "http://example.org/foo");
httpRequestMessage.Headers.ProxyAuthorization = new AuthenticationHeaderValue("Basic", "creds");
var redirectResponse = new HttpResponseMessage(statusCode);
redirectResponse.Headers.Location = new Uri("http://internal.local/bar"); // Bypassed by proxy
mockHandler.SetHttpResponse(redirectResponse, new HttpResponseMessage(HttpStatusCode.OK));
// Act
var response = await invoker.SendAsync(httpRequestMessage, CancellationToken.None);
// Assert - ProxyAuthorization should be removed because internal.local is bypassed
Assert.NotSame(response.RequestMessage, httpRequestMessage);
Assert.Null(response.RequestMessage?.Headers.ProxyAuthorization);
}
[Theory]
[InlineData(HttpStatusCode.MovedPermanently)] // 301
[InlineData(HttpStatusCode.Found)] // 302
[InlineData(HttpStatusCode.TemporaryRedirect)] // 307
[InlineData((HttpStatusCode)308)] // 308
public async Task RedirectToProxiedUrlShouldKeepProxyAuthHeader(HttpStatusCode statusCode)
{
// Arrange - Create a handler chain with a proxy that bypasses "internal.local"
var mockProxy = new MockWebProxy(new Uri("http://proxy.example.com:8080"), "internal.local");
var httpClientHandler = new HttpClientHandler { Proxy = mockProxy };
var mockHandler = new MockDelegatingRedirectHandler
{
InnerHandler = httpClientHandler
};
var redirectHandler = new RedirectHandler
{
InnerHandler = mockHandler
};
using var invoker = new HttpMessageInvoker(redirectHandler);
using var httpRequestMessage = new HttpRequestMessage(HttpMethod.Get, "http://example.org/foo");
httpRequestMessage.Headers.ProxyAuthorization = new AuthenticationHeaderValue("Basic", "creds");
var redirectResponse = new HttpResponseMessage(statusCode);
redirectResponse.Headers.Location = new Uri("http://example.org/bar"); // NOT bypassed, requires proxy
mockHandler.SetHttpResponse(redirectResponse, new HttpResponseMessage(HttpStatusCode.OK));
// Act
var response = await invoker.SendAsync(httpRequestMessage, CancellationToken.None);
// Assert - ProxyAuthorization should be kept because example.org requires proxy
Assert.NotSame(response.RequestMessage, httpRequestMessage);
Assert.NotNull(response.RequestMessage?.Headers.ProxyAuthorization);
}
[Fact]
public async Task RedirectWithNoProxyConfiguredShouldRemoveProxyAuthHeader()
{
// Arrange - Create a handler chain without a proxy configured
var httpClientHandler = new HttpClientHandler { Proxy = null };
var mockHandler = new MockDelegatingRedirectHandler
{
InnerHandler = httpClientHandler
};
var redirectHandler = new RedirectHandler
{
InnerHandler = mockHandler
};
using var invoker = new HttpMessageInvoker(redirectHandler);
using var httpRequestMessage = new HttpRequestMessage(HttpMethod.Get, "http://example.org/foo");
httpRequestMessage.Headers.ProxyAuthorization = new AuthenticationHeaderValue("Basic", "creds");
var redirectResponse = new HttpResponseMessage(HttpStatusCode.Redirect);
redirectResponse.Headers.Location = new Uri("http://example.org/bar");
mockHandler.SetHttpResponse(redirectResponse, new HttpResponseMessage(HttpStatusCode.OK));
// Act
var response = await invoker.SendAsync(httpRequestMessage, CancellationToken.None);
// Assert - ProxyAuthorization should be removed when no proxy is configured
Assert.NotSame(response.RequestMessage, httpRequestMessage);
Assert.Null(response.RequestMessage?.Headers.ProxyAuthorization);
}
#endif
[Theory]
[InlineData(HttpStatusCode.MovedPermanently)] // 301
[InlineData(HttpStatusCode.Found)] // 302
[InlineData(HttpStatusCode.TemporaryRedirect)] // 307
[InlineData((HttpStatusCode)308)] // 308
public async Task RedirectResponseWithoutLocationHeaderShouldThrow(HttpStatusCode statusCode)
{
using var httpRequestMessage = new HttpRequestMessage(HttpMethod.Get, "http://example.org/foo");
// Arrange - redirect response with no Location header set
var redirectResponse = new HttpResponseMessage(statusCode); // Location intentionally omitted
this._testHttpMessageHandler.SetHttpResponse(redirectResponse);
// Act & Assert
var exception = await Assert.ThrowsAsync<InvalidOperationException>(
() => this._invoker.SendAsync(httpRequestMessage, CancellationToken.None));
Assert.Contains("Unable to perform redirect as Location Header is not set in response", exception.Message);
Assert.Contains(statusCode.ToString(), exception.InnerException?.Message);
}
[Theory]
[InlineData(HttpStatusCode.MovedPermanently)] // 301
[InlineData(HttpStatusCode.Found)] // 302
[InlineData(HttpStatusCode.TemporaryRedirect)] // 307
[InlineData((HttpStatusCode)308)] // 308
public async Task ShouldNotRedirectWhenShouldRedirectDelegateReturnsFalse(HttpStatusCode statusCode)
{
using var httpRequestMessage = new HttpRequestMessage(HttpMethod.Get, "http://example.org/foo");
// Arrange - ShouldRedirect delegate always returns false
this._redirectHandler.RedirectOption.ShouldRedirect = _ => false;
var redirectResponse = new HttpResponseMessage(statusCode);
redirectResponse.Headers.Location = new Uri("http://example.org/bar");
this._testHttpMessageHandler.SetHttpResponse(redirectResponse);
// Act
var response = await this._invoker.SendAsync(httpRequestMessage, CancellationToken.None);
// Assert - response is returned as-is without following the redirect
Assert.Equal(statusCode, response.StatusCode);
Assert.Same(response.RequestMessage, httpRequestMessage);
}
[Theory]
[InlineData(HttpStatusCode.MovedPermanently)] // 301
[InlineData(HttpStatusCode.Found)] // 302
[InlineData(HttpStatusCode.TemporaryRedirect)] // 307
[InlineData((HttpStatusCode)308)] // 308
public async Task ShouldNotRedirectWhenMaxRedirectIsZero(HttpStatusCode statusCode)
{
using var httpRequestMessage = new HttpRequestMessage(HttpMethod.Get, "http://example.org/foo");
// Arrange - MaxRedirect = 0 disables redirects entirely
this._redirectHandler.RedirectOption.MaxRedirect = 0;
var redirectResponse = new HttpResponseMessage(statusCode);
redirectResponse.Headers.Location = new Uri("http://example.org/bar");
this._testHttpMessageHandler.SetHttpResponse(redirectResponse);
// Act
var response = await this._invoker.SendAsync(httpRequestMessage, CancellationToken.None);
// Assert - response is returned as-is without following the redirect
Assert.Equal(statusCode, response.StatusCode);
Assert.Same(response.RequestMessage, httpRequestMessage);
}
}
}