Skip to content

MultiPartBody: Add Support for multiple Body Parts with the same name#530

Merged
baywet merged 6 commits into
microsoft:mainfrom
romanett:feature/extendMulitPartBody
Apr 3, 2025
Merged

MultiPartBody: Add Support for multiple Body Parts with the same name#530
baywet merged 6 commits into
microsoft:mainfrom
romanett:feature/extendMulitPartBody

Conversation

@romanett

@romanett romanett commented Mar 20, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor
  • change MultiPartbody internal dictionary key from string to Tuple<string, string?)
  • Add additional method overloads for GetPartValue RemovePart
  • Add EqualityComparer fro Tuple<string, string?>
  • Add failing Test showcasing the imminent breaking change
  • Add passing Test verifying the new intened behaviour

Fixes: #529

Add Support for multiple Body Parts with the same name
ab7799e 
- change MultiPartbody internal dictionary key from string to Tuple<string, string?)
- Add additional method overloads for GetPartValue<T> RemovePart
- Add EqualityComparer fro Tuple<string, string?>
- Add failing Test showcasing the imminent breaking change
- Add passing Test verifying the new intened behaviour
@romanett romanett requested a review from a team as a code owner March 20, 2025 08:54
@romanett romanett marked this pull request as draft March 20, 2025 08:55
@romanett

romanett commented Mar 20, 2025

Copy link
Copy Markdown
Contributor Author

@microsoft-github-policy-service agree

baywet
baywet requested changes Mar 20, 2025
View reviewed changes

@baywet baywet left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution!

Comment thread src/abstractions/MultipartBody.cs Outdated
Comment thread src/abstractions/MultipartBody.cs Outdated
Comment thread src/abstractions/MultipartBody.cs
Comment thread src/abstractions/MultipartBody.cs Outdated
@github-project-automation github-project-automation Bot moved this to In Progress 🚧 in Kiota Mar 20, 2025
@romanett romanett requested a review from baywet March 21, 2025 06:30
@romanett romanett marked this pull request as ready for review March 23, 2025 19:58
baywet
baywet reviewed Mar 24, 2025
View reviewed changes

@baywet baywet left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your patience.

Comment thread src/abstractions/MultipartBody.cs Outdated
Comment thread src/abstractions/MultipartBody.cs Outdated
Comment thread tests/abstractions/MultipartBodyTests.cs
baywet
baywet previously approved these changes Mar 25, 2025
View reviewed changes

@baywet baywet left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for making the changes!

@musale for an additional review here

@romanett romanett requested a review from baywet March 26, 2025 05:20
@romanett

romanett commented Apr 3, 2025

Copy link
Copy Markdown
Contributor Author

@baywet do you have a rough timeline when the next release will happen, that includes this fix?

@baywet

baywet commented Apr 3, 2025

Copy link
Copy Markdown
Member

Releases are automated, so once this PR merges, about a couple of hours usually.
I'll ping @musale again internally for a second review. Thanks for the nudge.

musale
musale approved these changes Apr 3, 2025
View reviewed changes

@musale musale left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you for the good work @romanett!

@baywet baywet merged commit 21bfc3f into microsoft:main Apr 3, 2025
@github-project-automation github-project-automation Bot moved this from In Progress 🚧 to Done ✔️ in Kiota Apr 3, 2025
@release-please release-please Bot mentioned this pull request Apr 3, 2025
Merged
This was referenced Aug 15, 2025
Closed
Open
Open
Open
Open
This was referenced Oct 19, 2025
Closed
Closed
Closed
Closed
Closed
Closed
This was referenced Dec 15, 2025
Closed
Closed
Closed
Merged
Closed
Closed
@dependabot dependabot Bot mentioned this pull request Jan 11, 2026
Open
This was referenced May 8, 2026
Merged
Open
Open
Merged
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@baywet baywet baywet approved these changes

+1 more reviewer

@musale musale musale approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

Kiota
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

MultiPartBody: Impossible to add multiple Body Parts with the same name

3 participants

@romanett @baywet @musale
⚡