Skip to content

Commit 0d06d3b

Browse files
authored
Remove unused function before version converter (#2816)
In old torch versions, until 2.9, the converted models include unused Rank onnx function which blocks version converter to function.
1 parent bfee593 commit 0d06d3b

File tree

1 file changed

+8
-2
lines changed

1 file changed

+8
-2
lines changed

onnxscript/version_converter/__init__.py

Lines changed: 8 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -37,8 +37,14 @@ def __init__(self, target_version: int, fallback: bool = False) -> None:
3737
super().__init__()
3838
self.target_version = target_version
3939
self.fallback = fallback
40-
# NOTE: The current version converter only supports inlined models.
41-
self._inline_pass = common_passes.InlinePass()
40+
self._inline_pass = ir.passes.Sequential(
41+
# NOTE: The current version converter only supports inlined models.
42+
common_passes.InlinePass(),
43+
# NOTE: Old torch version might include legacy Rank onnx functions which is
44+
# not used in the converted model.
45+
common_passes.RemoveUnusedFunctionsPass(),
46+
common_passes.RemoveUnusedOpsetsPass(),
47+
)
4248
self._convert_pass = _ConvertVersionPassRequiresInline(
4349
target_version=target_version,
4450
fallback=fallback,

0 commit comments

Comments
 (0)